TerminateTrait - Code Metrics - Inspection of "refactoring with trait (BC break change)" - spindle/spindle-collection - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 63f743...cd2958 )

by Hiraku

created 2017-06-25 03:49 UTC

TerminateTrait A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	56
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	0

Test Coverage

Coverage

75%

Importance

Changes

Metric	Value
wmc	6
lcom	1
cbo	0
dl	0
loc	56
ccs	15
cts	20
cp	0.75
rs	10
c	0
b	0
f	0

5 Methods

Rating	Name	Size	Complexity
A	join()	5	1
A	sum()	4	1
A	product()	4	1
A	count()	4	1
A	reduce()	14	2

<?php
namespace Spindle\Collection\Traits;

trait TerminateTrait
{
    /**
     * @return string
     */
    public function join($separator)
    {
        $arr = $this->toArray();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        return implode($separator, $arr);
    }

    /**
     * @return int|float
     */
    public function sum()
    {
        return $this->reduce('$_carry + $_', 0);
    }

    /**
     * @return int|float
     */
    public function product()
    {
        return $this->reduce('$_carry * $_', 1);
    }

    /**
     * @return int
     */
    public function count()
    {
        return $this->reduce('$_carry + 1', 0);
    }

    /**
     * @param string|callable $fn '$_carry + $_'
     * @param mixed $initial
     * @return mixed
     */
    public function reduce($fn, $initial = null)
    {
        $ops = $this->ops;
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->vars['_carry'] = $initial;
class MyClass { }

$x = new MyClass();
$x->foo = true;
        if (is_callable($fn)) {
            $fn_name = '_fn' . $this->fn_cnt++;
class MyClass { }

$x = new MyClass();
$x->foo = true;
            $this->vars[$fn_name] = $fn;
            $ops[] = '    $_carry = $' . $fn_name . '($_, $_carry);';
        } else {
            $ops[] = '    $_carry = ' . $fn . ';';
        }
        $after = '$_result = $_carry;';
        return self::evaluate($this->seed, $this->vars, $this->compile($ops), '', $after);
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }

}


1		<?php
2		namespace Spindle\Collection\Traits;
3
4		trait TerminateTrait
5		{
6		/**
7		* @return string
8		*/
9		public function join($separator)
10		{
11		$arr = $this->toArray();
		0 ignored issues – show Bug introduced 2017-06-25 03:51 UTC by Report Bug Copy Issue Report It seems like `toArray()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
12		return implode($separator, $arr);
13		}
14
15		/**
16		* @return int\|float
17		*/
18	3	public function sum()
19		{
20	3	return $this->reduce('$_carry + $_', 0);
21		}
22
23		/**
24		* @return int\|float
25		*/
26	1	public function product()
27		{
28	1	return $this->reduce('$_carry * $_', 1);
29		}
30
31		/**
32		* @return int
33		*/
34		public function count()
35		{
36		return $this->reduce('$_carry + 1', 0);
37		}
38
39		/**
40		* @param string\|callable $fn '$_carry + $_'
41		* @param mixed $initial
42		* @return mixed
43		*/
44	5	public function reduce($fn, $initial = null)
45		{
46	5	$ops = $this->ops;
		0 ignored issues – show Bug introduced 2017-06-25 03:51 UTC by Report Bug Copy Issue Report The property `ops` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
47	5	$this->vars['_carry'] = $initial;
		0 ignored issues – show Bug introduced 2017-06-25 03:51 UTC by Report Bug Copy Issue Report The property `vars` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
48	5	if (is_callable($fn)) {
49	1	$fn_name = '_fn' . $this->fn_cnt++;
		0 ignored issues – show Bug introduced 2017-06-25 03:51 UTC by Report Bug Copy Issue Report The property `fn_cnt` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
50	1	$this->vars[$fn_name] = $fn;
51	1	$ops[] = ' $_carry = $' . $fn_name . '($_, $_carry);';
52	1	} else {
53	5	$ops[] = ' $_carry = ' . $fn . ';';
54		}
55	5	$after = '$_result = $_carry;';
56	5	return self::evaluate($this->seed, $this->vars, $this->compile($ops), '', $after);
		0 ignored issues – show Bug introduced 2017-06-25 03:51 UTC by Report Bug Copy Issue Report The property `seed` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history... Bug introduced 2017-06-25 03:51 UTC by Report Bug Copy Issue Report It seems like `compile()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
57		}
58
59		}
60

spindle / spindle-collection

Push — master ( 63f743...cd2958 )

TerminateTrait A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

5 Methods

Duplication Side-by-Side

Filter issues like