Spindle\Collection\Traits\SortTrait

Complexity

Total Complexity

6

Size/Duplication

Total Lines	64
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	0

Test Coverage

Coverage

100%

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	usort()	0	6	1
A	rsort()	0	6	1
A	sort()	0	6	1
A	usortStable()	0	10	2
A	mapSort()	0	7	1

<?php
namespace Spindle\Collection\Traits;

trait SortTrait
{
    /**
     * @return \Spindle\Collection\Collection (new instance)
     */
    public function usort(callable $cmp)
    {
        $array = $this->toArray();

It seems like toArray() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        usort($array, $cmp);
        return new $this($array, $this->debug);

The property debug does not exist. Did you maybe forget to declare it?

    }

    /**
     * @param int $sort_flags \SORT_REGULAR|\SORT_NUMERIC|\SORT_STRING
     * @return \Spindle\Collection\Collection (new instance)
     */
    public function rsort($sort_flags = \SORT_REGULAR)
    {
        $array = $this->toArray();

It seems like toArray() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        rsort($array, $sort_flags);
        return new $this($array, $this->debug);
    }

    /**
     * @param int $sort_flags \SORT_REGULAR|\SORT_NUMERIC|\SORT_STRING
     * @return \Spindle\Collection\Collection (new instance)
     */
    public function sort($sort_flags = \SORT_REGULAR)
    {
        $array = $this->toArray();

It seems like toArray() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        sort($array, $sort_flags);
        return new $this($array, $this->debug);
    }

    /**
     * stable sort
     * @return \Spindle\Collection\Collection (new instance)
     */
    public function usortStable(callable $cmp)
    {
        $array = $this->map('[$_, $_i]')->toArray();

It seems like map() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        usort($array, static function ($a, $b) use ($cmp) {
            return $cmp($a[0], $b[0]) ?: ($a[1] - $b[1]);
        });
        $sorted = new $this($array, $this->debug);
        $sorted->column(0)->toArray();
        return $sorted;
    }

    /**
     * sort with Schwartzian Transform
     * @param string|callable $fn map function
     * @param SORT_ASC|SORT_DESC $sort_order
     * @param SORT_REGULAR|SORT_NUMERIC|SORT_STRING $sort_flags
     * @return \Spindle\Collection (new instance)
     */
    public function mapSort($fn, $sort_order = \SORT_ASC, $sort_flags = \SORT_REGULAR)
    {
        $array = $this->toArray();

It seems like toArray() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        $mapped = (new static($array))->map($fn)->toArray();

The call to SortTrait::__construct() has too many arguments starting with $array.

It seems like map() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        array_multisort($mapped, $sort_order, $sort_flags, $array);
        return new $this($array, $this->debug);
    }
}