Spindle\Collection\Traits\SetsTrait

Complexity

Total Complexity

12

Size/Duplication

Total Lines	76
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	0

Test Coverage

Coverage

100%

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	chunk()	0	4	1
A	unique()	0	4	1
A	groupBy()	0	11	2
C	leftJoin()	0	37	8

<?php
namespace Spindle\Collection\Traits;

trait SetsTrait
{
    /**
     * @param int $size
     * @return \Spindle\Collection\Collection
     */
    public function chunk($size)
    {
        return new $this(array_chunk($this->toArray(), $size), $this->debug);

The property debug does not exist. Did you maybe forget to declare it?

It seems like toArray() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }

    /**
     * @return \Spindle\Collection\Collection
     */
    public function unique()
    {
        return new $this(array_unique($this->toArray()), $this->debug);

It seems like toArray() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }

    /**
     * @return \Spindle\Collection\Collection
     */
    public function groupBy($fn)
    {
        $array = $this->toArray();

It seems like toArray() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        $mapped = (new $this($array))->map($fn)->toArray();
        $grouped = [];
        foreach ($mapped as $key => $val) {
            $grouped[$val][$key] = $array[$key];
        }

        return new $this($grouped, $this->debug);
    }

    /**
     * SQL's LEFT JOIN
     * - in order to avoid N+1 problem
     */
    public function leftJoin($map, callable $fetch, callable $combine)
    {
        $array = $this->toArray();

It seems like toArray() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        if ($map) {
            $keys = (new $this($array))->map($map)->toArray();
            $mapped = [];
            foreach ($keys as $key => $val) {
                $mapped[$val][] = $key;
            }
        } else {
            $mapped = [];
            foreach ($array as $key => $val) {
                $mapped[$key] = [$key];
            }
        }
        $keys = array_keys($mapped);
        $fetched = $fetch($keys);
        if (!is_array($fetched)) {
            throw new \UnexpectedValueException(
                'leftJoin($map, $fetch, $combine) $fetch must be function-type [key1, key2, ...] => [key1 => val1, ...]'
            );
        }

        foreach ($fetched as $key => $val) {
            if (!isset($mapped[$key])) {
                throw new \UnexpectedValueException(
                    'leftJoin($map, $fetch, $combine) $fetch returned an array having unexpected key: ' . $key
                );
            }
            foreach ($mapped[$key] as $originKey) {
                $array[$originKey] = $combine($array[$originKey], $val);
            }
        }

        return new $this($array, $this->debug);
    }
}