Spiechu\SymfonyCommonsBundle\Service\ApiVersionFeaturesProvider

Complexity

Total Complexity

16

Size/Duplication

Total Lines	132
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Test Coverage

Coverage

87.5%

Importance

Changes

0

8 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	6	1
A	addFeature()	0	12	1
A	addFeatures()	0	16	3
A	getFeature()	0	4	1
A	getAllKnownFeatures()	0	4	1
A	isFeatureAvailable()	0	4	2
A	getAvailableFeatures()	0	18	4
A	assertVersionCompatibleString()	0	8	3

<?php

declare(strict_types=1);

namespace Spiechu\SymfonyCommonsBundle\Service;

use Spiechu\SymfonyCommonsBundle\ApiFeature\Definition;

class ApiVersionFeaturesProvider
{
    /**
     * @var ApiVersionProvider
     */
    protected $apiVersionProvider;

    /**
     * @var Definition[]
     */
    protected $features;

    /**
     * @param ApiVersionProvider $apiVersionProvider
     */
    public function __construct(ApiVersionProvider $apiVersionProvider)
    {
        $this->apiVersionProvider = $apiVersionProvider;

        $this->features = [];
    }

    /**
     * @param string      $name
     * @param null|string $since
     * @param null|string $until
     *
     * @throws \InvalidArgumentException When feature with given name already exists
     */
    public function addFeature(string $name, ?string $since, ?string $until): void
    {
        $this->assertVersionCompatibleString($since);
        $this->assertVersionCompatibleString($until);

        $this->addFeatures([

array($name => array('since' => $since, 'until' => $until)) is of type array<string,array<string,null|string,{"since":"null|string","until":"null|string"}>>, but the function expects a object<Spiechu\SymfonyCommonsBundle\Service\iterable>.

            $name => [
                'since' => $since,
                'until' => $until,
            ],
        ]);
    }

    /**
     * @param iterable $features [string featureName => array featureRange ['since' => numeric|nll, 'until' => numeric|null] ]
     *
     * @throws \InvalidArgumentException When feature with given name already exists
     */
    public function addFeatures(iterable $features): void
    {
        foreach ($features as $name => $options) {
            if (isset($this->features[$name])) {
                throw new \InvalidArgumentException(sprintf('Feature with given name "%s" already exists', $name));
            }

            $since = $options['since'] ?? null;
            $this->assertVersionCompatibleString($since);

            $until = $options['until'] ?? null;
            $this->assertVersionCompatibleString($until);

            $this->features[$name] = new Definition($name, $since, $until);
        }
    }

    /**
     * @param string $name
     *
     * @return null|Definition
     */
    public function getFeature(string $name): ?Definition
    {
        return $this->getAllKnownFeatures()[$name] ?? null;
    }

    /**
     * @return Definition[]
     */
    public function getAllKnownFeatures(): array
    {
        return $this->features;
    }

    /**
     * @param Definition $definition
     *
     * @throws \RuntimeException When API version is not set
     *
     * @return bool
     */
    public function isFeatureAvailable(Definition $definition): bool
    {
        return isset($this->getAvailableFeatures()[$definition->getName()]) ? true : false;

Consider using $definition->name. There is an issue with getName() and APC-enabled PHP versions.

    }

    /**
     * @throws \RuntimeException When API version is not set
     *
     * @return Definition[]
     */
    public function getAvailableFeatures(): array
    {
        $currentVersion = $this->apiVersionProvider->getApiVersion();

        if ($currentVersion === null) {
            throw new \RuntimeException('API version is not set');
        }

        $matchingFeatures = [];

        foreach ($this->features as $feature) {
            if ($feature->isAvailableForVersion($currentVersion)) {
                $matchingFeatures[$feature->getName()] = $feature;

Consider using $feature->name. There is an issue with getName() and APC-enabled PHP versions.

            }
        }

        return $matchingFeatures;
    }

    /**
     * @param null|string $string
     *
     * @throws \InvalidArgumentException When $string is not version compatible
     */
    protected function assertVersionCompatibleString(?string $string): void
    {
        if ($string === null || is_numeric($string)) {
            return;
        }

        throw new \InvalidArgumentException(sprintf('"%s" is not version compatible string', $string));
    }
}