Spiechu\SymfonyCommonsBundle\Service\SchemaValidator\XmlSchemaValidatorFactory

Complexity

Total Complexity

2

Size/Duplication

Total Lines	14
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
A	getValidator()	0	9	2

<?php

declare(strict_types=1);

namespace Spiechu\SymfonyCommonsBundle\Service\SchemaValidator;

class XmlSchemaValidatorFactory extends AbstractSchemaValidatorFactory implements SchemaValidatorFactoryInterface
{
    /**
     * {@inheritdoc}
     */
    public function getValidator(string $id): SchemaValidatorInterface
    {
        $this->assertHasSchema($id);

        if (!$this->registeredSchemas[$id] instanceof XmlSchemaValidator) {
            $this->registeredSchemas[$id] = new XmlSchemaValidator($this->fileLocator->locate($this->registeredSchemas[$id]));

It seems like $this->fileLocator->locate($this->registeredSchemas[$id]) can also be of type array; however, parameter $schemaLocation of Spiechu\SymfonyCommonsBundle\Service\SchemaValidator\XmlSchemaValidator::__construct() does only seem to accept string, maybe add an additional type check?

        }

        return $this->registeredSchemas[$id];
    }
}