SP\Crawler\SafeXPath

Complexity

Total Complexity

3

Size/Duplication

Total Lines	30
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	0

Test Coverage

Coverage

100%

Importance

Changes	1
Bugs	0	Features	1

2 Methods

Rating	Name	Duplication	Size	Complexity
A	onQueryError()	0	4	1
A	query()	0	14	2

<?php

namespace SP\Crawler;

use DOMNode;
use DOMXPath;
use InvalidArgumentException;

/**
 * @author    Ivan Kerin <ikerin@gmail.com>
 * @copyright 2015, Clippings Ltd.
 * @license   http://spdx.org/licenses/BSD-3-Clause
 */
class SafeXPath extends DOMXPath
{
    private $errors;

    public function onQueryError($errno, $errstrs)
    {
        $this->errors []= $errstrs;
    }

    /**
     * @param  string          $xpath
     * @param  DOMNode|null $scope
     * @throws InvalidArgumentException If xpath is not valid
     * @return DOMNodeList|false
     */
    public function query($xpath, DOMNode $scope = null, $registerNodeNS = null)
    {
        set_error_handler([$this, 'onQueryError']);

        $result = parent::query($xpath, $scope, $registerNodeNS);

        restore_error_handler();

        if ($this->errors) {

The expression $this->errors of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            throw new InvalidArgumentException(sprintf('XPath error for %s (%s)', $xpath, current($this->errors)));
        }

        return $result;
    }
}