Issues in AbstractBuilderField.php (master) - Issues in master - spider-mane/saveyour - Measure and Improve Code Quality continuously with Scrutinizer

Issues (43)

Security Analysis no request data

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

Header Injection

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Controller/Abstracts/AbstractBuilderField.php (4 issues)

Labels

Bug 4

Severity

Minor 4

<?php

namespace WebTheory\Saveyour\Controller\Abstracts;

use WebTheory\Saveyour\Contracts\Controller\FormFieldControllerInterface;
use WebTheory\Saveyour\Contracts\Data\FieldDataManagerInterface;
use WebTheory\Saveyour\Contracts\Field\FormFieldInterface;
use WebTheory\Saveyour\Contracts\Formatting\DataFormatterInterface;
use WebTheory\Saveyour\Controller\FormFieldController;
use WebTheory\Saveyour\Validation\Validator;

abstract class AbstractBuilderField
{
    protected string $requestVar;

    protected bool $isPermittedToProcess = false;

    protected array $mustAwait = [];

    public function __construct(string $requestVar)
    {
        $this->requestVar = $requestVar;
    }

    /**
     * Get the value of processingDisabled
     *
     * @return bool
     */
    public function getProcessingDisabled(): bool
    {
        return $this->isPermittedToProcess;
    }

    /**
     * Set the value of processingDisabled
     *
     * @param bool $processingDisabled
     *
     * @return $this
     */
    public function setProcessingDisabled(bool $processingDisabled): AbstractBuilderField
    {
        $this->isPermittedToProcess = $processingDisabled;

        return $this;
    }

    /**
     * Get the value of mustAwait
     *
     * @return array
     */
    public function getMustAwait(): array
    {
        return $this->mustAwait;
    }

    /**
     * Set the value of mustAwait
     *
     * @param array $mustAwait
     *
     * @return $this
     */
    public function setMustAwait(array $mustAwait): AbstractBuilderField
    {
        $this->mustAwait = $mustAwait;

        return $this;
    }

    public function init(): FormFieldControllerInterface
    {
        return new FormFieldController(
            $this->defineRequestVar(),
            $this->defineFormField(),
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
            $this->defineDataManager(),
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
            $this->defineValidator(),
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
            $this->defineDataFormatter(),
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
            $this->definePermissionProcessStatus(),
            $this->defineMustAwait(),
        );
    }

    protected function defineRequestVar(): string
    {
        return $this->requestVar;
    }

    protected function defineFormField(): ?FormFieldInterface
    {
        return null;
    }

    protected function defineDataManager(): ?FieldDataManagerInterface
    {
        return null;
    }

    protected function defineDataFormatter(): ?DataFormatterInterface
    {
        return null;
    }

    protected function defineValidator(): ?Validator
    {
        return null;
    }

    protected function definePermissionProcessStatus(): ?bool
    {
        return $this->isPermittedToProcess;
    }

    protected function defineMustAwait(): ?array
    {
        return $this->mustAwait;
    }
}


1			<?php
2
3			namespace WebTheory\Saveyour\Controller\Abstracts;
4
5			use WebTheory\Saveyour\Contracts\Controller\FormFieldControllerInterface;
6			use WebTheory\Saveyour\Contracts\Data\FieldDataManagerInterface;
7			use WebTheory\Saveyour\Contracts\Field\FormFieldInterface;
8			use WebTheory\Saveyour\Contracts\Formatting\DataFormatterInterface;
9			use WebTheory\Saveyour\Controller\FormFieldController;
10			use WebTheory\Saveyour\Validation\Validator;
11
12			abstract class AbstractBuilderField
13			{
14			protected string $requestVar;
15
16			protected bool $isPermittedToProcess = false;
17
18			protected array $mustAwait = [];
19
20			public function __construct(string $requestVar)
21			{
22			$this->requestVar = $requestVar;
23			}
24
25			/**
26			* Get the value of processingDisabled
27			*
28			* @return bool
29			*/
30			public function getProcessingDisabled(): bool
31			{
32			return $this->isPermittedToProcess;
33			}
34
35			/**
36			* Set the value of processingDisabled
37			*
38			* @param bool $processingDisabled
39			*
40			* @return $this
41			*/
42			public function setProcessingDisabled(bool $processingDisabled): AbstractBuilderField
43			{
44			$this->isPermittedToProcess = $processingDisabled;
45
46			return $this;
47			}
48
49			/**
50			* Get the value of mustAwait
51			*
52			* @return array
53			*/
54			public function getMustAwait(): array
55			{
56			return $this->mustAwait;
57			}
58
59			/**
60			* Set the value of mustAwait
61			*
62			* @param array $mustAwait
63			*
64			* @return $this
65			*/
66			public function setMustAwait(array $mustAwait): AbstractBuilderField
67			{
68			$this->mustAwait = $mustAwait;
69
70			return $this;
71			}
72
73			public function init(): FormFieldControllerInterface
74			{
75			return new FormFieldController(
76			$this->defineRequestVar(),
77			$this->defineFormField(),
			0 ignored issues – show Bug introduced 2022-04-14 08:39 UTC by Report Bug Copy Issue Report Show Similar Issues like this Are you sure the usage of `$this->defineFormField()` targeting `WebTheory\Saveyour\Contr...ield::defineFormField()` seems to always return null. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
78			$this->defineDataManager(),
			0 ignored issues – show Bug introduced 2022-04-14 08:39 UTC by Report Bug Copy Issue Report Show Similar Issues like this Are you sure the usage of `$this->defineDataManager()` targeting `WebTheory\Saveyour\Contr...ld::defineDataManager()` seems to always return null. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
79			$this->defineValidator(),
			0 ignored issues – show Bug introduced 2022-05-24 03:51 UTC by Report Bug Copy Issue Report Show Similar Issues like this Are you sure the usage of `$this->defineValidator()` targeting `WebTheory\Saveyour\Contr...ield::defineValidator()` seems to always return null. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
80			$this->defineDataFormatter(),
			0 ignored issues – show Bug introduced 2022-04-14 08:39 UTC by Report Bug Copy Issue Report Show Similar Issues like this Are you sure the usage of `$this->defineDataFormatter()` targeting `WebTheory\Saveyour\Contr...::defineDataFormatter()` seems to always return null. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
81			$this->definePermissionProcessStatus(),
82			$this->defineMustAwait(),
83			);
84			}
85
86			protected function defineRequestVar(): string
87			{
88			return $this->requestVar;
89			}
90
91			protected function defineFormField(): ?FormFieldInterface
92			{
93			return null;
94			}
95
96			protected function defineDataManager(): ?FieldDataManagerInterface
97			{
98			return null;
99			}
100
101			protected function defineDataFormatter(): ?DataFormatterInterface
102			{
103			return null;
104			}
105
106			protected function defineValidator(): ?Validator
107			{
108			return null;
109			}
110
111			protected function definePermissionProcessStatus(): ?bool
112			{
113			return $this->isPermittedToProcess;
114			}
115
116			protected function defineMustAwait(): ?array
117			{
118			return $this->mustAwait;
119			}
120			}
121

spider-mane / saveyour

Issues (43)

Security Analysis no request data

src/Controller/Abstracts/AbstractBuilderField.php (4 issues)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like