Leonidas\Library\Admin\Component\Page\MenuPage

Complexity

Total Complexity

4

Size/Duplication

Total Lines	46
Duplicated Lines	0 %

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	getIconUrl()	0	3	1
A	getTitleInSubmenu()	0	3	1
A	__construct()	0	24	2

<?php

namespace Leonidas\Library\Admin\Component\Page;

use Leonidas\Contracts\Admin\AdminTitleResolverInterface;
use Leonidas\Contracts\Admin\Component\AdminPageLayoutInterface;
use Leonidas\Contracts\Admin\Component\LoadErrorPageInterface;
use Leonidas\Contracts\Admin\Component\MenuPageInterface;
use Leonidas\Library\Admin\Abstracts\CanBeRestrictedTrait;
use Leonidas\Library\Admin\Component\Page\Abstracts\AbstractMenuPage;

class MenuPage extends AbstractMenuPage implements MenuPageInterface
{
    use CanBeRestrictedTrait;

    protected ?string $iconUrl;

    /**
     * @var bool|string
     */
    protected $shownInSubmenu;

    public function __construct(
        string $pageTitle,
        string $menuTitle,
        string $menuSlug,
        int $position,
        AdminPageLayoutInterface $layout,
        LoadErrorPageInterface $loadErrorPage,
        ?string $iconUrl,
        ?string $capability = null,
        $shownInSubmenu = null,
        ?AdminTitleResolverInterface $adminTitleResolver = null
    ) {
        $this->iconUrl = $iconUrl;
        $shownInSubmenu && $this->shownInSubmenu = $shownInSubmenu;

        parent::__construct(
            $pageTitle,
            $menuTitle,
            $menuSlug,
            $position,
            $layout,
            $loadErrorPage,
            $capability,
            $adminTitleResolver
        );
    }

    public function getIconUrl(): ?string
    {
        return $this->iconUrl;
    }

    public function getTitleInSubmenu(): string
    {
        return $this->shownInSubmenu;

The expression return $this->shownInSubmenu could return the type boolean which is incompatible with the type-hinted return string. Consider adding an additional type-check to rule them out.

    }
}