Leonidas\Library\Core\Models\Taxonomy\Factory::build()

Complexity

Conditions	2
Paths	2

Size

Total Lines	21
Code Lines	14

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	6

Importance

Changes

0

<?php
    public function build(string $name, array $args): object
    {
        $labels = $args['labels'] ?? [];
        $objectTypes = $args['object_types'];
        $options = $args['options'] ?? [];
        $rewrite = $args['rewrite'] ?? [];

        unset($args['labels'], $args['rewrite'], $args['object_types'], $args['options']);

        $taxonomy = (new Taxonomy($name, $objectTypes))
            ->setArgs($args)
            ->setLabels($labels)
            ->setRewrite($rewrite)
            ->register()
            ->getRegisteredTaxonomy();

        if (isset($this->optionHandlers)) {
            $this->processOptions($options, $taxonomy);

It seems like $taxonomy can also be of type false; however, parameter $taxonomy of Leonidas\Library\Core\Models\Taxonomy\Factory::processOptions() does only seem to accept WP_Taxonomy, maybe add an additional type check?

        }

        return $taxonomy;

The expression return $taxonomy could return the type false which is incompatible with the type-hinted return object. Consider adding an additional type-check to rule them out.

    }