WebTheory\Html\HtmlMap::constructHtml()

Complexity

Conditions	10
Paths	20

Size

Total Lines	45
Code Lines	22

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	1	Features	0

<?php
    protected function constructHtml($map = null, $recall = false)
    {
        static $markedUp;

        $html = '';

        if (!$recall) {
            $markedUp = [];
        }

        foreach ($map ?? $this->map as $currentElement => $definition) {

            if (in_array($currentElement, $markedUp)) {
                continue;
            }

            // add values already existing as strings to $html as they may already exist as markup
            if (is_object($definition) && method_exists($definition, '__toString') || is_string($definition)) {

Consider adding parentheses for clarity. Current Interpretation: (is_object($definition) && method_exists($definition, '__toString')) || is_string($definition), Probably Intended Meaning: is_object($definition) && (method_exists($definition, '__toString') || is_string($definition))

                $html .= $definition;
                $markedUp[] = $currentElement;
                continue;
            }

            $html .= Html::open($definition['tag'], $definition['attributes'] ?? '');

It seems like $definition['attributes'] ?? '' can also be of type string; however, parameter $attributes of WebTheory\Html\Html::open() does only seem to accept array, maybe add an additional type check?

            $html .= $definition['content'] ?? '';

            // store children in array to be passed as $html_map argument in recursive call
            if (!empty($children = $definition['children'] ?? null)) {
                foreach ($children as $child) {
                    $childMap[$child] = $this->map[$child];
                }

                $html .= $this->constructHtml($childMap, true);

The variable $childMap does not seem to be defined for all execution paths leading up to this point.

            }

            $html .= Html::maybeClose($definition['tag']);
            $markedUp[] = $currentElement;
        }

        // reset static variables if in initial call stack
        if (!$recall) {
            $markedUp = null;
        }

        return $html;
    }