WebTheory\Html\HtmlMap

Complexity

Total Complexity

15

Size/Duplication

Total Lines	82
Duplicated Lines	0 %

Test Coverage

Coverage

0%

Importance

Changes	1
Bugs	1	Features	0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	3	1
A	toJson()	0	3	1
A	__toString()	0	3	1
B	constructHtml()	0	45	10
A	jsonSerialize()	0	3	1
A	toHtml()	0	3	1

<?php

namespace WebTheory\Html;

use JsonSerializable;
use WebTheory\Html\Contracts\HtmlInterface;

/**
 * @deprecated version 0.2.0
 */
class HtmlMap implements HtmlInterface, JsonSerializable
{
    protected array $map;

    public function __construct(array $map)
    {
        $this->map = $map;
    }

    /**
     * Generates an html string from array of element definitions
     *
     * 'tag' => string
     * 'attributes' => array || string
     * 'content' => string
     * 'children' => array
     */
    protected function constructHtml(array $map = null, bool $recall = false): string
    {
        static $markedUp;

        $html = '';

        if (!$recall) {
            $markedUp = [];
        }

        foreach ($map ?? $this->map as $currentElement => $definition) {
            if (in_array($currentElement, $markedUp)) {
                continue;
            }

            // add values already existing as strings to $html as they may already exist as markup
            if (is_object($definition) && method_exists($definition, '__toString') || is_string($definition)) {

Consider adding parentheses for clarity. Current Interpretation: (is_object($definition) && method_exists($definition, '__toString')) || is_string($definition), Probably Intended Meaning: is_object($definition) && (method_exists($definition, '__toString') || is_string($definition))

                $html .= $definition;
                $markedUp[] = $currentElement;

                continue;
            }

            $html .= Html::open($definition['tag'], $definition['attributes'] ?? '');

It seems like $definition['attributes'] ?? '' can also be of type string; however, parameter $attributes of WebTheory\Html\Html::open() does only seem to accept array, maybe add an additional type check?

            $html .= $definition['content'] ?? '';

            // store children in array to be passed as $html_map argument in recursive call
            if (!empty($children = $definition['children'] ?? null)) {
                foreach ($children as $child) {
                    $childMap[$child] = $this->map[$child];
                }

                $html .= $this->constructHtml($childMap, true);

The variable $childMap does not seem to be defined for all execution paths leading up to this point.

            }

            $html .= Html::maybeClose($definition['tag']);
            $markedUp[] = $currentElement;
        }

        // reset static variables if in initial call stack
        if (!$recall) {
            $markedUp = null;
        }

        return $html;
    }

    public function toHtml(): string
    {
        return $this->constructHtml();
    }

    public function toJson(): string
    {
        return json_encode($this, JSON_THROW_ON_ERROR);
    }

    public function jsonSerialize(): array
    {
        return $this->map;
    }

    public function __toString(): string
    {
        return $this->toHtml();
    }
}