NativeSession - Code Metrics - Inspection of "add tests for storage adapters" - spekkionu/golem-auth - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 61de25...23a92c )

by Jonathan

created 2016-10-20 11:43 UTC

NativeSession A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	53
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	0

Test Coverage

Coverage

100%

Importance

Changes

Metric	Value
wmc	6
lcom	1
cbo	0
dl	0
loc	53
ccs	15
cts	15
cp	1
rs	10
c	0
b	0
f	0

5 Methods

Rating	Name	Size	Complexity
A	__construct()	4	1
A	store()	4	1
A	read()	7	2
A	exists()	4	1
A	clear()	4	1

<?php
namespace Golem\Auth\Storage;

class NativeSession implements StorageInterface
{
    /**
     * @var string
     */
    private $namespace;

    /**
     * NativeSession constructor.
     * @param string $namespace
     */
    public function __construct($namespace = 'golem_auth')
    {
        $this->namespace = $namespace;
    }

    /**
     * Stores identity
     * @param int|string $id
     */
    public function store($id)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $_SESSION[$this->namespace] = $id;
    }

    /**
     * Returns identity
     * @return int|string|null
     */
    public function read()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        if (!$this->exists()) {
            return null;
        }
        return $_SESSION[$this->namespace];
    }

    /**
     * @return bool
     */
    public function exists()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        return isset($_SESSION[$this->namespace]);
    }

    /**
     * Clears out identity
     */
    public function clear()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        unset($_SESSION[$this->namespace]);
    }
}


1		<?php
2		namespace Golem\Auth\Storage;
3
4		class NativeSession implements StorageInterface
5		{
6		/**
7		* @var string
8		*/
9		private $namespace;
10
11		/**
12		* NativeSession constructor.
13		* @param string $namespace
14		*/
15	4	public function __construct($namespace = 'golem_auth')
16		{
17	4	$this->namespace = $namespace;
18	4	}
19
20		/**
21		* Stores identity
22		* @param int\|string $id
23		*/
24	3	public function store($id)
		0 ignored issues – show Coding Style introduced 2016-10-20 11:17 UTC by Report Bug Copy Issue Report `store` uses the super-global variable `$_SESSION` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
25		{
26	3	$_SESSION[$this->namespace] = $id;
27	3	}
28
29		/**
30		* Returns identity
31		* @return int\|string\|null
32		*/
33	2	public function read()
		0 ignored issues – show Coding Style introduced 2016-10-20 11:17 UTC by Report Bug Copy Issue Report `read` uses the super-global variable `$_SESSION` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
34		{
35	2	if (!$this->exists()) {
36	1	return null;
37		}
38	1	return $_SESSION[$this->namespace];
39		}
40
41		/**
42		* @return bool
43		*/
44	4	public function exists()
		0 ignored issues – show Coding Style introduced 2016-10-20 11:17 UTC by Report Bug Copy Issue Report `exists` uses the super-global variable `$_SESSION` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
45		{
46	4	return isset($_SESSION[$this->namespace]);
47		}
48
49		/**
50		* Clears out identity
51		*/
52	1	public function clear()
		0 ignored issues – show Coding Style introduced 2016-10-20 11:17 UTC by Report Bug Copy Issue Report `clear` uses the super-global variable `$_SESSION` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
53		{
54	1	unset($_SESSION[$this->namespace]);
55	1	}
56		}
57

spekkionu / golem-auth

Push — master ( 61de25...23a92c )

NativeSession A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

5 Methods

Duplication Side-by-Side

Filter issues like