ConfigureBuy::__invoke() - Code Metrics - speckcommerce/SpeckCatalog - Measure and Improve Code Quality continuously with Scrutinizer

ConfigureBuy::__invoke() A
last analyzed 2016-03-01 16:40 UTC

↳ Parent: ConfigureBuy

Complexity

Conditions	4
Paths	4

Size

Total Lines	11
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	20

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
dl	0
loc	11
ccs	0
cts	11
cp	0
rs	9.2
c	1
b	0
f	1
cc	4
eloc	7
nc	4
nop	2
crap	20

<?php

namespace SpeckCatalog\View\Helper;

use Zend\View\Helper\AbstractHelper;

class ConfigureBuy extends AbstractHelper
{
    public function __invoke($product, $formId)
    {
        if ($product->has('uoms') && count($product->getUoms()) > 1) {
            $this->uomSelection();
        }
        if ($product->getProductTypeId() == 1) {
            $this->uomSelection();
            $this->builders($product->getBuilders(), $formId);
        }
        return;
    }

    public function uomSelection()
    {
        $this->getView()->uomSelection = true;
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
    }

    public function builders($builders, $formId)
    {
        $data = array();
        foreach ($builders as $builder) {
            $data[$builder->getProductId()] = array_values($builder->getSelected());
        }
        $builderJson = json_encode($data);

        $script = <<<js
var builders = {$builderJson};
jQuery('document').ready(function(){
    uomBuilders(jQuery('form#{$formId}'), builders);
});
js;

        $this->getView()->headScript()
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            ->appendFile('/js/configure-buy.js')
            ->appendScript($script);
    }
}


1			<?php
2
3			namespace SpeckCatalog\View\Helper;
4
5			use Zend\View\Helper\AbstractHelper;
6
7			class ConfigureBuy extends AbstractHelper
8			{
9			public function __invoke($product, $formId)
10			{
11			if ($product->has('uoms') && count($product->getUoms()) > 1) {
12			$this->uomSelection();
13			}
14			if ($product->getProductTypeId() == 1) {
15			$this->uomSelection();
16			$this->builders($product->getBuilders(), $formId);
17			}
18			return;
19			}
20
21			public function uomSelection()
22			{
23			$this->getView()->uomSelection = true;
			0 ignored issues – show Bug introduced 2015-11-24 10:42 UTC by Report Bug Copy Issue Report Accessing `uomSelection` on the interface `Zend\View\Renderer\RendererInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
24			}
25
26			public function builders($builders, $formId)
27			{
28			$data = array();
29			foreach ($builders as $builder) {
30			$data[$builder->getProductId()] = array_values($builder->getSelected());
31			}
32			$builderJson = json_encode($data);
33
34			$script = <<<js
35			var builders = {$builderJson};
36			jQuery('document').ready(function(){
37			uomBuilders(jQuery('form#{$formId}'), builders);
38			});
39			js;
40
41			$this->getView()->headScript()
			0 ignored issues – show Bug introduced 2015-11-24 10:42 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Zend\View\Renderer\RendererInterface` as the method `headScript()` does only exist in the following implementations of said interface: `Zend\View\Renderer\PhpRenderer`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
42			->appendFile('/js/configure-buy.js')
43			->appendScript($script);
44			}
45			}
46

speckcommerce / SpeckCatalog

ConfigureBuy::__invoke() A last analyzed 2016-03-01 16:40 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like

ConfigureBuy::__invoke() A
last analyzed 2016-03-01 16:40 UTC