CatalogManagerController::productsAction() - Code Metrics - speckcommerce/SpeckCatalog - Measure and Improve Code Quality continuously with Scrutinizer

CatalogManagerController::productsAction() A
last analyzed 2016-03-01 16:40 UTC

↳ Parent: CatalogManagerController

Complexity

Conditions	3
Paths	4

Size

Total Lines	18
Code Lines	13

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	12

Importance

Changes	7
Bugs	1	Features	4

Metric	Value
c	7
b	1
f	4
dl	0
loc	18
ccs	0
cts	17
cp	0
rs	9.4285
cc	3
eloc	13
nc	4
nop	0
crap	12

<?php

namespace SpeckCatalog\Controller;

use Zend\Mvc\Controller\AbstractActionController;
use Zend\View\Model\ViewModel;
use Zend\Paginator\Paginator;
use Zend\Paginator\Adapter\ArrayAdapter as ArrayAdapter;
use Zend\Stdlib\Hydrator\ClassMethods as Hydrator;

class CatalogManagerController extends AbstractActionController
{
    protected $partialDir = '/speck-catalog/catalog-manager/partial/';

    public function init()
    {
        $this->subLayout('layout/catalog-manager');

    }

    //find categories/products that match search terms
    public function categorySearchChildrenAction()
    {
        $type = $this->params('type');
        $children = $this->getService($type)->getAll();

        $viewVars = array('children' => $children, 'type' => $type);
        return $this->partialView('category-search-children', $viewVars);
    }

    public function newProductAction()
    {
        $this->init();
        $product = $this->getService('product')->getModel();
        return new ViewModel(array('product' => $product));
    }

    public function categoryTreePreviewAction()
    {
        $siteId = $this->params('siteid');
        $categoryService = $this->getService('category');
        $categories = $categoryService->getCategoriesForTreePreview($siteId);

        $viewVars = array('categories' => $categories);
        return $this->partialView('category-tree', $viewVars);
    }

    public function productsAction()
    {
        $service = $this->getService('product');

        $this->init();
        $config = array(
            'p' => $this->params('p') ?: 1,
            'n' => 40,
        );
        $service->usePaginator($config);
        $query = $this->params()->fromQuery('query');
        if ($query) {
            $products = $service->search($query);
        } else {
            $products = $service->getAll();
        }
        return new ViewModel(array('products' => $products, 'query' => $query));
    }

    public function categoriesAction()
    {
        $this->init();
        $sites = $this->getService('sites')->getAll();
        return new ViewModel(array('sites' => $sites));
    }

    public function productAction()
    {
        $this->init();
        $productService = $this->getService('product');
        $product = $productService->getFullProduct($this->params('id'));

        $vars = array('product' => $product);
        return new ViewModel($vars);
    }


    //returns main view variable(product/option/etc)
    protected function persist($class, $form)
    {
        $service = $this->getService($class);

        if (method_exists($service, 'persist')) {
            return $service->persist($form);
        }

        $originalData = $form->getOriginalData();
        $data = $form->getData();

        if (count($originalData) && $service->find($originalData)) {
            $service->update($data, $originalData);
            return $service->find($data, true, true);
        }

        return $service->insert($data);
    }

    public function updateProductAction()
    {
        $formData = $this->params()->fromPost();
        $form = $this->getService('form')->getForm('product', null, $formData);

        if ($form->isValid()) {
            $product = $this->persist('product', $form);
            return $this->getResponse()->setContent($product->getProductId());
        }

        return $this->partialView('product', array('product' => $product));
function someFunction() {
    $x = 5;
    echo $x;
}
    }

    public function updateRecordAction()
    {
        $class = $this->params('class');
        $formData = $this->params()->fromPost();
        $form = $this->getService('form')->getForm($class, null, $formData);

        if ($form->isValid()) {
            $entity = $this->persist($class, $form);
        } else {
            $entity = $this->getService($class)->getEntity($formData);
        }

        $partial = $this->dash($class);
        $viewVars = array(lcfirst($this->camel($class)) => $entity);
        return $this->partialView($partial, $viewVars);
    }

    public function updateFormAction()
    {
        $data   = $this->params()->fromPost();
        $form   = $this->getService('form')->getForm($this->params('class'), null, $data);
        $helper = $this->getViewHelper('speckCatalogForm');

        $html   = $helper->renderFormMessages($form);
        return $this->getResponse()->setContent($html);
    }

    public function getViewHelper($helperName)
    {
        return $this->getServiceLocator()->get('viewhelpermanager')->get($helperName);
    }

    public function findAction()
    {
        $post = $this->params()->fromPost();

        if (!isset($post['query'])) {
            $search = $this->partialDir . 'search/' . $this->dash($post['child_name']);
            $view   = new ViewModel(array(
                'fields'        => $post,
                'searchPartial' => $search
            ));
            return $view->setTemplate($this->partialDir . 'search/index')->setTerminal(true);
        }

        $response = array(
            'html' => '',
        );
        $result = $this->getService($post['parent_name'])->search($post);
        if (count($result) > 0) {
            $partial = $this->getViewHelper('partial');
            $rowPartial = $this->partialDir . 'search/row/' . $this->dash($post['child_name']);
            foreach ($result as $row) {
                $response['html'] .= $partial($rowPartial, array('model' => $row, 'params' => $post));
            }
        } else {
            $response['html'] = 'no result';
        }
        $json_resp = json_encode($response);
        return $this->getResponse()->setContent($json_resp);







        return $view;
function fx() {
    try {
        doSomething();
        return true;
    }
    catch (\Exception $e) {
        return false;
    }

    return false;
}
    }

    public function foundAction()
    {
        $postParams = $this->params()->fromPost();

        $objects = array();

        if ($postParams['child_name'] === 'builder_product') {
            $parentProductId = $postParams['parent']['product_id'];
            $productIds = array_keys($postParams['check']);
            foreach ($productIds as $productId) {
                $objects[] = $this->getService('builder_product')->newBuilderForProduct($productId, $parentProductId);
            }
        }

        $helper   = $this->getViewHelper('speckCatalogRenderChildren');
        $content  = $helper->__invoke($postParams['child_name'], $objects);
        $response = $this->getResponse()->setContent($content);
        return $response;
    }

    public function sortAction()
    {
        $postParams = $this->params()->fromPost();
        $childName  = $this->params('type');
        $parentName = $this->params('parent');
        $parent     = $postParams['parent_key'];

        $order = explode(',', $postParams['order']);
        foreach ($order as $i => $val) {
            if (!trim($val)) {
                unset($order[$i]);
            }
        }
        $parentService = $this->getService($parentName);
        $sortChildren = 'sort' . $this->camel($childName) . 's';
        $result = $parentService->$sortChildren($parent, $order);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

        return $this->getResponse();
    }

    public function removeChildAction()
    {
        $postParams = $this->params()->fromPost();
        $parentName = $postParams['parent_name'];
        $childName  = $postParams['child_name'];
        $parent     = $postParams['parent'];
        $child      = $postParams['child'];

        $parentService = $this->getService($parentName);

        $removeChildMethod = 'remove' . $this->camel($childName);
        $result = $parentService->$removeChildMethod($parent, $child);

        if (true === $result) {
            return $this->getResponse()->setContent('true');
        }
        return $this->getResponse()->setContent('false');
    }

    public function getService($name)
    {
        $serviceName = 'speckcatalog_' . $name . '_service';
        return $this->getServiceLocator()->get($serviceName);
    }

    //return the partial for a new record.
    public function newPartialAction()
    {
        $postParams = $this->params()->fromPost();
        $parentName = $postParams['parent_name'];
        $childName  = $postParams['child_name'];
        $parent     = $postParams['parent'];

        $parent = $this->getService($parentName)->find($parent);
        $child  = $this->getService($childName)->getModel();

        $child->setParent($parent);

        $partial  = $this->dash($childName);
        $viewVars = array(lcfirst($this->camel($childName)) => $child);
        return $this->partialView($partial, $viewVars);
    }

    public function partialView($partial, array $viewVars = null)
    {
        $view = new ViewModel($viewVars);
        $view->setTemplate($this->partialDir . $partial);
        $view->setTerminal(true);

        return $view;
    }

    protected function dash($name)
    {
        $dash = new \Zend\Filter\Word\UnderscoreToDash;
        return $dash->__invoke($name);
    }

    protected function camel($name)
    {
        $camel = new \Zend\Filter\Word\UnderscoreToCamelCase;
        return $camel->__invoke($name);
    }
}


1			<?php
2
3			namespace SpeckCatalog\Controller;
4
5			use Zend\Mvc\Controller\AbstractActionController;
6			use Zend\View\Model\ViewModel;
7			use Zend\Paginator\Paginator;
8			use Zend\Paginator\Adapter\ArrayAdapter as ArrayAdapter;
9			use Zend\Stdlib\Hydrator\ClassMethods as Hydrator;
10
11			class CatalogManagerController extends AbstractActionController
12			{
13			protected $partialDir = '/speck-catalog/catalog-manager/partial/';
14
15			public function init()
16			{
17			$this->subLayout('layout/catalog-manager');
			0 ignored issues – show Bug introduced 2015-11-24 10:42 UTC by Report Bug Copy Issue Report The method `subLayout()` does not exist on `SpeckCatalog\Controller\CatalogManagerController`. Did you maybe mean `layout()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
18			}
19
20			//find categories/products that match search terms
21			public function categorySearchChildrenAction()
22			{
23			$type = $this->params('type');
24			$children = $this->getService($type)->getAll();
25
26			$viewVars = array('children' => $children, 'type' => $type);
27			return $this->partialView('category-search-children', $viewVars);
28			}
29
30			public function newProductAction()
31			{
32			$this->init();
33			$product = $this->getService('product')->getModel();
34			return new ViewModel(array('product' => $product));
35			}
36
37			public function categoryTreePreviewAction()
38			{
39			$siteId = $this->params('siteid');
40			$categoryService = $this->getService('category');
41			$categories = $categoryService->getCategoriesForTreePreview($siteId);
42
43			$viewVars = array('categories' => $categories);
44			return $this->partialView('category-tree', $viewVars);
45			}
46
47			public function productsAction()
48			{
49			$service = $this->getService('product');
50
51			$this->init();
52			$config = array(
53			'p' => $this->params('p') ?: 1,
54			'n' => 40,
55			);
56			$service->usePaginator($config);
57			$query = $this->params()->fromQuery('query');
58			if ($query) {
59			$products = $service->search($query);
60			} else {
61			$products = $service->getAll();
62			}
63			return new ViewModel(array('products' => $products, 'query' => $query));
64			}
65
66			public function categoriesAction()
67			{
68			$this->init();
69			$sites = $this->getService('sites')->getAll();
70			return new ViewModel(array('sites' => $sites));
71			}
72
73			public function productAction()
74			{
75			$this->init();
76			$productService = $this->getService('product');
77			$product = $productService->getFullProduct($this->params('id'));
78
79			$vars = array('product' => $product);
80			return new ViewModel($vars);
81			}
82
83
84			//returns main view variable(product/option/etc)
85			protected function persist($class, $form)
86			{
87			$service = $this->getService($class);
88
89			if (method_exists($service, 'persist')) {
90			return $service->persist($form);
91			}
92
93			$originalData = $form->getOriginalData();
94			$data = $form->getData();
95
96			if (count($originalData) && $service->find($originalData)) {
97			$service->update($data, $originalData);
98			return $service->find($data, true, true);
99			}
100
101			return $service->insert($data);
102			}
103
104			public function updateProductAction()
105			{
106			$formData = $this->params()->fromPost();
107			$form = $this->getService('form')->getForm('product', null, $formData);
108
109			if ($form->isValid()) {
110			$product = $this->persist('product', $form);
111			return $this->getResponse()->setContent($product->getProductId());
112			}
113
114			return $this->partialView('product', array('product' => $product));
			0 ignored issues – show Bug introduced 2015-11-24 10:42 UTC by Report Bug Copy Issue Report The variable `$product` seems only to be defined at a later point. Did you maybe move this code here without moving the variable definition? This error can happen if you refactor code and forget to move the variable initialization. Let’s take a look at a simple example: function someFunction() { $x = 5; echo $x; } The above code is perfectly fine. Now imagine that we re-order the statements: function someFunction() { echo $x; $x = 5; } In that case, `$x` would be read before it is initialized. This was a very basic example, however the principle is the same for the found issue. Loading history...
115			}
116
117			public function updateRecordAction()
118			{
119			$class = $this->params('class');
120			$formData = $this->params()->fromPost();
121			$form = $this->getService('form')->getForm($class, null, $formData);
122
123			if ($form->isValid()) {
124			$entity = $this->persist($class, $form);
125			} else {
126			$entity = $this->getService($class)->getEntity($formData);
127			}
128
129			$partial = $this->dash($class);
130			$viewVars = array(lcfirst($this->camel($class)) => $entity);
131			return $this->partialView($partial, $viewVars);
132			}
133
134			public function updateFormAction()
135			{
136			$data = $this->params()->fromPost();
137			$form = $this->getService('form')->getForm($this->params('class'), null, $data);
138			$helper = $this->getViewHelper('speckCatalogForm');
139
140			$html = $helper->renderFormMessages($form);
141			return $this->getResponse()->setContent($html);
142			}
143
144			public function getViewHelper($helperName)
145			{
146			return $this->getServiceLocator()->get('viewhelpermanager')->get($helperName);
147			}
148
149			public function findAction()
150			{
151			$post = $this->params()->fromPost();
152
153			if (!isset($post['query'])) {
154			$search = $this->partialDir . 'search/' . $this->dash($post['child_name']);
155			$view = new ViewModel(array(
156			'fields' => $post,
157			'searchPartial' => $search
158			));
159			return $view->setTemplate($this->partialDir . 'search/index')->setTerminal(true);
160			}
161
162			$response = array(
163			'html' => '',
164			);
165			$result = $this->getService($post['parent_name'])->search($post);
166			if (count($result) > 0) {
167			$partial = $this->getViewHelper('partial');
168			$rowPartial = $this->partialDir . 'search/row/' . $this->dash($post['child_name']);
169			foreach ($result as $row) {
170			$response['html'] .= $partial($rowPartial, array('model' => $row, 'params' => $post));
171			}
172			} else {
173			$response['html'] = 'no result';
174			}
175			$json_resp = json_encode($response);
176			return $this->getResponse()->setContent($json_resp);
177
178
179
180
181
182
183
184			return $view;
			0 ignored issues – show Unused Code introduced 2015-11-24 10:42 UTC by Report Bug Copy Issue Report `return $view;` does not seem to be reachable. This check looks for unreachable code. It uses sophisticated control flow analysis techniques to find statements which will never be executed. Unreachable code is most often the result of `return`, `die` or `exit` statements that have been added for debug purposes. function fx() { try { doSomething(); return true; } catch (\Exception $e) { return false; } return false; } In the above example, the last `return false` will never be executed, because a return statement has already been met in every possible execution path. Loading history...
185			}
186
187			public function foundAction()
188			{
189			$postParams = $this->params()->fromPost();
190
191			$objects = array();
192
193			if ($postParams['child_name'] === 'builder_product') {
194			$parentProductId = $postParams['parent']['product_id'];
195			$productIds = array_keys($postParams['check']);
196			foreach ($productIds as $productId) {
197			$objects[] = $this->getService('builder_product')->newBuilderForProduct($productId, $parentProductId);
198			}
199			}
200
201			$helper = $this->getViewHelper('speckCatalogRenderChildren');
202			$content = $helper->__invoke($postParams['child_name'], $objects);
203			$response = $this->getResponse()->setContent($content);
204			return $response;
205			}
206
207			public function sortAction()
208			{
209			$postParams = $this->params()->fromPost();
210			$childName = $this->params('type');
211			$parentName = $this->params('parent');
212			$parent = $postParams['parent_key'];
213
214			$order = explode(',', $postParams['order']);
215			foreach ($order as $i => $val) {
216			if (!trim($val)) {
217			unset($order[$i]);
218			}
219			}
220			$parentService = $this->getService($parentName);
221			$sortChildren = 'sort' . $this->camel($childName) . 's';
222			$result = $parentService->$sortChildren($parent, $order);
			0 ignored issues – show Unused Code introduced 2015-11-24 10:42 UTC by Report Bug Copy Issue Report `$result` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
223
224			return $this->getResponse();
225			}
226
227			public function removeChildAction()
228			{
229			$postParams = $this->params()->fromPost();
230			$parentName = $postParams['parent_name'];
231			$childName = $postParams['child_name'];
232			$parent = $postParams['parent'];
233			$child = $postParams['child'];
234
235			$parentService = $this->getService($parentName);
236
237			$removeChildMethod = 'remove' . $this->camel($childName);
238			$result = $parentService->$removeChildMethod($parent, $child);
239
240			if (true === $result) {
241			return $this->getResponse()->setContent('true');
242			}
243			return $this->getResponse()->setContent('false');
244			}
245
246			public function getService($name)
247			{
248			$serviceName = 'speckcatalog_' . $name . '_service';
249			return $this->getServiceLocator()->get($serviceName);
250			}
251
252			//return the partial for a new record.
253			public function newPartialAction()
254			{
255			$postParams = $this->params()->fromPost();
256			$parentName = $postParams['parent_name'];
257			$childName = $postParams['child_name'];
258			$parent = $postParams['parent'];
259
260			$parent = $this->getService($parentName)->find($parent);
261			$child = $this->getService($childName)->getModel();
262
263			$child->setParent($parent);
264
265			$partial = $this->dash($childName);
266			$viewVars = array(lcfirst($this->camel($childName)) => $child);
267			return $this->partialView($partial, $viewVars);
268			}
269
270			public function partialView($partial, array $viewVars = null)
271			{
272			$view = new ViewModel($viewVars);
273			$view->setTemplate($this->partialDir . $partial);
274			$view->setTerminal(true);
275
276			return $view;
277			}
278
279			protected function dash($name)
280			{
281			$dash = new \Zend\Filter\Word\UnderscoreToDash;
282			return $dash->__invoke($name);
283			}
284
285			protected function camel($name)
286			{
287			$camel = new \Zend\Filter\Word\UnderscoreToCamelCase;
288			return $camel->__invoke($name);
289			}
290			}
291

speckcommerce / SpeckCatalog

CatalogManagerController::productsAction() A last analyzed 2016-03-01 16:40 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like

CatalogManagerController::productsAction() A
last analyzed 2016-03-01 16:40 UTC