Issues in Curl.php (master) - Issues in master - spb-lan/ebs-sdk - Measure and Improve Code Quality continuously with Scrutinizer

Issues (24)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/helper/Curl.php (1 issue)

Labels

Unused Code 1

Severity

Minor 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * Class Curl
 *
 * @author       Denis Shestakov <[email protected]>
 * @copyright    Copyright (c) 2017, Lan Publishing
 * @license      MIT
 */

namespace Lan\Ebs\Sdk\Helper;

use Exception;

/**
 * Хелпер для работы с curl
 *
 * @package      Lan\Ebs
 * @subpackage   Sdk
 * @category     Helper
 */
class Curl
{
    /**
     * Получение ответа от сервера API
     *
     * @param string $host Домен сервера API
     * @param string $url Урл ресурса API
     * @param string $method Метод http-запроса (GET|POST|PUT|DELETE)
     * @param string $token Токен клиента
     * @param array $params Параметры, переданные серверу API
     *
     * @return array|mixed
     *
     * @throws Exception
     */
    public static function getResponse($host, $url, $method, $token, array $params)
    {
        $curl = curl_init();

        switch ($method) {
            case 'GET':
                if (!empty($params)) {
                    $url = sprintf("%s?%s", $url, http_build_query($params, '', '&'));
                };

                break;
            case 'POST':
            case 'PUT':
            case 'DELETE':
                if (!empty($params)) {
                    curl_setopt($curl, CURLOPT_POSTFIELDS, http_build_query($params, '', '&'));
                }
                break;
            default:
                throw new Exception('Method ' . $method . ' unknown');
        }

//        $url = html_entity_decode($url);

        $headers = array(
            'X-Auth-Token: ' . $token,
            'Content-Type: application/x-www-form-urlencoded; charset=utf-8',
            'Accept: application/json'
        );

        curl_setopt($curl, CURLOPT_CUSTOMREQUEST, $method);
        curl_setopt($curl, CURLOPT_URL, $host . $url);
        curl_setopt($curl, CURLOPT_RETURNTRANSFER, true);
        curl_setopt($curl, CURLOPT_HTTPHEADER, $headers);
        curl_setopt($curl, CURLOPT_SSL_VERIFYPEER, false);

//        $fp = fopen(__DIR__ . '/errorlog.txt', 'w');
//        curl_setopt($curl, CURLOPT_VERBOSE, 1);
//        curl_setopt($curl, CURLOPT_STDERR, $fp);

        //Debuger::dump($method . ' ' . $host . $url . ' ' . ($method === 'POST' || $method === 'PUT' || $method === 'DELETE' ? Curl::arrayPrettyPrint($params) : ''));

        $curlResult = curl_exec($curl);

        //Debuger::dump('Response code: ' . (curl_errno($curl) ? '!!! Error !!!' : curl_getinfo($curl)['http_code']) . "\n");

        if (curl_errno($curl)) {
            return Curl::getError('Curl error ' . curl_errno($curl) . ': ' . curl_error($curl), 500);
        }

        $response = json_decode($curlResult, true);

        if (json_last_error()) {
            return Curl::getError('JSON error ' . json_last_error() . ': ' . json_last_error_msg() . "\n" . $curlResult, curl_getinfo($curl)['http_code']);
        }

        if (empty($response)) {
            return Curl::getError('Response is empty', curl_getinfo($curl)['http_code']);
        }

        return $response;
    }

    /**
     * Получение массива как строку
     *
     * @param array $array Данные массива
     *
     * @return mixed
     */
    private static function arrayPrettyPrint(array $array)

    {
        return str_replace('Array (', '(', preg_replace('/\s{2,}/', ' ', preg_replace('/[\x00-\x1F\x7F ]/', ' ', print_r($array, true))));
    }

    /**
     *  Дефолтный ответ при ошибке
     *
     * @param string $message Сообщение об ошибке
     * @param int $code Статус код ошибки
     *
     * @return array
     */
    private static function getError($message, $code)
    {
        return array(
            'type' => 'none',
            'data' => null,
            'count' => 0,
            'status' => $code,
            'message' => $message
        );
    }
}

1		<?php
2		/**
3		* Class Curl
4		*
5		* @author Denis Shestakov <[email protected]>
6		* @copyright Copyright (c) 2017, Lan Publishing
7		* @license MIT
8		*/
9
10		namespace Lan\Ebs\Sdk\Helper;
11
12		use Exception;
13
14		/**
15		* Хелпер для работы с curl
16		*
17		* @package Lan\Ebs
18		* @subpackage Sdk
19		* @category Helper
20		*/
21		class Curl
22		{
23		/**
24		* Получение ответа от сервера API
25		*
26		* @param string $host Домен сервера API
27		* @param string $url Урл ресурса API
28		* @param string $method Метод http-запроса (GET\|POST\|PUT\|DELETE)
29		* @param string $token Токен клиента
30		* @param array $params Параметры, переданные серверу API
31		*
32		* @return array\|mixed
33		*
34		* @throws Exception
35		*/
36	10	public static function getResponse($host, $url, $method, $token, array $params)
37		{
38	10	$curl = curl_init();
39
40		switch ($method) {
41	10	case 'GET':
42	9	if (!empty($params)) {
43	7	$url = sprintf("%s?%s", $url, http_build_query($params, '', '&'));
44		};
45
46	9	break;
47	1	case 'POST':
48		case 'PUT':
49		case 'DELETE':
50	1	if (!empty($params)) {
51	1	curl_setopt($curl, CURLOPT_POSTFIELDS, http_build_query($params, '', '&'));
52		}
53	1	break;
54		default:
55		throw new Exception('Method ' . $method . ' unknown');
56		}
57
58		// $url = html_entity_decode($url);
59
60		$headers = array(
61	10	'X-Auth-Token: ' . $token,
62	10	'Content-Type: application/x-www-form-urlencoded; charset=utf-8',
63	10	'Accept: application/json'
64		);
65
66	10	curl_setopt($curl, CURLOPT_CUSTOMREQUEST, $method);
67	10	curl_setopt($curl, CURLOPT_URL, $host . $url);
68	10	curl_setopt($curl, CURLOPT_RETURNTRANSFER, true);
69	10	curl_setopt($curl, CURLOPT_HTTPHEADER, $headers);
70	10	curl_setopt($curl, CURLOPT_SSL_VERIFYPEER, false);
71
72		// $fp = fopen(__DIR__ . '/errorlog.txt', 'w');
73		// curl_setopt($curl, CURLOPT_VERBOSE, 1);
74		// curl_setopt($curl, CURLOPT_STDERR, $fp);
75
76		//Debuger::dump($method . ' ' . $host . $url . ' ' . ($method === 'POST' \|\| $method === 'PUT' \|\| $method === 'DELETE' ? Curl::arrayPrettyPrint($params) : ''));
77
78	10	$curlResult = curl_exec($curl);
79
80		//Debuger::dump('Response code: ' . (curl_errno($curl) ? '!!! Error !!!' : curl_getinfo($curl)['http_code']) . "\n");
81
82	10	if (curl_errno($curl)) {
83		return Curl::getError('Curl error ' . curl_errno($curl) . ': ' . curl_error($curl), 500);
84		}
85
86	10	$response = json_decode($curlResult, true);
87
88	10	if (json_last_error()) {
89		return Curl::getError('JSON error ' . json_last_error() . ': ' . json_last_error_msg() . "\n" . $curlResult, curl_getinfo($curl)['http_code']);
90		}
91
92	10	if (empty($response)) {
93		return Curl::getError('Response is empty', curl_getinfo($curl)['http_code']);
94		}
95
96	10	return $response;
97		}
98
99		/**
100		* Получение массива как строку
101		*
102		* @param array $array Данные массива
103		*
104		* @return mixed
105		*/
106		private static function arrayPrettyPrint(array $array)
		0 ignored issues – show Unused Code introduced 2020-09-18 08:12 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method is not used, and could be removed. Loading history...
107		{
108		return str_replace('Array (', '(', preg_replace('/\s{2,}/', ' ', preg_replace('/[\x00-\x1F\x7F ]/', ' ', print_r($array, true))));
109		}
110
111		/**
112		* Дефолтный ответ при ошибке
113		*
114		* @param string $message Сообщение об ошибке
115		* @param int $code Статус код ошибки
116		*
117		* @return array
118		*/
119		private static function getError($message, $code)
120		{
121		return array(
122		'type' => 'none',
123		'data' => null,
124		'count' => 0,
125		'status' => $code,
126		'message' => $message
127		);
128		}
129		}

spb-lan / ebs-sdk

Issues (24)

Security Analysis no request data

src/helper/Curl.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like