Security - Code Metrics - Inspection of "Update README.md" - spb-lan/ebs-sdk - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( e8241e...60d0c3 )

unknown

created 2017-10-23 12:20 UTC

Security A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	132
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Test Coverage

Coverage

80.77%

Importance

Changes

Metric	Value
wmc	13
lcom	1
cbo	1
dl	0
loc	132
ccs	21
cts	26
cp	0.8077
rs	10
c	0
b	0
f	0

6 Methods

Rating	Name	Size	Complexity
A	__construct()	8	2
A	getApiHost()	4	3
A	getEbsHost()	4	3
A	getDemoUrl()	4	1
A	getUrl()	19	3
A	getAutologinUrl()	13	1

<?php

namespace Lan\Ebs\Sdk;

use Exception;

/**
 * Класс для получения публичных ресурсов по закрытому токену
 *
 * @package Lan\Ebs\Sdk
 */
final class Security implements Common
{
    /**
     * Токен для тестового доступа
     */
    const TEST_TOKEN = '7c0c2193d27108a509abd8ea84a8750c82b3a520';

    /**
     * Домен продакшен сервера API
     */
    const PROD_API_HOST = 'https://openapi.e.lanbook.com';

    /**
     * Домен тестового сервера API
     */
    const TEST_API_HOST = 'http://openapi.landev.ru';

    /**
     * Домен дев сервера API
     */
    const DEV_API_HOST = 'http://eop.local';

    /**
     * Домен продакшен сервера ЭБС
     */
    const PROD_EBS_HOST = 'https://e.lanbook.com';

    /**
     * Домен тестового сервера ЭБС
     */
    const TEST_EBS_HOST = 'http://ebs.landev.ru';

    /**
     * Домен дев сервера ЭБС
     */
    const DEV_EBS_HOST = 'http://ebs.local';

    /**
     * Инстанс клиента API
     *
     * @var Client
     */
    private $client;

    /**
     * Конструктор
     *
     * @param Client $client Истанс клиента
     * @throws Exception
     */
    public function __construct(Client $client)
    {
        if (!$client) {
            throw new Exception('Client not defined');
        }

        $this->client = $client;
    }

    public static function getApiHost()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        return isset($_SERVER['USER']) && $_SERVER['USER'] == 'dp' ? Security::DEV_API_HOST : Security::PROD_API_HOST;
    }

    public static function getEbsHost()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        return isset($_SERVER['USER']) && $_SERVER['USER'] == 'dp' ? Security::DEV_EBS_HOST : Security::PROD_EBS_HOST;
    }

    /**
     * @param $type
     * @param $id
     * @return mixed
     * @throws Exception
     */
    public function getDemoUrl($type, $id)
    {
        return $this->client->getResponse($this->getUrl(__FUNCTION__), ['type' => $type, 'id' => $id])['data'];
    }

    /**
     * Получение данных для запроса через API
     *
     * @param string $method Http-метод запроса
     * @param array $params Параметры для формирования урла
     *
     * @return array
     *
     * @throws Exception
     */
    public function getUrl($method, array $params = [])
    {
        switch ($method) {
            case 'getDemoUrl':
                return [
                    'url' => '/1.0/security/demoUrl',
                    'method' => 'GET',
                    'code' => 200
                ];
            case 'getAutologinUrl':
                return [
                    'url' => '/1.0/security/autologinUrl',
                    'method' => 'GET',
                    'code' => 200
                ];
            default:
                throw new Exception('Route for ' . $method . ' not found');
        }
    }

    /**
     * @param $uid
     * @param null $fio
     * @param null $email
     * @param null $redirect
     * @return mixed
     * @throws Exception
     */
    public function getAutologinUrl($uid, $fio = null, $email = null, $redirect = null)
    {
        return $this->client->getResponse(
            $this->getUrl(__FUNCTION__),
            [
                'uid' => $uid,
                'time' => date('YmdHi'),
                'fio' => $fio,
                'email' => $email,
                'redirect' => $redirect
            ]
        )['data'];
    }
}

1		<?php
2
3		namespace Lan\Ebs\Sdk;
4
5		use Exception;
6
7		/**
8		* Класс для получения публичных ресурсов по закрытому токену
9		*
10		* @package Lan\Ebs\Sdk
11		*/
12		final class Security implements Common
13		{
14		/**
15		* Токен для тестового доступа
16		*/
17		const TEST_TOKEN = '7c0c2193d27108a509abd8ea84a8750c82b3a520';
18
19		/**
20		* Домен продакшен сервера API
21		*/
22		const PROD_API_HOST = 'https://openapi.e.lanbook.com';
23
24		/**
25		* Домен тестового сервера API
26		*/
27		const TEST_API_HOST = 'http://openapi.landev.ru';
28
29		/**
30		* Домен дев сервера API
31		*/
32		const DEV_API_HOST = 'http://eop.local';
33
34		/**
35		* Домен продакшен сервера ЭБС
36		*/
37		const PROD_EBS_HOST = 'https://e.lanbook.com';
38
39		/**
40		* Домен тестового сервера ЭБС
41		*/
42		const TEST_EBS_HOST = 'http://ebs.landev.ru';
43
44		/**
45		* Домен дев сервера ЭБС
46		*/
47		const DEV_EBS_HOST = 'http://ebs.local';
48
49		/**
50		* Инстанс клиента API
51		*
52		* @var Client
53		*/
54		private $client;
55
56		/**
57		* Конструктор
58		*
59		* @param Client $client Истанс клиента
60		* @throws Exception
61		*/
62	2	public function __construct(Client $client)
63		{
64	2	if (!$client) {
65		throw new Exception('Client not defined');
66		}
67
68	2	$this->client = $client;
69	2	}
70
71	6	public static function getApiHost()
		0 ignored issues – show Coding Style introduced 2017-09-12 14:46 UTC by Report Bug Copy Issue Report `getApiHost` uses the super-global variable `$_SERVER` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
72		{
73	6	return isset($_SERVER['USER']) && $_SERVER['USER'] == 'dp' ? Security::DEV_API_HOST : Security::PROD_API_HOST;
74		}
75
76		public static function getEbsHost()
		0 ignored issues – show Coding Style introduced 2017-09-12 14:46 UTC by Report Bug Copy Issue Report `getEbsHost` uses the super-global variable `$_SERVER` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
77		{
78		return isset($_SERVER['USER']) && $_SERVER['USER'] == 'dp' ? Security::DEV_EBS_HOST : Security::PROD_EBS_HOST;
79		}
80
81		/**
82		* @param $type
83		* @param $id
84		* @return mixed
85		* @throws Exception
86		*/
87	1	public function getDemoUrl($type, $id)
88		{
89	1	return $this->client->getResponse($this->getUrl(__FUNCTION__), ['type' => $type, 'id' => $id])['data'];
90		}
91
92		/**
93		* Получение данных для запроса через API
94		*
95		* @param string $method Http-метод запроса
96		* @param array $params Параметры для формирования урла
97		*
98		* @return array
99		*
100		* @throws Exception
101		*/
102	2	public function getUrl($method, array $params = [])
103		{
104		switch ($method) {
105	2	case 'getDemoUrl':
106		return [
107	1	'url' => '/1.0/security/demoUrl',
108		'method' => 'GET',
109		'code' => 200
110		];
111	1	case 'getAutologinUrl':
112		return [
113	1	'url' => '/1.0/security/autologinUrl',
114		'method' => 'GET',
115		'code' => 200
116		];
117		default:
118		throw new Exception('Route for ' . $method . ' not found');
119		}
120		}
121
122		/**
123		* @param $uid
124		* @param null $fio
125		* @param null $email
126		* @param null $redirect
127		* @return mixed
128		* @throws Exception
129		*/
130	1	public function getAutologinUrl($uid, $fio = null, $email = null, $redirect = null)
131		{
132	1	return $this->client->getResponse(
133	1	$this->getUrl(__FUNCTION__),
134		[
135	1	'uid' => $uid,
136	1	'time' => date('YmdHi'),
137	1	'fio' => $fio,
138	1	'email' => $email,
139	1	'redirect' => $redirect
140		]
141		)['data'];
142		}
143		}

spb-lan / ebs-sdk

Push — master ( e8241e...60d0c3 )

Security A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

6 Methods

Duplication Side-by-Side

Filter issues like