Security - Code Metrics - Inspection of "more comments" - spb-lan/ebs-sdk - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( c14aad...5ba59a )

by Denis

created 2017-10-13 13:35 UTC

Security A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	131
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Test Coverage

Coverage

81.25%

Importance

Changes

Metric	Value
wmc	13
lcom	1
cbo	1
dl	0
loc	131
ccs	26
cts	32
cp	0.8125
rs	10
c	0
b	0
f	0

6 Methods

Rating	Name	Size	Complexity
A	__construct()	8	2
A	getUrl()	19	3
A	getDemoUrl()	4	1
A	getAutologinUrl()	12	1
A	getApiHost()	4	3
A	getEbsHost()	4	3

<?php
/**
 * Created by PhpStorm.
 * User: dp
 * Date: 16.08.17
 * Time: 13:09
 */

namespace Lan\Ebs\Sdk;

use Exception;

/**
 * Класс для получения публичных ресурсов по закрытому токену
 *
 * @package Lan\Ebs\Sdk
 */
final class Security implements Common
{
    /**
     * Токен для тестового доступа
     */
    const TEST_TOKEN = '7c0c2193d27108a509abd8ea84a8750c82b3a520';

    /**
     * Домен продакшен сервера API
     */
    const PROD_API_HOST = 'https://openapi.e.lanbook.com';

    /**
     * Домен тестового сервера API
     */
    const TEST_API_HOST = 'http://openapi.landev.ru';

    /**
     * Домен дев сервера API
     */
    const DEV_API_HOST = 'http://eop.local';

    /**
     * Домен продакшен сервера ЭБС
     */
    const PROD_EBS_HOST = 'https://e.lanbook.com';

    /**
     * Домен тестового сервера ЭБС
     */
    const TEST_EBS_HOST = 'http://ebs.landev.ru';

    /**
     * Домен дев сервера ЭБС
     */
    const DEV_EBS_HOST = 'http://ebs.local';

    /**
     * Инстанс клиента API
     *
     * @var Client
     */
    private $client;

    /**
     * Конструктор
     *
     * @param Client $client Истанс клиента
     * @throws Exception
     */
    public function __construct(Client $client)
    {
        if (!$client) {
            throw new Exception('Client not defined');
        }

        $this->client = $client;
    }

    /**
     * Получение данных для запроса через API
     *
     * @param string $method Http-метод запроса
     * @param array $params Параметры для формирования урла
     *
     * @return array
     *
     * @throws Exception
     */
    public function getUrl($method, array $params = [])
    {
        switch ($method) {
            case 'getDemoUrl':
                return [
                    'url' => '/1.0/security/demoUrl',
                    'method' => 'GET',
                    'code' => 200
                ];
            case 'getAutologinUrl':
                return [
                    'url' => '/1.0/security/autologinUrl',
                    'method' => 'GET',
                    'code' => 200
                ];
            default:
                throw new Exception('Route for ' . $method . ' not found');
        }
    }

    /**
     * @param $type
     * @param $id
     * @return mixed
     * @throws Exception
     */
    public function getDemoUrl($type, $id)
    {
        return $this->client->getResponse($this->getUrl(__FUNCTION__), ['type' => $type, 'id' => $id])['data'];
    }

    /**
     * @param $uid
     * @param null $fio
     * @param null $email
     * @param null $redirect
     * @return mixed
     * @throws Exception
     */
    public function getAutologinUrl($uid, $fio = null, $email = null, $redirect = null) {
        return $this->client->getResponse(
            $this->getUrl(__FUNCTION__),
            [
                'uid' => $uid,
                'time' => date('YmdHi'),
                'fio' => $fio,
                'email' => $email,
                'redirect' => $redirect
            ]
        )['data'];
    }

    public static function getApiHost()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        return isset($_SERVER['USER']) && $_SERVER['USER'] == 'dp' ? Security::DEV_API_HOST : Security::PROD_API_HOST;
    }

    public static function getEbsHost()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        return isset($_SERVER['USER']) && $_SERVER['USER'] == 'dp' ? Security::DEV_EBS_HOST : Security::PROD_EBS_HOST;
    }
}

1		<?php
2		/**
3		* Created by PhpStorm.
4		* User: dp
5		* Date: 16.08.17
6		* Time: 13:09
7		*/
8
9		namespace Lan\Ebs\Sdk;
10
11		use Exception;
12
13		/**
14		* Класс для получения публичных ресурсов по закрытому токену
15		*
16		* @package Lan\Ebs\Sdk
17		*/
18		final class Security implements Common
19		{
20		/**
21		* Токен для тестового доступа
22		*/
23		const TEST_TOKEN = '7c0c2193d27108a509abd8ea84a8750c82b3a520';
24
25		/**
26		* Домен продакшен сервера API
27		*/
28		const PROD_API_HOST = 'https://openapi.e.lanbook.com';
29
30		/**
31		* Домен тестового сервера API
32		*/
33		const TEST_API_HOST = 'http://openapi.landev.ru';
34
35		/**
36		* Домен дев сервера API
37		*/
38		const DEV_API_HOST = 'http://eop.local';
39
40		/**
41		* Домен продакшен сервера ЭБС
42		*/
43		const PROD_EBS_HOST = 'https://e.lanbook.com';
44
45		/**
46		* Домен тестового сервера ЭБС
47		*/
48		const TEST_EBS_HOST = 'http://ebs.landev.ru';
49
50		/**
51		* Домен дев сервера ЭБС
52		*/
53		const DEV_EBS_HOST = 'http://ebs.local';
54
55		/**
56		* Инстанс клиента API
57		*
58		* @var Client
59		*/
60		private $client;
61
62		/**
63		* Конструктор
64		*
65		* @param Client $client Истанс клиента
66		* @throws Exception
67		*/
68	2	public function __construct(Client $client)
69		{
70	2	if (!$client) {
71		throw new Exception('Client not defined');
72		}
73
74	2	$this->client = $client;
75	2	}
76
77		/**
78		* Получение данных для запроса через API
79		*
80		* @param string $method Http-метод запроса
81		* @param array $params Параметры для формирования урла
82		*
83		* @return array
84		*
85		* @throws Exception
86		*/
87	2	public function getUrl($method, array $params = [])
88		{
89		switch ($method) {
90	2	case 'getDemoUrl':
91		return [
92	1	'url' => '/1.0/security/demoUrl',
93	1	'method' => 'GET',
94		'code' => 200
95	1	];
96	1	case 'getAutologinUrl':
97		return [
98	1	'url' => '/1.0/security/autologinUrl',
99	1	'method' => 'GET',
100		'code' => 200
101	1	];
102		default:
103		throw new Exception('Route for ' . $method . ' not found');
104		}
105		}
106
107		/**
108		* @param $type
109		* @param $id
110		* @return mixed
111		* @throws Exception
112		*/
113	1	public function getDemoUrl($type, $id)
114		{
115	1	return $this->client->getResponse($this->getUrl(__FUNCTION__), ['type' => $type, 'id' => $id])['data'];
116		}
117
118		/**
119		* @param $uid
120		* @param null $fio
121		* @param null $email
122		* @param null $redirect
123		* @return mixed
124		* @throws Exception
125		*/
126	1	public function getAutologinUrl($uid, $fio = null, $email = null, $redirect = null) {
127	1	return $this->client->getResponse(
128	1	$this->getUrl(__FUNCTION__),
129		[
130	1	'uid' => $uid,
131	1	'time' => date('YmdHi'),
132	1	'fio' => $fio,
133	1	'email' => $email,
134		'redirect' => $redirect
135	1	]
136	1	)['data'];
137		}
138
139	13	public static function getApiHost()
		0 ignored issues – show Coding Style introduced 2017-09-12 14:46 UTC by Report Bug Copy Issue Report `getApiHost` uses the super-global variable `$_SERVER` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
140		{
141	13	return isset($_SERVER['USER']) && $_SERVER['USER'] == 'dp' ? Security::DEV_API_HOST : Security::PROD_API_HOST;
142		}
143
144		public static function getEbsHost()
		0 ignored issues – show Coding Style introduced 2017-09-12 14:46 UTC by Report Bug Copy Issue Report `getEbsHost` uses the super-global variable `$_SERVER` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
145		{
146		return isset($_SERVER['USER']) && $_SERVER['USER'] == 'dp' ? Security::DEV_EBS_HOST : Security::PROD_EBS_HOST;
147		}
148		}

spb-lan / ebs-sdk

Push — master ( c14aad...5ba59a )

Security A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

6 Methods

Duplication Side-by-Side

Filter issues like