Client::getResponse() - Code Metrics - Inspection of "Merge branch 'master' of https://github.com/spb-la..." - spb-lan/ebs-sdk - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( db0246...91f80b )

by Denis

created 2017-09-12 14:44 UTC

Client::getResponse() B

↳ Parent: Client

Complexity

Conditions	6
Paths	5

Size

Total Lines	18
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	3
CRAP Score	16.6682

Importance

Changes

Metric	Value
dl	0
loc	18
ccs	3
cts	9
cp	0.3333
rs	8.8571
c	0
b	0
f	0
cc	6
eloc	9
nc	5
nop	2
crap	16.6682

<?php
/**
 * Created by PhpStorm.
 * User: dp
 * Date: 25.07.17
 * Time: 17:18
 */

namespace Lan\Ebs\Sdk;

use Exception;
use Lan\Ebs\Sdk\Helper\Curl;
use Lan\Ebs\Sdk\Helper\Debuger;

final class Client
{
    private $token = '';

    /**
     * Ebs constructor.
     *
     * @param  $token
     * @throws Exception
     */
    public function __construct($token)
    {
        if (empty($token)) {
            throw new Exception('Token is empty');
        }

        $this->token = $token;
    }

    public function getResponse(array $request, array $params = [])
    {
        if (empty($request['url']) || empty($request['method']) || empty($request['code'])) {
            throw new Exception('Request url, method or success_code is missing');
        }

        $response = Curl::getResponse($this->host, $request['url'], $request['method'], $this->token, $params);
class MyClass { }

$x = new MyClass();
$x->foo = true;

        if (isset($response['debug'])) {
            Debuger::dump(['host' => $this->host, 'request' => $request, 'params' => $params, 'response' => $response]);
        }

        if ($response['status'] != $request['code']) {
            throw new Exception($response['message'], $response['status']);
        }

        return $response;
    }
}

1		<?php
2		/**
3		* Created by PhpStorm.
4		* User: dp
5		* Date: 25.07.17
6		* Time: 17:18
7		*/
8
9		namespace Lan\Ebs\Sdk;
10
11		use Exception;
12		use Lan\Ebs\Sdk\Helper\Curl;
13		use Lan\Ebs\Sdk\Helper\Debuger;
14
15		final class Client
16		{
17		private $token = '';
18
19		/**
20		* Ebs constructor.
21		*
22		* @param $token
23		* @throws Exception
24		*/
25	26	public function __construct($token)
26		{
27	26	if (empty($token)) {
28		throw new Exception('Token is empty');
29		}
30
31	26	$this->token = $token;
32	26	}
33
34	16	public function getResponse(array $request, array $params = [])
35		{
36	16	if (empty($request['url']) \|\| empty($request['method']) \|\| empty($request['code'])) {
37		throw new Exception('Request url, method or success_code is missing');
38		}
39
40	16	$response = Curl::getResponse($this->host, $request['url'], $request['method'], $this->token, $params);
		0 ignored issues – show Bug introduced 2017-09-12 14:33 UTC by Report Bug Copy Issue Report The property `host` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
41
42		if (isset($response['debug'])) {
43		Debuger::dump(['host' => $this->host, 'request' => $request, 'params' => $params, 'response' => $response]);
44		}
45
46		if ($response['status'] != $request['code']) {
47		throw new Exception($response['message'], $response['status']);
48		}
49
50		return $response;
51		}
52		}

spb-lan / ebs-sdk

Push — master ( db0246...91f80b )

Client::getResponse() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like