Article - Code Metrics - spb-lan/ebs-sdk - Measure and Improve Code Quality continuously with Scrutinizer

Article A
last analyzed 2020-09-18 08:12 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	104
Duplicated Lines	31.73 %

Coupling/Cohesion

Components	1
Dependencies	2

Test Coverage

Coverage

Importance

Changes

Metric	Value
wmc	7
lcom	1
cbo	2
dl	33
loc	104
ccs	0
cts	20
cp	0
rs	10
c	0
b	0
f	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	text()	14	14	3
A	__construct()	0	4	1
A	getUrl()	19	19	3

How to fix Duplicated Code

<?php
/**
 * Class Article
 *
 * @author       Denis Shestakov <[email protected]>
 * @copyright    Copyright (c) 2017, Lan Publishing
 * @license      MIT
 */

namespace Lan\Ebs\Sdk\Model;

use Exception;
use Lan\Ebs\Sdk\Classes\Model;
use Lan\Ebs\Sdk\Client;

/**
 * Модель статей
 *
 * @property mixed name
 * @property mixed description
 * @property mixed issn
 * @property mixed eissn
 * @property mixed vac
 * @property mixed year
 * @property mixed issuesPerYear
 * @property mixed editors
 * @property mixed publisher
 * @property mixed url
 *
 * @package      Lan\Ebs
 * @subpackage   Sdk
 * @category     Model
 */
class Article extends Model
{
    /**
     * Наименование статьи
     */
    const FIELD_NAME = 'name';

    /**
     * Авторы статьи
     */
    const FIELD_AUTHORS = 'authors';

    /**
     * Аннотация статьи
     */
    const FIELD_DESCRIPTION = 'description';

    /**
     * Ключевые слова статьи
     */
    const FIELD_KEYWORDS = 'keywords';

    /**
     * Страница начала статьи
     */
    const START_PAGE = 'startPage';

    /**
     * Страница окончания статьи
     */
    const FINISH_PAGE = 'finishPage';

    /**
     * Библиографическая запись
     */
    const FIELD_BIBLIOGRAPHIC_RECORD = 'bibliographicRecord';

    /**
     * Конструктор модели пользователя
     *
     * @param Client $client Инстанс клиента
     * @param array $fields Поля для выборки
     *
     * @throws Exception
     */
    public function __construct(Client $client, array $fields = array())
    {
        parent::__construct($client, $fields);
    }

    /**
     * Получение текстов статьи
     *
     * @param int $id Идентификатор модели
     *
     * @return array
     *
     * @throws Exception
     */
    public function text($id = null)

    {
        if ($id) {
0   == false // true
0   == null  // true
123 == false // false
123 == null  // false

// It is often better to use strict comparison
0 === false // false
0 === null  // false
            $this->setId($id);
        } else {
            $id = $this->getId();
        }

        if (empty($id)) {
            throw new Exception(Model::MESSAGE_ID_REQUIRED);
        }

        return $this->getClient()->getResponse($this->getUrl(__FUNCTION__, array($id)))['data'];
    }

    /**
     * Получение данных для запроса через API
     *
     * @param string $method Http-метод запроса
     * @param array $params Параметры для формирования урла
     *
     * @return array
     *
     * @throws Exception
     */
    public function getUrl($method, array $params = array())

    {
        switch ($method) {
            case 'get':
                return array(
                    'url' => vsprintf('/1.0/resource/journal/article/get/%d', $params),
                    'method' => 'GET',
                    'code' => 200
                );
            case 'text':
                return array(
                    'url' => vsprintf('/1.0/resource/journal/article/text/%d', $params),
                    'method' => 'GET',
                    'code' => 200
                );
            default:
                throw new Exception('Route for ' . $method . ' not found');
        }
    }
}

1		<?php
2		/**
3		* Class Article
4		*
5		* @author Denis Shestakov <[email protected]>
6		* @copyright Copyright (c) 2017, Lan Publishing
7		* @license MIT
8		*/
9
10		namespace Lan\Ebs\Sdk\Model;
11
12		use Exception;
13		use Lan\Ebs\Sdk\Classes\Model;
14		use Lan\Ebs\Sdk\Client;
15
16		/**
17		* Модель статей
18		*
19		* @property mixed name
20		* @property mixed description
21		* @property mixed issn
22		* @property mixed eissn
23		* @property mixed vac
24		* @property mixed year
25		* @property mixed issuesPerYear
26		* @property mixed editors
27		* @property mixed publisher
28		* @property mixed url
29		*
30		* @package Lan\Ebs
31		* @subpackage Sdk
32		* @category Model
33		*/
34		class Article extends Model
35		{
36		/**
37		* Наименование статьи
38		*/
39		const FIELD_NAME = 'name';
40
41		/**
42		* Авторы статьи
43		*/
44		const FIELD_AUTHORS = 'authors';
45
46		/**
47		* Аннотация статьи
48		*/
49		const FIELD_DESCRIPTION = 'description';
50
51		/**
52		* Ключевые слова статьи
53		*/
54		const FIELD_KEYWORDS = 'keywords';
55
56		/**
57		* Страница начала статьи
58		*/
59		const START_PAGE = 'startPage';
60
61		/**
62		* Страница окончания статьи
63		*/
64		const FINISH_PAGE = 'finishPage';
65
66		/**
67		* Библиографическая запись
68		*/
69		const FIELD_BIBLIOGRAPHIC_RECORD = 'bibliographicRecord';
70
71		/**
72		* Конструктор модели пользователя
73		*
74		* @param Client $client Инстанс клиента
75		* @param array $fields Поля для выборки
76		*
77		* @throws Exception
78		*/
79		public function __construct(Client $client, array $fields = array())
80		{
81		parent::__construct($client, $fields);
82		}
83
84		/**
85		* Получение текстов статьи
86		*
87		* @param int $id Идентификатор модели
88		*
89		* @return array
90		*
91		* @throws Exception
92		*/
93	View Code Duplication	public function text($id = null)
		0 ignored issues – show Duplication introduced 2017-10-23 12:11 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
94		{
95		if ($id) {
		0 ignored issues – show Bug Best Practice introduced 2017-10-23 12:11 UTC by Report Bug Copy Issue Report The expression `$id` of type `integer\|null` is loosely compared to `true`; this is ambiguous if the integer can be zero. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `integer` values, zero is a special case, in particular the following results might be unexpected: 0 == false // true 0 == null // true 123 == false // false 123 == null // false // It is often better to use strict comparison 0 === false // false 0 === null // false Loading history...
96		$this->setId($id);
97		} else {
98		$id = $this->getId();
99		}
100
101		if (empty($id)) {
102		throw new Exception(Model::MESSAGE_ID_REQUIRED);
103		}
104
105		return $this->getClient()->getResponse($this->getUrl(__FUNCTION__, array($id)))['data'];
106		}
107
108		/**
109		* Получение данных для запроса через API
110		*
111		* @param string $method Http-метод запроса
112		* @param array $params Параметры для формирования урла
113		*
114		* @return array
115		*
116		* @throws Exception
117		*/
118	View Code Duplication	public function getUrl($method, array $params = array())
		0 ignored issues – show Duplication introduced 2018-06-14 09:42 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
119		{
120		switch ($method) {
121		case 'get':
122		return array(
123		'url' => vsprintf('/1.0/resource/journal/article/get/%d', $params),
124		'method' => 'GET',
125		'code' => 200
126		);
127		case 'text':
128		return array(
129		'url' => vsprintf('/1.0/resource/journal/article/text/%d', $params),
130		'method' => 'GET',
131		'code' => 200
132		);
133		default:
134		throw new Exception('Route for ' . $method . ' not found');
135		}
136		}
137		}

spb-lan / ebs-sdk

Article A last analyzed 2020-09-18 08:12 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

3 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like

Article A
last analyzed 2020-09-18 08:12 UTC