Document::__get() - Code Metrics - Inspection of "v2 updates" - spatie/yaml-front-matter - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( eac52d...140efb )

by Sebastian

created 2017-08-21 09:14 UTC

Document::__get() A

↳ Parent: Document

Complexity

Conditions	2
Paths	2

Size

Total Lines	8
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	8
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	4
nc	2
nop	1

<?php

namespace Spatie\YamlFrontMatter;

use Illuminate\Support\Arr;

class Document
{
    protected $matter;
    protected $body;

    public function __construct(array $matter, string $body)
    {
        $this->matter = $matter;
        $this->body = $body;
    }

    public function matter(string $key = null, $default = null)
    {
        if ($key) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
            return Arr::get($this->matter, $key, $default);
        }

        return $this->matter;
    }

    public function body() : string
    {
        return $this->body;
    }

    public function __get($key)
    {
        if ($key === 'body') {
            return $this->body;
        }

        return $this->matter($key);
    }
}


1			<?php
2
3			namespace Spatie\YamlFrontMatter;
4
5			use Illuminate\Support\Arr;
6
7			class Document
8			{
9			protected $matter;
10			protected $body;
11
12			public function __construct(array $matter, string $body)
13			{
14			$this->matter = $matter;
15			$this->body = $body;
16			}
17
18			public function matter(string $key = null, $default = null)
19			{
20			if ($key) {
			0 ignored issues – show Bug Best Practice introduced 2016-01-13 21:36 UTC by Report Bug Copy Issue Report The expression `$key` of type `null\|string` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
21			return Arr::get($this->matter, $key, $default);
22			}
23
24			return $this->matter;
25			}
26
27			public function body() : string
28			{
29			return $this->body;
30			}
31
32			public function __get($key)
33			{
34			if ($key === 'body') {
35			return $this->body;
36			}
37
38			return $this->matter($key);
39			}
40			}
41

spatie / yaml-front-matter

GitHub Access Token became invalid

Push — master ( eac52d...140efb )

Document::__get() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like