Complex classes like SslCertificate often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use SslCertificate, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
8 | class SslCertificate |
||
9 | { |
||
10 | use Macroable; |
||
11 | |||
12 | /** @var array */ |
||
13 | protected $rawCertificateFields = []; |
||
14 | |||
15 | /** @var string */ |
||
16 | protected $fingerprint = ''; |
||
17 | |||
18 | public static function download(): Downloader |
||
22 | |||
23 | public static function createForHostName(string $url, int $timeout = 30): self |
||
29 | |||
30 | public function __construct(array $rawCertificateFields, string $fingerprint = '') |
||
36 | |||
37 | public function getRawCertificateFields(): array |
||
41 | |||
42 | public function getIssuer(): string |
||
46 | |||
47 | public function getDomain(): string |
||
63 | |||
64 | public function getSignatureAlgorithm(): string |
||
68 | |||
69 | public function getFingerprint(): string |
||
73 | |||
74 | public function getAdditionalDomains(): array |
||
82 | |||
83 | public function validFromDate(): Carbon |
||
87 | |||
88 | public function expirationDate(): Carbon |
||
92 | |||
93 | public function isExpired(): bool |
||
97 | |||
98 | public function isValid(string $url = null) |
||
110 | |||
111 | public function isSelfSigned(): bool |
||
115 | |||
116 | public function usesSha1Hash(): bool |
||
130 | |||
131 | public function isValidUntil(Carbon $carbon, string $url = null): bool |
||
139 | |||
140 | public function daysUntilExpirationDate(): int |
||
148 | |||
149 | public function getDomains(): array |
||
157 | |||
158 | public function appliesToUrl(string $url): bool |
||
178 | |||
179 | protected function wildcardHostCoversHost(string $wildcardHost, string $host): bool |
||
199 | |||
200 | public function getRawCertificateFieldsJson(): string |
||
204 | |||
205 | public function getHash(): string |
||
209 | |||
210 | public function __toString(): string |
||
214 | |||
215 | public function containsDomain(string $domain): bool |
||
231 | |||
232 | public function isPreCertificate() |
||
237 | } |
||
238 |
It seems like the method you are trying to call exists only in some of the possible types.
Let’s take a look at an example:
Available Fixes
Add an additional type-check:
Only allow a single type to be passed if the variable comes from a parameter: