Url::getPort() - Code Metrics - Inspection of "Add support for retrieving the port in the URL, if..." - spatie/ssl-certificate - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 2747b8...1b4b00 )

by Freek

created 2018-05-11 09:09 UTC

Url::getPort() A

↳ Parent: Url

Complexity

Conditions	2
Paths	2

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	2
eloc	2
nc	2
nop	0
dl	0
loc	4
rs	10
c	0
b	0
f	0

<?php

namespace Spatie\SslCertificate;

use Spatie\SslCertificate\Exceptions\InvalidUrl;

class Url
{
    /** @var string */
    protected $url;

    /** @var array */
    protected $parsedUrl;

    public function __construct(string $url)
    {
        if (! starts_with($url, ['http://', 'https://', 'ssl://'])) {
            $url = "https://{$url}";
        }

        $url = idn_to_ascii($url, false, INTL_IDNA_VARIANT_UTS46);

        if (! filter_var($url, FILTER_VALIDATE_URL)) {
            throw InvalidUrl::couldNotValidate($url);
        }

        $this->url = $url;

        $this->parsedUrl = parse_url($url);
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}

        if (! isset($this->parsedUrl['host'])) {
            throw InvalidUrl::couldNotDetermineHost($this->url);
        }
    }

    public function getHostName(): string
    {
        return $this->parsedUrl['host'];
    }

    public function getPort(): int
    {
        return array_key_exists('port', $this->parsedUrl) ? (int) $this->parsedUrl['port'] : 443;
    }
}


1			<?php
2
3			namespace Spatie\SslCertificate;
4
5			use Spatie\SslCertificate\Exceptions\InvalidUrl;
6
7			class Url
8			{
9			/** @var string */
10			protected $url;
11
12			/** @var array */
13			protected $parsedUrl;
14
15			public function __construct(string $url)
16			{
17			if (! starts_with($url, ['http://', 'https://', 'ssl://'])) {
18			$url = "https://{$url}";
19			}
20
21			$url = idn_to_ascii($url, false, INTL_IDNA_VARIANT_UTS46);
22
23			if (! filter_var($url, FILTER_VALIDATE_URL)) {
24			throw InvalidUrl::couldNotValidate($url);
25			}
26
27			$this->url = $url;
28
29			$this->parsedUrl = parse_url($url);
			0 ignored issues – show Documentation Bug introduced 2016-07-25 23:24 UTC by Report Bug Copy Issue Report It seems like `parse_url($url)` can also be of type `false`. However, the property `$parsedUrl` is declared as type `array`. Maybe add an additional type check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly. For example, imagine you have a variable `$accountId` that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the `id` property of an instance of the `Account` class. This class holds a proper account, so the id value must no longer be false. Either this assignment is in error or a type check should be added for that assignment. class Id { public $id; public function __construct($id) { $this->id = $id; } } class Account { /** @var Id $id */ public $id; } $account_id = false; if (starsAreRight()) { $account_id = new Id(42); } $account = new Account(); if ($account instanceof Id) { $account->id = $account_id; } Loading history...
30
31			if (! isset($this->parsedUrl['host'])) {
32			throw InvalidUrl::couldNotDetermineHost($this->url);
33			}
34			}
35
36			public function getHostName(): string
37			{
38			return $this->parsedUrl['host'];
39			}
40
41			public function getPort(): int
42			{
43			return array_key_exists('port', $this->parsedUrl) ? (int) $this->parsedUrl['port'] : 443;
44			}
45			}
46

spatie / ssl-certificate

GitHub Access Token became invalid

Push — master ( 2747b8...1b4b00 )

Url::getPort() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like