Issues in Ssh.php (master) - Issues in master - spatie/ssh - Measure and Improve Code Quality continuously with Scrutinizer

Issues (1)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Ssh.php (1 issue)

Labels

Bug 1

Severity

Critical 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Spatie\Ssh;

use Closure;
use Exception;
use Symfony\Component\Process\Process;

class Ssh
{
    protected string $user;


    protected string $host;

    protected string $pathToPrivateKey = '';

    protected ?int $port;

    protected bool $enableStrictHostChecking = true;

    protected Closure $processConfigurationClosure;

    protected Closure $onOutput;

    public function __construct(string $user, string $host, int $port = null)
    {
        $this->user = $user;

        $this->host = $host;

        $this->port = $port;

        $this->processConfigurationClosure = fn(Process $process) => null;

        $this->onOutput = fn($type, $line) => null;
    }

    public static function create(...$args): self
    {
        return new static(...$args);
    }

    public function usePrivateKey(string $pathToPrivateKey): self
    {
        $this->pathToPrivateKey = $pathToPrivateKey;

        return $this;
    }

    public function usePort(int $port): self
    {
        if ($port < 0) {
            throw new Exception('Port must be a positive integer.');
        }
        $this->port = $port;

        return $this;
    }

    public function configureProcess(Closure $processConfigurationClosure): self
    {
        $this->processConfigurationClosure = $processConfigurationClosure;

        return $this;
    }

    public function onOutput(Closure $onOutput): self
    {
        $this->onOutput = $onOutput;

        return $this;
    }

    public function enableStrictHostKeyChecking(): self
    {
        $this->enableStrictHostChecking = true;

        return $this;
    }

    public function disableStrictHostKeyChecking(): self
    {
        $this->enableStrictHostChecking = false;

        return $this;
    }

    /**
     * @param string|array $command
     *
     * @return string
     */
    public function getExecuteCommand($command): string
    {
        $commands = $this->wrapArray($command);

        $extraOptions = $this->getExtraSshOptions();

        $commandString = implode(PHP_EOL, $commands);

        $delimiter = 'EOF-SPATIE-SSH';

        $target = $this->getTarget();

        return "ssh {$extraOptions} {$target} 'bash -se' << \\$delimiter".PHP_EOL
            .$commandString.PHP_EOL
            .$delimiter;
    }

    /**
     * @param string|array $command
     *
     * @return \Symfony\Component\Process\Process
     */
    public function execute($command): Process
    {
        $sshCommand = $this->getExecuteCommand($command);

        return $this->run($sshCommand);
    }

    /**
     * @param string|array $command
     *
     * @return \Symfony\Component\Process\Process
     */
    public function executeAsync($command): Process
    {
        $sshCommand = $this->getExecuteCommand($command);

        return $this->run($sshCommand, 'start');
    }

    public function getDownloadCommand(string $sourcePath, string $destinationPath): string
    {
        return "scp {$this->getExtraScpOptions()} {$this->getTarget()}:$sourcePath $destinationPath";
    }

    public function download(string $sourcePath, string $destinationPath): Process
    {
        $downloadCommand = $this->getDownloadCommand($sourcePath, $destinationPath);

        return $this->run($downloadCommand);
    }

    public function getUploadCommand(string $sourcePath, string $destinationPath): string
    {
        return "scp {$this->getExtraScpOptions()} $sourcePath {$this->getTarget()}:$destinationPath";
    }

    public function upload(string $sourcePath, string $destinationPath): Process
    {
        $uploadCommand = $this->getUploadCommand($sourcePath, $destinationPath);

        return $this->run($uploadCommand);
    }

    protected function getExtraSshOptions(): string
    {
        $extraOptions = $this->getExtraOptions();

        if (! is_null($this->port)) {
            $extraOptions[] = "-p {$this->port}";
        }

        return implode(' ', $extraOptions);
    }

    protected function getExtraScpOptions(): string
    {
        $extraOptions = $this->getExtraOptions();

        $extraOptions[] = '-r';

        if (! is_null($this->port)) {
            $extraOptions[] = "-P {$this->port}";
        }

        return implode(' ', $extraOptions);
    }

    private function getExtraOptions(): array
    {
        $extraOptions = [];

        if ($this->pathToPrivateKey) {
            $extraOptions[] = "-i {$this->pathToPrivateKey}";
        }

        if (! $this->enableStrictHostChecking) {
            $extraOptions[] = '-o StrictHostKeyChecking=no';
            $extraOptions[] = '-o UserKnownHostsFile=/dev/null';
        }

        return $extraOptions;
    }

    protected function wrapArray($arrayOrString): array
    {
        return (array) $arrayOrString;
    }

    protected function run(string $command, string $method = 'run'): Process
    {
        $process = Process::fromShellCommandline($command);

        $process->setTimeout(0);

        ($this->processConfigurationClosure)($process);

        $process->{$method}($this->onOutput);

        return $process;
    }

    protected function getTarget(): string
    {
        return "{$this->user}@{$this->host}";
    }
}


GitHub Access Token became invalid

Issues (1)

Security Analysis no request data

src/Ssh.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

1			<?php
2
3			namespace Spatie\Ssh;
4
5			use Closure;
6			use Exception;
7			use Symfony\Component\Process\Process;
8
9			class Ssh
10			{
11			protected string $user;
			0 ignored issues – show Bug introduced 2020-02-03 13:20 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code did not parse for me. Apparently, there is an error somewhere around this line: Syntax error, unexpected T_STRING, expecting T_FUNCTION or T_CONST Loading history...
12
13			protected string $host;
14
15			protected string $pathToPrivateKey = '';
16
17			protected ?int $port;
18
19			protected bool $enableStrictHostChecking = true;
20
21			protected Closure $processConfigurationClosure;
22
23			protected Closure $onOutput;
24
25			public function __construct(string $user, string $host, int $port = null)
26			{
27			$this->user = $user;
28
29			$this->host = $host;
30
31			$this->port = $port;
32
33			$this->processConfigurationClosure = fn(Process $process) => null;
34
35			$this->onOutput = fn($type, $line) => null;
36			}
37
38			public static function create(...$args): self
39			{
40			return new static(...$args);
41			}
42
43			public function usePrivateKey(string $pathToPrivateKey): self
44			{
45			$this->pathToPrivateKey = $pathToPrivateKey;
46
47			return $this;
48			}
49
50			public function usePort(int $port): self
51			{
52			if ($port < 0) {
53			throw new Exception('Port must be a positive integer.');
54			}
55			$this->port = $port;
56
57			return $this;
58			}
59
60			public function configureProcess(Closure $processConfigurationClosure): self
61			{
62			$this->processConfigurationClosure = $processConfigurationClosure;
63
64			return $this;
65			}
66
67			public function onOutput(Closure $onOutput): self
68			{
69			$this->onOutput = $onOutput;
70
71			return $this;
72			}
73
74			public function enableStrictHostKeyChecking(): self
75			{
76			$this->enableStrictHostChecking = true;
77
78			return $this;
79			}
80
81			public function disableStrictHostKeyChecking(): self
82			{
83			$this->enableStrictHostChecking = false;
84
85			return $this;
86			}
87
88			/**
89			* @param string\|array $command
90			*
91			* @return string
92			*/
93			public function getExecuteCommand($command): string
94			{
95			$commands = $this->wrapArray($command);
96
97			$extraOptions = $this->getExtraSshOptions();
98
99			$commandString = implode(PHP_EOL, $commands);
100
101			$delimiter = 'EOF-SPATIE-SSH';
102
103			$target = $this->getTarget();
104
105			return "ssh {$extraOptions} {$target} 'bash -se' << \\$delimiter".PHP_EOL
106			.$commandString.PHP_EOL
107			.$delimiter;
108			}
109
110			/**
111			* @param string\|array $command
112			*
113			* @return \Symfony\Component\Process\Process
114			*/
115			public function execute($command): Process
116			{
117			$sshCommand = $this->getExecuteCommand($command);
118
119			return $this->run($sshCommand);
120			}
121
122			/**
123			* @param string\|array $command
124			*
125			* @return \Symfony\Component\Process\Process
126			*/
127			public function executeAsync($command): Process
128			{
129			$sshCommand = $this->getExecuteCommand($command);
130
131			return $this->run($sshCommand, 'start');
132			}
133
134			public function getDownloadCommand(string $sourcePath, string $destinationPath): string
135			{
136			return "scp {$this->getExtraScpOptions()} {$this->getTarget()}:$sourcePath $destinationPath";
137			}
138
139			public function download(string $sourcePath, string $destinationPath): Process
140			{
141			$downloadCommand = $this->getDownloadCommand($sourcePath, $destinationPath);
142
143			return $this->run($downloadCommand);
144			}
145
146			public function getUploadCommand(string $sourcePath, string $destinationPath): string
147			{
148			return "scp {$this->getExtraScpOptions()} $sourcePath {$this->getTarget()}:$destinationPath";
149			}
150
151			public function upload(string $sourcePath, string $destinationPath): Process
152			{
153			$uploadCommand = $this->getUploadCommand($sourcePath, $destinationPath);
154
155			return $this->run($uploadCommand);
156			}
157
158			protected function getExtraSshOptions(): string
159			{
160			$extraOptions = $this->getExtraOptions();
161
162			if (! is_null($this->port)) {
163			$extraOptions[] = "-p {$this->port}";
164			}
165
166			return implode(' ', $extraOptions);
167			}
168
169			protected function getExtraScpOptions(): string
170			{
171			$extraOptions = $this->getExtraOptions();
172
173			$extraOptions[] = '-r';
174
175			if (! is_null($this->port)) {
176			$extraOptions[] = "-P {$this->port}";
177			}
178
179			return implode(' ', $extraOptions);
180			}
181
182			private function getExtraOptions(): array
183			{
184			$extraOptions = [];
185
186			if ($this->pathToPrivateKey) {
187			$extraOptions[] = "-i {$this->pathToPrivateKey}";
188			}
189
190			if (! $this->enableStrictHostChecking) {
191			$extraOptions[] = '-o StrictHostKeyChecking=no';
192			$extraOptions[] = '-o UserKnownHostsFile=/dev/null';
193			}
194
195			return $extraOptions;
196			}
197
198			protected function wrapArray($arrayOrString): array
199			{
200			return (array) $arrayOrString;
201			}
202
203			protected function run(string $command, string $method = 'run'): Process
204			{
205			$process = Process::fromShellCommandline($command);
206
207			$process->setTimeout(0);
208
209			($this->processConfigurationClosure)($process);
210
211			$process->{$method}($this->onOutput);
212
213			return $process;
214			}
215
216			protected function getTarget(): string
217			{
218			return "{$this->user}@{$this->host}";
219			}
220			}
221

spatie / ssh

GitHub Access Token became invalid

Issues (1)

Security Analysis no request data

src/Ssh.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like