Issues in Elasticsearch.php (master) - Issues in master - spatie/searchindex - Measure and Improve Code Quality continuously with Scrutinizer

Issues (11)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/SearchIndexHandlers/Elasticsearch.php (7 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Spatie\SearchIndex\SearchIndexHandlers;

use Elasticsearch\Client;
use InvalidArgumentException;
use Spatie\SearchIndex\Searchable;
use Spatie\SearchIndex\SearchIndexHandler;
use Traversable;

class Elasticsearch implements SearchIndexHandler
{
    /** @var Elasticsearch */
    protected $elasticsearch;

    /** @var string */
    protected $indexName;

    /**
     * @param Client $elasticsearch
     */
    public function __construct(Client $elasticsearch)
    {
        $this->elasticsearch = $elasticsearch;

    }

    /**
     * Set the name of the index that should be used by default.
     *
     * @param $indexName
     *
     * @return $this
     */
    public function setIndexName($indexName)
    {
        $this->indexName = $indexName;

        return $this;
    }

    /**
     * Add or update the given searchable subject or array of subjects or Traversable object containing subjects.
     *
     * @param Searchable|array|Traversable $subject
     */
    public function upsertToIndex($subject, $indexName = null)
    {
        $indexName = $this->resolveIndexName($indexName);

        if ($subject instanceof Searchable) {
            $subject = [$subject];
        }

        if (is_array($subject) || $subject instanceof Traversable) {
            $searchableItems = collect($subject)
                ->each(function ($item) {
                    if (!$item instanceof Searchable) {
                        throw new InvalidArgumentException();
                    }
                })
                ->flatMap(function ($item) use($indexName) {
                    return
                        [
                            [
                                'index' => [
                                    '_id'    => $item->getSearchableId(),
                                    '_index' => $indexName,
                                    '_type'  => $item->getSearchableType(),
                                ],
                            ],

                            $item->getSearchableBody(),
                        ];
                })
                ->toArray();

            $payload['body'] = $searchableItems;
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}

            $this->elasticsearch->bulk($payload);


            return;
        }

        throw new InvalidArgumentException('Subject must be a searchable or array of searchables');
    }

    /**
     * Remove the given subject from the search index.
     *
     * @param Searchable $subject
     */
    public function removeFromIndex(Searchable $subject, $indexName = null)
    {
        $indexName = $this->resolveIndexName($indexName);

        $this->elasticsearch->delete(

            [
                'index' => $indexName,
                'type'  => $subject->getSearchableType(),
                'id'    => $subject->getSearchableId(),
            ]
        );
    }

    /**
     * Remove an item from the search index by type and id.
     *
     * @param string $type
     * @param int    $id
     */
    public function removeFromIndexByTypeAndId($type, $id, $indexName = null)
    {
        $indexName = $this->resolveIndexName($indexName);

        $this->elasticsearch->delete(

            [
                'index' => $indexName,
                'type'  => $type,
                'id'    => $id,
            ]
        );
    }

    /**
     * Remove everything from the index.
     *
     * @return mixed
     */
    public function clearIndex($indexName = null)
    {
        $indexName = $this->resolveIndexName($indexName);

        $this->elasticsearch->indices()->delete(['index' => $indexName]);

    }

    /**
     * Get the results for the given query.
     *
     * @param array $query
     *
     * @return mixed
     */
    public function getResults($query)
    {
        return $this->elasticsearch->search($query);

    }

    /**
     * Get the underlying client.
     *
     * @return Elasticsearch
     */
    public function getClient()
    {
        return $this->elasticsearch;
    }

    protected function resolveIndexName($indexName = null)
    {
        if (!$indexName) {
            $indexName = $this->indexName;
        }

        return $indexName;
    }
}


1			<?php
2
3			namespace Spatie\SearchIndex\SearchIndexHandlers;
4
5			use Elasticsearch\Client;
6			use InvalidArgumentException;
7			use Spatie\SearchIndex\Searchable;
8			use Spatie\SearchIndex\SearchIndexHandler;
9			use Traversable;
10
11			class Elasticsearch implements SearchIndexHandler
12			{
13			/** @var Elasticsearch */
14			protected $elasticsearch;
15
16			/** @var string */
17			protected $indexName;
18
19			/**
20			* @param Client $elasticsearch
21			*/
22			public function __construct(Client $elasticsearch)
23			{
24			$this->elasticsearch = $elasticsearch;
			0 ignored issues – show Documentation Bug introduced 2016-05-15 23:55 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$elasticsearch` of type `object<Elasticsearch\Client>` is incompatible with the declared type `object<Spatie\SearchInde...Handlers\Elasticsearch>` of property `$elasticsearch`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
25			}
26
27			/**
28			* Set the name of the index that should be used by default.
29			*
30			* @param $indexName
31			*
32			* @return $this
33			*/
34			public function setIndexName($indexName)
35			{
36			$this->indexName = $indexName;
37
38			return $this;
39			}
40
41			/**
42			* Add or update the given searchable subject or array of subjects or Traversable object containing subjects.
43			*
44			* @param Searchable\|array\|Traversable $subject
45			*/
46			public function upsertToIndex($subject, $indexName = null)
47			{
48			$indexName = $this->resolveIndexName($indexName);
49
50			if ($subject instanceof Searchable) {
51			$subject = [$subject];
52			}
53
54			if (is_array($subject) \|\| $subject instanceof Traversable) {
55			$searchableItems = collect($subject)
56			->each(function ($item) {
57			if (!$item instanceof Searchable) {
58			throw new InvalidArgumentException();
59			}
60			})
61			->flatMap(function ($item) use($indexName) {
62			return
63			[
64			[
65			'index' => [
66			'_id' => $item->getSearchableId(),
67			'_index' => $indexName,
68			'_type' => $item->getSearchableType(),
69			],
70			],
71
72			$item->getSearchableBody(),
73			];
74			})
75			->toArray();
76
77			$payload['body'] = $searchableItems;
			0 ignored issues – show Coding Style Comprehensibility introduced 2016-08-18 09:41 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$payload` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$payload = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
78
79			$this->elasticsearch->bulk($payload);
			0 ignored issues – show Bug introduced 2016-08-18 09:41 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `bulk()` does not seem to exist on `object<Spatie\SearchInde...Handlers\Elasticsearch>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
80
81			return;
82			}
83
84			throw new InvalidArgumentException('Subject must be a searchable or array of searchables');
85			}
86
87			/**
88			* Remove the given subject from the search index.
89			*
90			* @param Searchable $subject
91			*/
92			public function removeFromIndex(Searchable $subject, $indexName = null)
93			{
94			$indexName = $this->resolveIndexName($indexName);
95
96			$this->elasticsearch->delete(
			0 ignored issues – show Bug introduced 2017-12-18 11:23 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `delete()` does not seem to exist on `object<Spatie\SearchInde...Handlers\Elasticsearch>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
97			[
98			'index' => $indexName,
99			'type' => $subject->getSearchableType(),
100			'id' => $subject->getSearchableId(),
101			]
102			);
103			}
104
105			/**
106			* Remove an item from the search index by type and id.
107			*
108			* @param string $type
109			* @param int $id
110			*/
111			public function removeFromIndexByTypeAndId($type, $id, $indexName = null)
112			{
113			$indexName = $this->resolveIndexName($indexName);
114
115			$this->elasticsearch->delete(
			0 ignored issues – show Bug introduced 2017-12-18 11:23 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `delete()` does not seem to exist on `object<Spatie\SearchInde...Handlers\Elasticsearch>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
116			[
117			'index' => $indexName,
118			'type' => $type,
119			'id' => $id,
120			]
121			);
122			}
123
124			/**
125			* Remove everything from the index.
126			*
127			* @return mixed
128			*/
129			public function clearIndex($indexName = null)
130			{
131			$indexName = $this->resolveIndexName($indexName);
132
133			$this->elasticsearch->indices()->delete(['index' => $indexName]);
			0 ignored issues – show Bug introduced 2016-05-15 23:55 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `indices()` does not seem to exist on `object<Spatie\SearchInde...Handlers\Elasticsearch>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
134			}
135
136			/**
137			* Get the results for the given query.
138			*
139			* @param array $query
140			*
141			* @return mixed
142			*/
143			public function getResults($query)
144			{
145			return $this->elasticsearch->search($query);
			0 ignored issues – show Bug introduced 2016-05-15 23:55 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `search()` does not seem to exist on `object<Spatie\SearchInde...Handlers\Elasticsearch>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
146			}
147
148			/**
149			* Get the underlying client.
150			*
151			* @return Elasticsearch
152			*/
153			public function getClient()
154			{
155			return $this->elasticsearch;
156			}
157
158			protected function resolveIndexName($indexName = null)
159			{
160			if (!$indexName) {
161			$indexName = $this->indexName;
162			}
163
164			return $indexName;
165			}
166			}
167

GitHub Access Token became invalid

Issues (11)

Security Analysis no request data

src/SearchIndexHandlers/Elasticsearch.php (7 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

spatie / searchindex

GitHub Access Token became invalid

Issues (11)

Security Analysis no request data

src/SearchIndexHandlers/Elasticsearch.php (7 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like