Spatie\SchemaOrg\Generator\Parser\Tasks\Task

Complexity

Total Complexity

7

Size/Duplication

Total Lines	40
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	1

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	fromCrawler()	0	7	1
A	getText()	0	12	3
A	getAttribute()	0	8	2

<?php

namespace Spatie\SchemaOrg\Generator\Parser\Tasks;

use Symfony\Component\DomCrawler\Crawler;

abstract class Task
{
    /** @string */
    protected $definition;

    public function __construct(string $definition)
    {
        $this->definition = $definition;
    }

    public static function fromCrawler(Crawler $crawler): self
    {
        $node = $crawler->getNode(0);
        $html = $node->ownerDocument->saveHTML($node);

        return new static($html);
    }

    protected function getText(Crawler $node, string $selector = null): string
    {
        if ($selector) {

The expression $selector of type null|string is loosely compared to true; this is ambiguous if the string can be empty. You might want to explicitly use !== null instead.

            $node = $node->filter($selector)->first();
        }

        if ($node->count() === 0) {
            return '';
        }

        return trim($node->text());
    }

    protected function getAttribute(Crawler $node, string $attribute): string
    {
        if ($node->count() === 0) {
            return '';
        }

        return $node->filter("[{$attribute}]")->attr($attribute) ?? '';
    }
}