Spatie\Regex\MatchAllResult

Complexity

Total Complexity

6

Size/Duplication

Total Lines	62
Duplicated Lines	37.1 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	7	7	1
A	for()	16	16	3
A	hasMatch()	0	4	1
A	results()	0	6	1

<?php

namespace Spatie\Regex;

use Exception;
use Spatie\Regex\Helpers\Arr;

class MatchAllResult extends RegexResult
{
    /** @var string */
    protected $pattern;

    /** @var string */
    protected $subject;

    /** @var bool */
    protected $hasMatch;

    /** @var array */
    protected $matches;

    public function __construct(string $pattern, string $subject, bool $result, array $matches)

This method seems to be duplicated in your project.

    {
        $this->pattern = $pattern;
        $this->subject = $subject;
        $this->hasMatch = $result;
        $this->matches = $matches;
    }

    /**
     * @param string $pattern
     * @param string $subject
     *
     * @return static
     *
     * @throws \Spatie\Regex\RegexFailed
     */
    public static function for(string $pattern, string $subject)

This method seems to be duplicated in your project.

    {
        $matches = [];

        try {
            $result = preg_match_all($pattern, $subject, $matches);
        } catch (Exception $exception) {
            throw RegexFailed::match($pattern, $subject, $exception->getMessage());
        }

        if ($result === false) {
            throw RegexFailed::match($pattern, $subject, static::lastPregError());
        }

        return new static($pattern, $subject, $result, $matches);

$result is of type integer, but the function expects a boolean.

It seems like $matches can also be of type null; however, Spatie\Regex\MatchAllResult::__construct() does only seem to accept array, maybe add an additional type check?

    }

    public function hasMatch(): bool
    {
        return $this->hasMatch;
    }

    /**
     * @return \Spatie\Regex\MatchResult[]
     */
    public function results(): array
    {
        return Arr::map(Arr::transpose($this->matches), function ($match): MatchResult {
            return new MatchResult($this->pattern, $this->subject, true, $match);
        });
    }
}