HtmlDriver::serialize() - Code Metrics - Inspection of "html driver" - spatie/phpunit-snapshot-assertions - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#76)

by Tom

created 2019-10-10 15:19 UTC

HtmlDriver::serialize() A

↳ Parent: HtmlDriver

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	14
Ratio	100 %

Importance

Changes

Metric	Value
dl	14
loc	14
rs	9.7998
c	0
b	0
f	0
cc	2
nc	2
nop	1

<?php

namespace Spatie\Snapshots\Drivers;

use DOMDocument;
use PHPUnit\Framework\Assert;
use Spatie\Snapshots\Driver;
use Spatie\Snapshots\Exceptions\CantBeSerialized;

class HtmlDriver implements Driver

{
    public function serialize($data): string
    {
        if (! is_string($data)) {
            throw new CantBeSerialized('Only strings can be serialized to html');
        }

        $domDocument = new DOMDocument('1.0');
        $domDocument->preserveWhiteSpace = false;
        $domDocument->formatOutput = true;

        @$domDocument->loadHTML($data); // to ignore HTML5 errors
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}

        return $domDocument->saveHTML();
    }

    public function extension(): string
    {
        return 'html';
    }

    public function match($expected, $actual)
    {
        Assert::assertEquals($expected, $this->serialize($actual));
    }
}


1		<?php
2
3		namespace Spatie\Snapshots\Drivers;
4
5		use DOMDocument;
6		use PHPUnit\Framework\Assert;
7		use Spatie\Snapshots\Driver;
8		use Spatie\Snapshots\Exceptions\CantBeSerialized;
9
10	View Code Duplication	class HtmlDriver implements Driver
		0 ignored issues – show Duplication introduced 2019-10-09 09:25 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
11		{
12		public function serialize($data): string
13		{
14		if (! is_string($data)) {
15		throw new CantBeSerialized('Only strings can be serialized to html');
16		}
17
18		$domDocument = new DOMDocument('1.0');
19		$domDocument->preserveWhiteSpace = false;
20		$domDocument->formatOutput = true;
21
22		@$domDocument->loadHTML($data); // to ignore HTML5 errors
		0 ignored issues – show Security Best Practice introduced 2019-10-09 09:25 UTC by Report Bug Copy Issue Report It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
23
24		return $domDocument->saveHTML();
25		}
26
27		public function extension(): string
28		{
29		return 'html';
30		}
31
32		public function match($expected, $actual)
33		{
34		Assert::assertEquals($expected, $this->serialize($actual));
35		}
36		}
37

spatie / phpunit-snapshot-assertions

GitHub Access Token became invalid

Pull Request — master (#76)

HtmlDriver::serialize() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like