RangeFinder::findPreviousCloseInWorkingHours() - Code Metrics - Inspection of "Merge pull request #132 from kylekatarnls/feature/..." - spatie/opening-hours - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( aea5ce...acd138 )

by Kyle

created 2019-07-18 20:48 UTC

RangeFinder::findPreviousCloseInWorkingHours() A

↳ Parent: RangeFinder

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	8
rs	10
c	0
b	0
f	0
cc	2
nc	2
nop	2

<?php

namespace Spatie\OpeningHours\Helpers;

use Spatie\OpeningHours\Time;
use Spatie\OpeningHours\TimeRange;

trait RangeFinder
{
    protected function findRangeInFreeTime(Time $time, TimeRange $timeRange)
    {
        if ($timeRange->start()->isAfter($time)) {
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            return $timeRange;
        }
    }

    protected function findOpenInFreeTime(Time $time, TimeRange $timeRange)
    {
        $range = $this->findRangeInFreeTime($time, $timeRange);

        if ($range) {
            return $range->start();
        }
    }

    protected function findOpenRangeInWorkingHours(Time $time, TimeRange $timeRange)
    {
        if ($timeRange->start()->isBefore($time)) {
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            return $timeRange;
        }
    }

    protected function findOpenInWorkingHours(Time $time, TimeRange $timeRange)
    {
        $range = $this->findOpenRangeInWorkingHours($time, $timeRange);

        if ($range) {
            return $range->start();
        }
    }

    protected function findCloseInWorkingHours(Time $time, TimeRange $timeRange)
    {
        if ($timeRange->containsTime($time)) {
            return $timeRange->end();
        }
    }

    protected function findCloseRangeInWorkingHours(Time $time, TimeRange $timeRange)
    {
        if ($timeRange->containsTime($time)) {
            return $timeRange;
        }
    }

    protected function findCloseInFreeTime(Time $time, TimeRange $timeRange)
    {
        $range = $this->findRangeInFreeTime($time, $timeRange);

        if ($range) {
            return $range->end();
        }
    }

    protected function findPreviousRangeInFreeTime(Time $time, TimeRange $timeRange)
    {
        if ($timeRange->end()->isBefore($time)) {
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            return $timeRange;
        }
    }

    protected function findPreviousOpenInFreeTime(Time $time, TimeRange $timeRange)
    {
        $range = $this->findPreviousRangeInFreeTime($time, $timeRange);

        if ($range) {
            return $range->start();
        }
    }

    protected function findPreviousCloseInWorkingHours(Time $time, TimeRange $timeRange)
    {
        $end = $timeRange->end();

        if ($end->isBefore($time)) {
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            return $end;
        }
    }
}


1			<?php
2
3			namespace Spatie\OpeningHours\Helpers;
4
5			use Spatie\OpeningHours\Time;
6			use Spatie\OpeningHours\TimeRange;
7
8			trait RangeFinder
9			{
10			protected function findRangeInFreeTime(Time $time, TimeRange $timeRange)
11			{
12			if ($timeRange->start()->isAfter($time)) {
			0 ignored issues – show Documentation introduced 2019-07-18 18:00 UTC by Report Bug Copy Issue Report `$time` is of type `object<Spatie\OpeningHours\Time>`, but the function expects a `object<self>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
13			return $timeRange;
14			}
15			}
16
17			protected function findOpenInFreeTime(Time $time, TimeRange $timeRange)
18			{
19			$range = $this->findRangeInFreeTime($time, $timeRange);
20
21			if ($range) {
22			return $range->start();
23			}
24			}
25
26			protected function findOpenRangeInWorkingHours(Time $time, TimeRange $timeRange)
27			{
28			if ($timeRange->start()->isBefore($time)) {
			0 ignored issues – show Documentation introduced 2019-07-18 18:00 UTC by Report Bug Copy Issue Report `$time` is of type `object<Spatie\OpeningHours\Time>`, but the function expects a `object<self>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
29			return $timeRange;
30			}
31			}
32
33			protected function findOpenInWorkingHours(Time $time, TimeRange $timeRange)
34			{
35			$range = $this->findOpenRangeInWorkingHours($time, $timeRange);
36
37			if ($range) {
38			return $range->start();
39			}
40			}
41
42			protected function findCloseInWorkingHours(Time $time, TimeRange $timeRange)
43			{
44			if ($timeRange->containsTime($time)) {
45			return $timeRange->end();
46			}
47			}
48
49			protected function findCloseRangeInWorkingHours(Time $time, TimeRange $timeRange)
50			{
51			if ($timeRange->containsTime($time)) {
52			return $timeRange;
53			}
54			}
55
56			protected function findCloseInFreeTime(Time $time, TimeRange $timeRange)
57			{
58			$range = $this->findRangeInFreeTime($time, $timeRange);
59
60			if ($range) {
61			return $range->end();
62			}
63			}
64
65			protected function findPreviousRangeInFreeTime(Time $time, TimeRange $timeRange)
66			{
67			if ($timeRange->end()->isBefore($time)) {
			0 ignored issues – show Documentation introduced 2019-07-18 18:00 UTC by Report Bug Copy Issue Report `$time` is of type `object<Spatie\OpeningHours\Time>`, but the function expects a `object<self>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
68			return $timeRange;
69			}
70			}
71
72			protected function findPreviousOpenInFreeTime(Time $time, TimeRange $timeRange)
73			{
74			$range = $this->findPreviousRangeInFreeTime($time, $timeRange);
75
76			if ($range) {
77			return $range->start();
78			}
79			}
80
81			protected function findPreviousCloseInWorkingHours(Time $time, TimeRange $timeRange)
82			{
83			$end = $timeRange->end();
84
85			if ($end->isBefore($time)) {
			0 ignored issues – show Documentation introduced 2019-07-18 18:00 UTC by Report Bug Copy Issue Report `$time` is of type `object<Spatie\OpeningHours\Time>`, but the function expects a `object<self>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
86			return $end;
87			}
88			}
89			}
90

spatie / opening-hours

GitHub Access Token became invalid

Push — master ( aea5ce...acd138 )

RangeFinder::findPreviousCloseInWorkingHours() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like