TimeRange::fromList() - Code Metrics - Inspection of "Merge pull request #81 from spatie/version-1.9" - spatie/opening-hours - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 5f72cb...f6c114 )

by Kyle

created 2018-12-07 13:12 UTC

TimeRange::fromList() B

↳ Parent: TimeRange

Complexity

Conditions	7
Paths	12

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	28
rs	8.5386
c	0
b	0
f	0
cc	7
nc	12
nop	1

<?php

namespace Spatie\OpeningHours;

use Spatie\OpeningHours\Exceptions\InvalidTimeRangeList;
use Spatie\OpeningHours\Exceptions\InvalidTimeRangeString;

class TimeRange
{
    /** @var \Spatie\OpeningHours\Time */
    protected $start;

    /** @var \Spatie\OpeningHours\Time */
    protected $end;

    protected function __construct(Time $start, Time $end)
    {
        $this->start = $start;
        $this->end = $end;
    }

    public static function fromString(string $string): self
    {
        $times = explode('-', $string);

        if (count($times) !== 2) {
            throw InvalidTimeRangeString::forString($string);
        }

        return new self(Time::fromString($times[0]), Time::fromString($times[1]));
    }

    public static function fromList(array $ranges): self
    {
        if (count($ranges) === 0) {
            throw InvalidTimeRangeList::create();
        }

        foreach ($ranges as $range) {
            if (! ($range instanceof self)) {
                throw InvalidTimeRangeList::create();
            }
        }

        $start = $ranges[0]->start();
        $end = $ranges[0]->end();

        foreach (array_slice($ranges, 1) as $range) {
            $rangeStart = $range->start();
            if ($rangeStart->format('Gi') < $start->format('Gi')) {
                $start = $rangeStart;
            }
            $rangeEnd = $range->end();
            if ($rangeEnd->format('Gi') > $end->format('Gi')) {
                $end = $rangeEnd;
            }
        }

        return new self($start, $end);
    }

    public function start(): Time
    {
        return $this->start;
    }

    public function end(): Time
    {
        return $this->end;
    }

    public function spillsOverToNextDay(): bool
    {
        return $this->end->isBefore($this->start);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    public function containsTime(Time $time): bool
    {
        if ($this->spillsOverToNextDay()) {
            if ($time->isSameOrAfter($this->start)) {
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                return $time->isAfter($this->end);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            }

            return $time->isBefore($this->end);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        }

        return $time->isSameOrAfter($this->start) && $time->isBefore($this->end);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    public function overlaps(self $timeRange): bool
    {
        return $this->containsTime($timeRange->start) || $this->containsTime($timeRange->end);
    }

    public function format(string $timeFormat = 'H:i', string $rangeFormat = '%s-%s'): string
    {
        return sprintf($rangeFormat, $this->start->format($timeFormat), $this->end->format($timeFormat));
    }

    public function __toString(): string
    {
        return $this->format();
    }
}


1			<?php
2
3			namespace Spatie\OpeningHours;
4
5			use Spatie\OpeningHours\Exceptions\InvalidTimeRangeList;
6			use Spatie\OpeningHours\Exceptions\InvalidTimeRangeString;
7
8			class TimeRange
9			{
10			/** @var \Spatie\OpeningHours\Time */
11			protected $start;
12
13			/** @var \Spatie\OpeningHours\Time */
14			protected $end;
15
16			protected function __construct(Time $start, Time $end)
17			{
18			$this->start = $start;
19			$this->end = $end;
20			}
21
22			public static function fromString(string $string): self
23			{
24			$times = explode('-', $string);
25
26			if (count($times) !== 2) {
27			throw InvalidTimeRangeString::forString($string);
28			}
29
30			return new self(Time::fromString($times[0]), Time::fromString($times[1]));
31			}
32
33			public static function fromList(array $ranges): self
34			{
35			if (count($ranges) === 0) {
36			throw InvalidTimeRangeList::create();
37			}
38
39			foreach ($ranges as $range) {
40			if (! ($range instanceof self)) {
41			throw InvalidTimeRangeList::create();
42			}
43			}
44
45			$start = $ranges[0]->start();
46			$end = $ranges[0]->end();
47
48			foreach (array_slice($ranges, 1) as $range) {
49			$rangeStart = $range->start();
50			if ($rangeStart->format('Gi') < $start->format('Gi')) {
51			$start = $rangeStart;
52			}
53			$rangeEnd = $range->end();
54			if ($rangeEnd->format('Gi') > $end->format('Gi')) {
55			$end = $rangeEnd;
56			}
57			}
58
59			return new self($start, $end);
60			}
61
62			public function start(): Time
63			{
64			return $this->start;
65			}
66
67			public function end(): Time
68			{
69			return $this->end;
70			}
71
72			public function spillsOverToNextDay(): bool
73			{
74			return $this->end->isBefore($this->start);
			0 ignored issues – show Documentation introduced 2017-11-09 10:47 UTC by Report Bug Copy Issue Report `$this->start` is of type `object<Spatie\OpeningHours\Time>`, but the function expects a `object<self>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
75			}
76
77			public function containsTime(Time $time): bool
78			{
79			if ($this->spillsOverToNextDay()) {
80			if ($time->isSameOrAfter($this->start)) {
			0 ignored issues – show Documentation introduced 2018-10-02 12:17 UTC by Report Bug Copy Issue Report `$this->start` is of type `object<Spatie\OpeningHours\Time>`, but the function expects a `object<self>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
81			return $time->isAfter($this->end);
			0 ignored issues – show Documentation introduced 2017-11-09 10:47 UTC by Report Bug Copy Issue Report `$this->end` is of type `object<Spatie\OpeningHours\Time>`, but the function expects a `object<self>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
82			}
83
84			return $time->isBefore($this->end);
			0 ignored issues – show Documentation introduced 2017-11-09 10:47 UTC by Report Bug Copy Issue Report `$this->end` is of type `object<Spatie\OpeningHours\Time>`, but the function expects a `object<self>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
85			}
86
87			return $time->isSameOrAfter($this->start) && $time->isBefore($this->end);
			0 ignored issues – show Documentation introduced 2017-11-09 10:47 UTC by Report Bug Copy Issue Report `$this->start` is of type `object<Spatie\OpeningHours\Time>`, but the function expects a `object<self>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history... Documentation introduced 2017-11-09 10:47 UTC by Report Bug Copy Issue Report `$this->end` is of type `object<Spatie\OpeningHours\Time>`, but the function expects a `object<self>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
88			}
89
90			public function overlaps(self $timeRange): bool
91			{
92			return $this->containsTime($timeRange->start) \|\| $this->containsTime($timeRange->end);
93			}
94
95			public function format(string $timeFormat = 'H:i', string $rangeFormat = '%s-%s'): string
96			{
97			return sprintf($rangeFormat, $this->start->format($timeFormat), $this->end->format($timeFormat));
98			}
99
100			public function __toString(): string
101			{
102			return $this->format();
103			}
104			}
105

spatie / opening-hours

GitHub Access Token became invalid

Push — master ( 5f72cb...f6c114 )

TimeRange::fromList() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like