Spatie\MixedContentScanner\MixedContentObserver

Complexity

Total Complexity

12

Size/Duplication

Total Lines	74
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	5

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	crawled()	0	20	5
A	crawlFailed()	0	6	1
A	mixedContentFound()	0	3	1
A	noMixedContentFound()	0	3	1
A	getMixedContentFromLinkedCss()	0	14	3
A	withLinkedCss()	0	6	1

<?php

namespace Spatie\MixedContentScanner;

use GuzzleHttp\Exception\RequestException;
use Psr\Http\Message\ResponseInterface;
use Psr\Http\Message\UriInterface;
use Spatie\Crawler\CrawlObserver;

class MixedContentObserver extends CrawlObserver
{
    private $crawledCss = [];

    private $shouldExtractLinkedCss = false;

    public function crawled(UriInterface $url, ResponseInterface $response, ?UriInterface $foundOnUrl = null)
    {
        [$mixedContent, $linkedCss] = MixedContentExtractor::extract((string) $response->getBody(), $url);

The variable $mixedContent seems only to be defined at a later point. Did you maybe move this code here without moving the variable definition?

The variable $linkedCss does not exist. Did you forget to declare it?

        if ($this->shouldExtractLinkedCss) {
            foreach ($linkedCss as $css) {
                $mixedContent = array_merge($mixedContent, $this->getMixedContentFromLinkedCss($css, $url));

The variable $mixedContent does not seem to be defined for all execution paths leading up to this point.

            }
        }

        if (! count($mixedContent)) {
            $this->noMixedContentFound($url);

            return;
        }

        foreach ($mixedContent as $mixedContentItem) {
            $this->mixedContentFound($mixedContentItem);
        }
    }

    public function crawlFailed(
        UriInterface $url,
        RequestException $requestException,
        ?UriInterface $foundOnUrl = null
    ) {
    }

    /**
     * Will be called when mixed content was found.
     *
     * @param \Spatie\MixedContentScanner\MixedContent $mixedContent
     */
    public function mixedContentFound(MixedContent $mixedContent)

The parameter $mixedContent is not used and could be removed.

    {
    }

    /**
     * Will be called when no mixed content was found on the given url.
     *
     * @param \Psr\Http\Message\UriInterface
     */
    public function noMixedContentFound(UriInterface $crawledUrl)

The parameter $crawledUrl is not used and could be removed.

    {
    }

    public function getMixedContentFromLinkedCss(UriInterface $css, UriInterface $linkedByUrl)
    {
        if (! in_array($css, $this->crawledCss)) {
            $this->crawledCss[] = $css;
            try {

                return MixedContentLinkedCssExtractor::extract(Body::get($css), $css, $linkedByUrl);
            } catch (RequestException $e) {
                $this->crawlFailed($css, $e, $linkedByUrl);
            }
        }

        return [];
    }

    public function withLinkedCss()
    {
        $this->shouldExtractLinkedCss = true;

        return $this;
    }
}