HasTextAttributes - Code Metrics - Inspection of "Added the ability to append and prepend text on li..." - spatie/menu - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#44)

unknown

created 2017-08-26 17:55 UTC

HasTextAttributes A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	66
Duplicated Lines	0 %

Coupling/Cohesion

Components	2
Dependencies	0

Importance

Changes

Metric	Value
wmc	6
lcom	2
cbo	0
dl	0
loc	66
rs	10
c	0
b	0
f	0

4 Methods

Rating	Name	Size	Complexity
A	prepend()	6	1
A	prependIf()	8	2
A	append()	6	1
A	appendIf()	8	2

<?php


namespace Spatie\Menu\Traits;

trait HasTextAttributes
{
    /**
     * Prepend the anchor with a string of html on render.
     *
     * @param string $prepend
     *
     * @return $this
     */
    public function prepend(string $prepend)
    {
        $this->prepend = $prepend;
class MyClass { }

$x = new MyClass();
$x->foo = true;

        return $this;
    }

    /**
     * Prepend the text with a string of html on render if a certain condition is
     * met.
     *
     * @param bool   $condition
     * @param string $prepend
     *
     * @return $this
     */
    public function prependIf($condition, string $prepend)
    {
        if ($this->resolveCondition($condition)) {
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            return $this->prepend($prepend);
        }

        return $this;
    }

    /**
     * Append a text of html to the menu on render.
     *
     * @param string $append
     *
     * @return $this
     */
    public function append(string $append)
    {
        $this->append = $append;
class MyClass { }

$x = new MyClass();
$x->foo = true;

        return $this;
    }

    /**
     * Append the text with a string of html on render if a certain condition is
     * met.
     *
     * @param bool   $condition
     * @param string $append
     *
     * @return static
     */
    public function appendIf($condition, string $append)
    {
        if ($this->resolveCondition($condition)) {
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            return $this->append($append);
        }

        return $this;
    }
}

1			<?php
2
3
4			namespace Spatie\Menu\Traits;
5
6			trait HasTextAttributes
7			{
8			/**
9			* Prepend the anchor with a string of html on render.
10			*
11			* @param string $prepend
12			*
13			* @return $this
14			*/
15			public function prepend(string $prepend)
16			{
17			$this->prepend = $prepend;
			0 ignored issues – show Bug introduced 2017-08-26 17:57 UTC by Report Bug Copy Issue Report The property `prepend` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
18
19			return $this;
20			}
21
22			/**
23			* Prepend the text with a string of html on render if a certain condition is
24			* met.
25			*
26			* @param bool $condition
27			* @param string $prepend
28			*
29			* @return $this
30			*/
31			public function prependIf($condition, string $prepend)
32			{
33			if ($this->resolveCondition($condition)) {
			0 ignored issues – show Bug introduced 2017-08-26 17:57 UTC by Report Bug Copy Issue Report It seems like `resolveCondition()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
34			return $this->prepend($prepend);
35			}
36
37			return $this;
38			}
39
40			/**
41			* Append a text of html to the menu on render.
42			*
43			* @param string $append
44			*
45			* @return $this
46			*/
47			public function append(string $append)
48			{
49			$this->append = $append;
			0 ignored issues – show Bug introduced 2017-08-26 17:57 UTC by Report Bug Copy Issue Report The property `append` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
50
51			return $this;
52			}
53
54			/**
55			* Append the text with a string of html on render if a certain condition is
56			* met.
57			*
58			* @param bool $condition
59			* @param string $append
60			*
61			* @return static
62			*/
63			public function appendIf($condition, string $append)
64			{
65			if ($this->resolveCondition($condition)) {
			0 ignored issues – show Bug introduced 2017-08-26 17:57 UTC by Report Bug Copy Issue Report It seems like `resolveCondition()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
66			return $this->append($append);
67			}
68
69			return $this;
70			}
71			}

spatie / menu

GitHub Access Token became invalid

Pull Request — master (#44)

HasTextAttributes A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

4 Methods

Duplication Side-by-Side

Filter issues like