WelcomeNotification::buildWelcomeNotificationMessage() - Code Metrics - Inspection of "replace token based links with signed links" - spatie/laravel-welcome-notification - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( e68406...5eb45b )

by Freek

created 2019-11-14 19:40 UTC

buildWelcomeNotificationMessage() A

↳ Parent: WelcomeNotification

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	8
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	0

<?php

namespace Spatie\WelcomeNotification;

use Carbon\Carbon;
use Illuminate\Foundation\Auth\User;
use Illuminate\Notifications\Messages\MailMessage;
use Illuminate\Notifications\Notification;
use Illuminate\Support\Facades\Lang;
use Illuminate\Support\Facades\Password;
use Illuminate\Support\Facades\URL;

class WelcomeNotification extends Notification
{
    /** @var \Illuminate\Foundation\Auth\User */
    public $user;

    /** @var string */
    public $showWelcomeFormUrl;

    /** @var \Closure|null */
    public static $toMailCallback;

    /** @var \Carbon\Carbon */
    public $validUntil;

    public function __construct(Carbon $validUntil)
    {
        $this->validUntil = $validUntil;
    }

    public function via($notifiable)

    {
        return ['mail'];
    }

    public function toMail($notifiable)
    {
        $this->initializeNotificationProperties($notifiable);

        if (static::$toMailCallback) {
            return call_user_func(static::$toMailCallback, $notifiable, $this->token);
class MyClass { }

$x = new MyClass();
$x->foo = true;
        }

        return $this->buildWelcomeNotificationMessage();
    }

    protected function buildWelcomeNotificationMessage(): MailMessage
    {
        return (new MailMessage)
            ->subject(Lang::get('Welcome'))
            ->line(Lang::get('You are receiving this email an account for you was created.'))
            ->action(Lang::get('Set initial password'), $this->showWelcomeFormUrl)
            ->line(Lang::get('This welcome link will expire in :count minutes.', ['count' => config('auth.passwords.'.config('auth.defaults.passwords').'.expire')]));
    }

    public static function toMailUsing($callback)
    {
        static::$toMailCallback = $callback;
    }

    protected function initializeNotificationProperties(User $user)
    {
        $this->user = $user;

        $this->user->welcome_valid_until = $this->validUntil;
        $this->user->save();

        $this->showWelcomeFormUrl = URL::temporarySignedRoute(
            'welcome', $this->validUntil, ['user' => $user->id]
        );
    }
}


1			<?php
2
3			namespace Spatie\WelcomeNotification;
4
5			use Carbon\Carbon;
6			use Illuminate\Foundation\Auth\User;
7			use Illuminate\Notifications\Messages\MailMessage;
8			use Illuminate\Notifications\Notification;
9			use Illuminate\Support\Facades\Lang;
10			use Illuminate\Support\Facades\Password;
11			use Illuminate\Support\Facades\URL;
12
13			class WelcomeNotification extends Notification
14			{
15			/** @var \Illuminate\Foundation\Auth\User */
16			public $user;
17
18			/** @var string */
19			public $showWelcomeFormUrl;
20
21			/** @var \Closure\|null */
22			public static $toMailCallback;
23
24			/** @var \Carbon\Carbon */
25			public $validUntil;
26
27			public function __construct(Carbon $validUntil)
28			{
29			$this->validUntil = $validUntil;
30			}
31
32			public function via($notifiable)
			0 ignored issues – show Unused Code introduced 2019-11-14 19:47 UTC by Report Bug Copy Issue Report The parameter `$notifiable` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
33			{
34			return ['mail'];
35			}
36
37			public function toMail($notifiable)
38			{
39			$this->initializeNotificationProperties($notifiable);
40
41			if (static::$toMailCallback) {
42			return call_user_func(static::$toMailCallback, $notifiable, $this->token);
			0 ignored issues – show Bug introduced 2019-11-14 19:47 UTC by Report Bug Copy Issue Report The property `token` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
43			}
44
45			return $this->buildWelcomeNotificationMessage();
46			}
47
48			protected function buildWelcomeNotificationMessage(): MailMessage
49			{
50			return (new MailMessage)
51			->subject(Lang::get('Welcome'))
52			->line(Lang::get('You are receiving this email an account for you was created.'))
53			->action(Lang::get('Set initial password'), $this->showWelcomeFormUrl)
54			->line(Lang::get('This welcome link will expire in :count minutes.', ['count' => config('auth.passwords.'.config('auth.defaults.passwords').'.expire')]));
55			}
56
57			public static function toMailUsing($callback)
58			{
59			static::$toMailCallback = $callback;
60			}
61
62			protected function initializeNotificationProperties(User $user)
63			{
64			$this->user = $user;
65
66			$this->user->welcome_valid_until = $this->validUntil;
67			$this->user->save();
68
69			$this->showWelcomeFormUrl = URL::temporarySignedRoute(
70			'welcome', $this->validUntil, ['user' => $user->id]
71			);
72			}
73			}
74

spatie / laravel-welcome-notification

GitHub Access Token became invalid

Push — master ( e68406...5eb45b )

buildWelcomeNotificationMessage() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like