ViewModelMakeCommand::handle() - Code Metrics - Inspection of "Merge pull request #5 from ijpatricio/dev-artisan-..." - spatie/laravel-view-models - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 90fee7...b987a2 )

by Freek

created 2018-09-26 06:11 UTC

ViewModelMakeCommand::handle() A

↳ Parent: ViewModelMakeCommand

Complexity

Conditions	3
Paths	3

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	8
rs	10
c	0
b	0
f	0
cc	3
nc	3
nop	0

<?php

namespace Spatie\ViewModels\Console;

use Illuminate\Support\Str;
use Illuminate\Console\GeneratorCommand;
use Symfony\Component\Console\Input\InputOption;

class ViewModelMakeCommand extends GeneratorCommand
{
    protected $name = 'make:view-model';

    protected $description = 'Create a new ViewModel class';

    protected $type = 'ViewModel';

    public function handle()
    {
        if (parent::handle() === false) {
            if (! $this->option('force')) {
                return;
            }
        }
    }

    protected function getStub()
    {
        return __DIR__.'/../../stubs/DummyViewModel.stub';
    }

    protected function getDefaultNamespace($rootNamespace)
    {
        if ($this->isCustomNamespace()) {
            return $rootNamespace;
        }

        return $rootNamespace.'\ViewModels';
    }

    protected function getOptions(): array
    {
        return [
            ['force', null, InputOption::VALUE_NONE, 'Create the class even if the view-model already exists'],
        ];
    }

    protected function isCustomNamespace(): bool
    {
        return Str::contains($this->argument('name'), '/');

    }
}


1			<?php
2
3			namespace Spatie\ViewModels\Console;
4
5			use Illuminate\Support\Str;
6			use Illuminate\Console\GeneratorCommand;
7			use Symfony\Component\Console\Input\InputOption;
8
9			class ViewModelMakeCommand extends GeneratorCommand
10			{
11			protected $name = 'make:view-model';
12
13			protected $description = 'Create a new ViewModel class';
14
15			protected $type = 'ViewModel';
16
17			public function handle()
18			{
19			if (parent::handle() === false) {
20			if (! $this->option('force')) {
21			return;
22			}
23			}
24			}
25
26			protected function getStub()
27			{
28			return __DIR__.'/../../stubs/DummyViewModel.stub';
29			}
30
31			protected function getDefaultNamespace($rootNamespace)
32			{
33			if ($this->isCustomNamespace()) {
34			return $rootNamespace;
35			}
36
37			return $rootNamespace.'\ViewModels';
38			}
39
40			protected function getOptions(): array
41			{
42			return [
43			['force', null, InputOption::VALUE_NONE, 'Create the class even if the view-model already exists'],
44			];
45			}
46
47			protected function isCustomNamespace(): bool
48			{
49			return Str::contains($this->argument('name'), '/');
			0 ignored issues – show Bug introduced 2018-09-25 11:16 UTC by Report Bug Copy Issue Report It seems like `$this->argument('name')` targeting `Illuminate\Console\Command::argument()` can also be of type `array` or `null`; however, `Illuminate\Support\Str::contains()` does only seem to accept `string`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
50			}
51			}
52

spatie / laravel-view-models

Push — master ( 90fee7...b987a2 )

ViewModelMakeCommand::handle() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like