ViewComponentsServiceProvider::register() - Code Metrics - spatie/laravel-view-components - Measure and Improve Code Quality continuously with Scrutinizer

ViewComponentsServiceProvider::register() A
last analyzed 2020-03-24 08:47 UTC

↳ Parent: ViewComponentsServiceProvider

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	11
rs	9.9
c	0
b	0
f	0
cc	1
nc	1
nop	0

<?php

namespace Spatie\ViewComponents;

use Illuminate\Support\ServiceProvider;
use Illuminate\View\Compilers\BladeCompiler;

class ViewComponentsServiceProvider extends ServiceProvider
{
    public function boot()
    {
        $this->publishes([
            __DIR__.'/../config/view-components.php' => config_path('view-components.php'),
        ], 'config');

        $this->callAfterResolving('blade.compiler', function (BladeCompiler $bladeCompiler) {
            $bladeCompiler->directive('render', $this->app->make(CompileRenderDirective::class));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        });
    }

    public function register()
    {
        $this->mergeConfigFrom(__DIR__.'/../config/view-components.php', 'view-components');

        $this->app->singleton(ComponentFinder::class, function () {
            return new ComponentFinder(
                $this->app->config->get('view-components.root_namespace'),
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
                $this->app->config->get('view-components.namespaces')
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
            );
        });
    }
}


ViewComponentsServiceProvider::register() A
last analyzed 2020-03-24 08:47 UTC

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

1			<?php
2
3			namespace Spatie\ViewComponents;
4
5			use Illuminate\Support\ServiceProvider;
6			use Illuminate\View\Compilers\BladeCompiler;
7
8			class ViewComponentsServiceProvider extends ServiceProvider
9			{
10			public function boot()
11			{
12			$this->publishes([
13			__DIR__.'/../config/view-components.php' => config_path('view-components.php'),
14			], 'config');
15
16			$this->callAfterResolving('blade.compiler', function (BladeCompiler $bladeCompiler) {
17			$bladeCompiler->directive('render', $this->app->make(CompileRenderDirective::class));
			0 ignored issues – show Documentation introduced 2020-02-04 11:43 UTC by Report Bug Copy Issue Report `$this->app->make(\Spatie...RenderDirective::class)` is of type `*`, but the function expects a `callable`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
18			});
19			}
20
21			public function register()
22			{
23			$this->mergeConfigFrom(__DIR__.'/../config/view-components.php', 'view-components');
24
25			$this->app->singleton(ComponentFinder::class, function () {
26			return new ComponentFinder(
27			$this->app->config->get('view-components.root_namespace'),
			0 ignored issues – show Bug introduced 2018-05-24 07:49 UTC by Report Bug Copy Issue Report Accessing `config` on the interface `Illuminate\Contracts\Foundation\Application` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
28			$this->app->config->get('view-components.namespaces')
			0 ignored issues – show Bug introduced 2018-05-24 07:49 UTC by Report Bug Copy Issue Report Accessing `config` on the interface `Illuminate\Contracts\Foundation\Application` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
29			);
30			});
31			}
32			}
33

spatie / laravel-view-components

ViewComponentsServiceProvider::register() A last analyzed 2020-03-24 08:47 UTC

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like

ViewComponentsServiceProvider::register() A
last analyzed 2020-03-24 08:47 UTC