CountryCode::passes() - Code Metrics - spatie/laravel-validation-rules - Measure and Improve Code Quality continuously with Scrutinizer

CountryCode::passes() A
last analyzed 2020-09-01 17:57 UTC

↳ Parent: CountryCode

Complexity

Conditions	5
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	5
CRAP Score	5

Importance

Changes

Metric	Value
dl	0
loc	12
ccs	5
cts	5
cp	1
rs	9.5555
c	0
b	0
f	0
cc	5
nc	2
nop	2
crap	5

<?php

namespace Spatie\ValidationRules\Rules;

use Illuminate\Contracts\Validation\Rule;
use Illuminate\Support\Arr;
use League\ISO3166\ISO3166;

class CountryCode implements Rule
{
    /** @var bool */
    protected $required;

    /** @var string */
    protected $attribute;

    public function __construct(bool $required = true)
    {
        $this->required = $required;
    }

    public function nullable(): self
    {
        $this->required = false;

        return $this;
    }

    public function passes($attribute, $value): bool
    {
        $this->attribute = $attribute;

        if (! $this->required && ($value === '0' || $value === 0 || $value === null)) {
            return true;
        }

        $countries = Arr::pluck((new ISO3166())->all(), ISO3166::KEY_ALPHA2);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        return in_array($value, $countries, true);
    }

    public function message(): string
    {
        return __('validationRules::messages.country_code', [
            'attribute' => $this->attribute,
        ]);
    }
}


1		<?php
2
3		namespace Spatie\ValidationRules\Rules;
4
5		use Illuminate\Contracts\Validation\Rule;
6		use Illuminate\Support\Arr;
7		use League\ISO3166\ISO3166;
8
9		class CountryCode implements Rule
10		{
11		/** @var bool */
12		protected $required;
13
14		/** @var string */
15		protected $attribute;
16	24
17		public function __construct(bool $required = true)
18	24	{
19	24	$this->required = $required;
20		}
21	6
22		public function nullable(): self
23	6	{
24		$this->required = false;
25	6
26		return $this;
27		}
28	24
29		public function passes($attribute, $value): bool
30	24	{
31		$this->attribute = $attribute;
32	24
33	6	if (! $this->required && ($value === '0' \|\| $value === 0 \|\| $value === null)) {
34		return true;
35		}
36	24
37		$countries = Arr::pluck((new ISO3166())->all(), ISO3166::KEY_ALPHA2);
		0 ignored issues – show Documentation introduced 2020-03-02 22:02 UTC by Report Bug Copy Issue Report `(new \League\ISO3166\ISO3166())->all()` is of type `array<integer,array>`, but the function expects a `object<Illuminate\Support\iterable>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
38	24
39		return in_array($value, $countries, true);
40		}
41	12
42		public function message(): string
43	12	{
44	12	return __('validationRules::messages.country_code', [
45		'attribute' => $this->attribute,
46		]);
47		}
48		}
49

spatie / laravel-validation-rules

CountryCode::passes() A last analyzed 2020-09-01 17:57 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like

CountryCode::passes() A
last analyzed 2020-09-01 17:57 UTC