SslExpiresSoon::toMail() - Code Metrics - Inspection of "nitpicks" - spatie/laravel-uptime-monitor - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 500180...9c512e )

by Freek

created 2016-11-17 01:50 UTC

SslExpiresSoon::toMail() A

↳ Parent: SslExpiresSoon

Complexity

Conditions	2
Paths	2

Size

Total Lines	13
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	13
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	8
nc	2
nop	1

<?php

namespace Spatie\UptimeMonitor\Notifications\Notifications;

use Illuminate\Notifications\Messages\MailMessage;
use Illuminate\Notifications\Messages\SlackAttachment;
use Illuminate\Notifications\Messages\SlackMessage;
use Spatie\UptimeMonitor\Events\SslExpiresSoon as SoonExpiringSslCertificateFoundEvent;
use Spatie\UptimeMonitor\Notifications\BaseNotification;

class SslExpiresSoon extends BaseNotification
{
    /** @var \Spatie\UptimeMonitor\Events\SslExpiresSoon */
    public $event;

    /**
     * Get the mail representation of the notification.
     *
     * @param  mixed $notifiable
     * @return \Illuminate\Notifications\Messages\MailMessage
     */
    public function toMail($notifiable)

    {
        $mailMessage = (new MailMessage)
            ->error()
            ->subject($this->getMessageText())
            ->line($this->getMessageText());

        foreach($this->getMonitorProperties() as $name => $value) {
            $mailMessage->line($name . ': ' . $value);
        }

        return $mailMessage;
    }

    public function toSlack($notifiable)

    {
        return (new SlackMessage)
            ->error()
            ->content($this->getMessageText())
            ->attachment(function (SlackAttachment $attachment) {
                $attachment->fields($this->getMonitorProperties());
            });
    }

    protected function getMessageText(): string
    {
        return "The certificate for {$this->event->monitor->url} will expire in {$this->ssl_certificate_expiration_date->diffInDays()} days.";
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }

    public function setEvent(SoonExpiringSslCertificateFoundEvent $event)
    {
        $this->event = $event;

        return $this;
    }
}


1			<?php
2
3			namespace Spatie\UptimeMonitor\Notifications\Notifications;
4
5			use Illuminate\Notifications\Messages\MailMessage;
6			use Illuminate\Notifications\Messages\SlackAttachment;
7			use Illuminate\Notifications\Messages\SlackMessage;
8			use Spatie\UptimeMonitor\Events\SslExpiresSoon as SoonExpiringSslCertificateFoundEvent;
9			use Spatie\UptimeMonitor\Notifications\BaseNotification;
10
11			class SslExpiresSoon extends BaseNotification
12			{
13			/** @var \Spatie\UptimeMonitor\Events\SslExpiresSoon */
14			public $event;
15
16			/**
17			* Get the mail representation of the notification.
18			*
19			* @param mixed $notifiable
20			* @return \Illuminate\Notifications\Messages\MailMessage
21			*/
22			public function toMail($notifiable)
			0 ignored issues – show Unused Code introduced 2016-11-12 22:10 UTC by Report Bug Copy Issue Report The parameter `$notifiable` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
23			{
24			$mailMessage = (new MailMessage)
25			->error()
26			->subject($this->getMessageText())
27			->line($this->getMessageText());
28
29			foreach($this->getMonitorProperties() as $name => $value) {
30			$mailMessage->line($name . ': ' . $value);
31			}
32
33			return $mailMessage;
34			}
35
36			public function toSlack($notifiable)
			0 ignored issues – show Unused Code introduced 2016-11-12 22:10 UTC by Report Bug Copy Issue Report The parameter `$notifiable` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
37			{
38			return (new SlackMessage)
39			->error()
40			->content($this->getMessageText())
41			->attachment(function (SlackAttachment $attachment) {
42			$attachment->fields($this->getMonitorProperties());
43			});
44			}
45
46			protected function getMessageText(): string
47			{
48			return "The certificate for {$this->event->monitor->url} will expire in {$this->ssl_certificate_expiration_date->diffInDays()} days.";
			0 ignored issues – show Bug introduced 2016-11-12 22:10 UTC by Report Bug Copy Issue Report The property `ssl_certificate_expiration_date` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
49			}
50
51			public function setEvent(SoonExpiringSslCertificateFoundEvent $event)
52			{
53			$this->event = $event;
54
55			return $this;
56			}
57			}
58

spatie / laravel-uptime-monitor

GitHub Access Token became invalid

Push — master ( 500180...9c512e )

SslExpiresSoon::toMail() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like