Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
13 | class UptimeCheckFailed extends BaseNotification |
||
14 | { |
||
15 | public MonitorFailedEvent $event; |
||
|
|||
16 | |||
17 | /** |
||
18 | * Get the mail representation of the notification. |
||
19 | * |
||
20 | * @param mixed $notifiable |
||
21 | * @return \Illuminate\Notifications\Messages\MailMessage |
||
22 | */ |
||
23 | public function toMail($notifiable) |
||
24 | { |
||
25 | $mailMessage = (new MailMessage) |
||
26 | ->error() |
||
27 | ->subject($this->getMessageText()) |
||
28 | ->line($this->getMessageText()) |
||
29 | ->line($this->getLocationDescription()); |
||
30 | |||
31 | foreach ($this->getMonitorProperties() as $name => $value) { |
||
32 | $mailMessage->line($name.': '.$value); |
||
33 | } |
||
34 | |||
35 | return $mailMessage; |
||
36 | } |
||
37 | |||
38 | public function toSlack($notifiable) |
||
39 | { |
||
40 | return (new SlackMessage) |
||
41 | ->error() |
||
42 | ->attachment(function (SlackAttachment $attachment) { |
||
43 | $attachment |
||
44 | ->title($this->getMessageText()) |
||
45 | ->content($this->getMonitor()->uptime_check_failure_reason) |
||
46 | ->fallback($this->getMessageText()) |
||
47 | ->footer($this->getLocationDescription()) |
||
48 | ->timestamp(Carbon::now()); |
||
49 | }); |
||
50 | } |
||
51 | |||
52 | public function getMonitorProperties($extraProperties = []): array |
||
53 | { |
||
54 | $since = "Since {$this->event->downtimePeriod->startDateTime->format('H:i')}"; |
||
55 | $date = $this->event->monitor->formattedLastUpdatedStatusChangeDate(); |
||
56 | |||
57 | $extraProperties = [ |
||
58 | $since => $date, |
||
59 | 'Failure reason' => $this->getMonitor()->uptime_check_failure_reason, |
||
60 | ]; |
||
61 | |||
62 | return parent::getMonitorProperties($extraProperties); |
||
63 | } |
||
64 | |||
65 | public function isStillRelevant(): bool |
||
66 | { |
||
67 | return $this->getMonitor()->uptime_status == UptimeStatus::DOWN; |
||
68 | } |
||
69 | |||
70 | public function setEvent(MonitorFailedEvent $event): self |
||
71 | { |
||
72 | $this->event = $event; |
||
73 | |||
74 | return $this; |
||
75 | } |
||
76 | |||
77 | protected function getMessageText(): string |
||
78 | { |
||
79 | return "{$this->getMonitor()->url} seems down"; |
||
80 | } |
||
81 | } |
||
82 |