MonitorSucceeded::toSlack() - Code Metrics - Inspection of "rename notifications and events" - spatie/laravel-uptime-monitor - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( b85ce8...d97b27 )

by Freek

created 2016-11-16 14:02 UTC

MonitorSucceeded::toSlack() A

↳ Parent: MonitorSucceeded

Complexity

Conditions	1
Paths	1

Size

Total Lines	9
Code Lines	6

Duplication

Lines	9
Ratio	100 %

Importance

Changes

Metric	Value
dl	9
loc	9
rs	9.6666
c	0
b	0
f	0
cc	1
eloc	6
nc	1
nop	1

<?php

namespace Spatie\UptimeMonitor\Notifications\Notifications;

use Illuminate\Notifications\Messages\MailMessage;
use Illuminate\Notifications\Messages\SlackAttachment;
use Illuminate\Notifications\Messages\SlackMessage;
use Spatie\UptimeMonitor\Events\MonitorSucceeded as MonitorSucceededEvent;
use Spatie\UptimeMonitor\Models\Enums\UptimeStatus;
use Spatie\UptimeMonitor\Notifications\BaseNotification;

class MonitorSucceeded extends BaseNotification
{
    /** @var \Spatie\UptimeMonitor\Events\MonitorSucceeded */
    public $event;

    /**
     * Get the mail representation of the notification.
     *
     * @param  mixed $notifiable
     * @return \Illuminate\Notifications\Messages\MailMessage
     */
    public function toMail($notifiable)

    {
        $mailMessage = (new MailMessage)
            ->success()
            ->subject("Site {$this->event->monitor->url} is up.")
            ->line('Site is up');

        return $mailMessage;
    }

    public function toSlack($notifiable)

    {
        return (new SlackMessage)
            ->success()
            ->content("Site {$this->event->monitor->url} is up")
            ->attachment(function (SlackAttachment $attachment) {
                $attachment->fields($this->getMonitorProperties());
            });
    }

    public function isStillRelevant(): bool
    {
        return $this->event->monitor->uptime_status != UptimeStatus::DOWN;
    }

    public function setEvent(MonitorSucceededEvent $event)
    {
        $this->event = $event;

        return $this;
    }
}


1		<?php
2
3		namespace Spatie\UptimeMonitor\Notifications\Notifications;
4
5		use Illuminate\Notifications\Messages\MailMessage;
6		use Illuminate\Notifications\Messages\SlackAttachment;
7		use Illuminate\Notifications\Messages\SlackMessage;
8		use Spatie\UptimeMonitor\Events\MonitorSucceeded as MonitorSucceededEvent;
9		use Spatie\UptimeMonitor\Models\Enums\UptimeStatus;
10		use Spatie\UptimeMonitor\Notifications\BaseNotification;
11
12		class MonitorSucceeded extends BaseNotification
13		{
14		/** @var \Spatie\UptimeMonitor\Events\MonitorSucceeded */
15		public $event;
16
17		/**
18		* Get the mail representation of the notification.
19		*
20		* @param mixed $notifiable
21		* @return \Illuminate\Notifications\Messages\MailMessage
22		*/
23		public function toMail($notifiable)
		0 ignored issues – show Unused Code introduced 2016-09-20 05:47 UTC by Report Bug Copy Issue Report The parameter `$notifiable` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
24		{
25		$mailMessage = (new MailMessage)
26		->success()
27		->subject("Site {$this->event->monitor->url} is up.")
28		->line('Site is up');
29
30		return $mailMessage;
31		}
32
33	View Code Duplication	public function toSlack($notifiable)
		0 ignored issues – show Unused Code introduced 2016-09-20 05:47 UTC by Report Bug Copy Issue Report The parameter `$notifiable` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Duplication introduced 2016-11-16 13:30 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
34		{
35		return (new SlackMessage)
36		->success()
37		->content("Site {$this->event->monitor->url} is up")
38		->attachment(function (SlackAttachment $attachment) {
39		$attachment->fields($this->getMonitorProperties());
40		});
41		}
42
43		public function isStillRelevant(): bool
44		{
45		return $this->event->monitor->uptime_status != UptimeStatus::DOWN;
46		}
47
48		public function setEvent(MonitorSucceededEvent $event)
49		{
50		$this->event = $event;
51
52		return $this;
53		}
54		}
55

spatie / laravel-uptime-monitor

GitHub Access Token became invalid

Push — master ( b85ce8...d97b27 )

MonitorSucceeded::toSlack() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like