Issues in SupportsUptimeCheck.php - All Issues - Inspection of "set fallback text for slack attachments" - spatie/laravel-uptime-monitor - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 2fe938...e8e1b6 )

by Freek

created 2017-01-06 15:16 UTC

src/Models/Traits/SupportsUptimeCheck.php (13 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Spatie\UptimeMonitor\Models\Traits;

use Carbon\Carbon;
use Psr\Http\Message\ResponseInterface;
use Spatie\UptimeMonitor\Helpers\Period;
use Spatie\UptimeMonitor\Models\Monitor;
use Spatie\UptimeMonitor\Events\UptimeCheckFailed;
use Spatie\UptimeMonitor\Models\Enums\UptimeStatus;
use Spatie\UptimeMonitor\Events\UptimeCheckRecovered;
use Spatie\UptimeMonitor\Events\UptimeCheckSucceeded;
use Spatie\UptimeMonitor\Helpers\UptimeResponseCheckers\UptimeResponseChecker;

trait SupportsUptimeCheck
{
    public static function bootSupportsUptimeCheck()
    {
        static::saving(function (Monitor $monitor) {
            if (is_null($monitor->uptime_status_last_change_date)) {
                $monitor->uptime_status_last_change_date = Carbon::now();

                return;
            }

            if ($monitor->getOriginal('uptime_status') != $monitor->uptime_status) {
                $monitor->uptime_status_last_change_date = Carbon::now();
            }
        });
    }

    public function shouldCheckUptime() : bool
    {
        if (! $this->uptime_check_enabled) {
class MyClass { }

$x = new MyClass();
$x->foo = true;
            return false;
        }

        if ($this->uptime_status == UptimeStatus::NOT_YET_CHECKED) {
class MyClass { }

$x = new MyClass();
$x->foo = true;
            return true;
        }

        if ($this->uptime_status == UptimeStatus::DOWN) {
            return true;
        }

        if (is_null($this->uptime_last_check_date)) {
class MyClass { }

$x = new MyClass();
$x->foo = true;
            return true;
        }

        return $this->uptime_last_check_date->diffInMinutes() >= $this->uptime_check_interval_in_minutes;
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }

    public function uptimeRequestSucceeded(ResponseInterface $response)
    {
        $uptimeResponseChecker = app(UptimeResponseChecker::class);

        if (! $uptimeResponseChecker->isValidResponse($response, $this)) {
            $this->uptimeCheckFailed($uptimeResponseChecker->getFailureReason($response, $this));

            return;
        }

        $this->uptimeCheckSucceeded();
    }

    public function uptimeRequestFailed(string $reason)
    {
        $this->uptimeCheckFailed($reason);
    }

    public function uptimeCheckSucceeded()
    {
        $this->uptime_status = UptimeStatus::UP;
        $this->uptime_check_failure_reason = '';
class MyClass { }

$x = new MyClass();
$x->foo = true;

        $wasFailing = ! is_null($this->uptime_check_failed_event_fired_on_date);
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $lastStatusChangeDate = $this->uptime_status_last_change_date ? clone $this->uptime_status_last_change_date : null;


        $this->uptime_check_times_failed_in_a_row = 0;
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->uptime_last_check_date = Carbon::now();
        $this->uptime_check_failed_event_fired_on_date = null;
        $this->save();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

        if ($wasFailing) {
            $downtimePeriod = new Period($lastStatusChangeDate, $this->uptime_last_check_date);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

            event(new UptimeCheckRecovered($this, $downtimePeriod));

            return;
        }

        event(new UptimeCheckSucceeded($this));
    }

    public function uptimeCheckFailed(string $reason)
    {
        $this->uptime_status = UptimeStatus::DOWN;
        $this->uptime_check_times_failed_in_a_row++;
        $this->uptime_last_check_date = Carbon::now();
        $this->uptime_check_failure_reason = $reason;
        $this->save();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

        if ($this->shouldFireUptimeCheckFailedEvent()) {
            $this->uptime_check_failed_event_fired_on_date = Carbon::now();
            $this->save();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

            $updatedMonitor = $this->fresh();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

            $downtimePeriod = new Period($updatedMonitor->uptime_status_last_change_date, $this->uptime_last_check_date);

            event(new UptimeCheckFailed($this, $downtimePeriod));
        }
    }

    protected function shouldFireUptimeCheckFailedEvent(): bool
    {
        if ($this->uptime_check_times_failed_in_a_row === config('laravel-uptime-monitor.uptime_check.fire_monitor_failed_event_after_consecutive_failures')) {
            return true;
        }

        if (is_null($this->uptime_check_failed_event_fired_on_date)) {
            return false;
        }

        if (config('laravel-uptime-monitor.notifications.resend_uptime_check_failed_notification_every_minutes') === 0) {
            return false;
        }

        if ($this->uptime_check_failed_event_fired_on_date->diffInMinutes() >= config('laravel-uptime-monitor.notifications.resend_uptime_check_failed_notification_every_minutes')) {
            return true;
        }

        return false;
    }
}


1			<?php
2
3			namespace Spatie\UptimeMonitor\Models\Traits;
4
5			use Carbon\Carbon;
6			use Psr\Http\Message\ResponseInterface;
7			use Spatie\UptimeMonitor\Helpers\Period;
8			use Spatie\UptimeMonitor\Models\Monitor;
9			use Spatie\UptimeMonitor\Events\UptimeCheckFailed;
10			use Spatie\UptimeMonitor\Models\Enums\UptimeStatus;
11			use Spatie\UptimeMonitor\Events\UptimeCheckRecovered;
12			use Spatie\UptimeMonitor\Events\UptimeCheckSucceeded;
13			use Spatie\UptimeMonitor\Helpers\UptimeResponseCheckers\UptimeResponseChecker;
14
15			trait SupportsUptimeCheck
16			{
17			public static function bootSupportsUptimeCheck()
18			{
19			static::saving(function (Monitor $monitor) {
20			if (is_null($monitor->uptime_status_last_change_date)) {
21			$monitor->uptime_status_last_change_date = Carbon::now();
22
23			return;
24			}
25
26			if ($monitor->getOriginal('uptime_status') != $monitor->uptime_status) {
27			$monitor->uptime_status_last_change_date = Carbon::now();
28			}
29			});
30			}
31
32			public function shouldCheckUptime() : bool
33			{
34			if (! $this->uptime_check_enabled) {
			0 ignored issues – show Bug introduced 2016-11-17 22:49 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `uptime_check_enabled` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
35			return false;
36			}
37
38			if ($this->uptime_status == UptimeStatus::NOT_YET_CHECKED) {
			0 ignored issues – show Bug introduced 2016-11-15 23:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `uptime_status` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
39			return true;
40			}
41
42			if ($this->uptime_status == UptimeStatus::DOWN) {
43			return true;
44			}
45
46			if (is_null($this->uptime_last_check_date)) {
			0 ignored issues – show Bug introduced 2016-11-15 23:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `uptime_last_check_date` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
47			return true;
48			}
49
50			return $this->uptime_last_check_date->diffInMinutes() >= $this->uptime_check_interval_in_minutes;
			0 ignored issues – show Bug introduced 2016-11-15 23:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `uptime_check_interval_in_minutes` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
51			}
52
53			public function uptimeRequestSucceeded(ResponseInterface $response)
54			{
55			$uptimeResponseChecker = app(UptimeResponseChecker::class);
56
57			if (! $uptimeResponseChecker->isValidResponse($response, $this)) {
58			$this->uptimeCheckFailed($uptimeResponseChecker->getFailureReason($response, $this));
59
60			return;
61			}
62
63			$this->uptimeCheckSucceeded();
64			}
65
66			public function uptimeRequestFailed(string $reason)
67			{
68			$this->uptimeCheckFailed($reason);
69			}
70
71			public function uptimeCheckSucceeded()
72			{
73			$this->uptime_status = UptimeStatus::UP;
74			$this->uptime_check_failure_reason = '';
			0 ignored issues – show Bug introduced 2016-11-18 04:03 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `uptime_check_failure_reason` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
75
76			$wasFailing = ! is_null($this->uptime_check_failed_event_fired_on_date);
			0 ignored issues – show Bug introduced 2016-11-18 04:05 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `uptime_check_failed_event_fired_on_date` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
77			$lastStatusChangeDate = $this->uptime_status_last_change_date ? clone $this->uptime_status_last_change_date : null;
			0 ignored issues – show Bug introduced 2016-11-18 18:22 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `uptime_status_last_change_date` does not seem to exist. Did you mean `uptime_status`? An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...
78
79			$this->uptime_check_times_failed_in_a_row = 0;
			0 ignored issues – show Bug introduced 2016-11-15 23:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `uptime_check_times_failed_in_a_row` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
80			$this->uptime_last_check_date = Carbon::now();
81			$this->uptime_check_failed_event_fired_on_date = null;
82			$this->save();
			0 ignored issues – show Bug introduced 2016-11-15 23:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `save()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
83
84			if ($wasFailing) {
85			$downtimePeriod = new Period($lastStatusChangeDate, $this->uptime_last_check_date);
			0 ignored issues – show Documentation introduced 2016-11-21 21:39 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$lastStatusChangeDate` is of type `object\|null`, but the function expects a `object<Carbon\Carbon>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
86
87			event(new UptimeCheckRecovered($this, $downtimePeriod));
88
89			return;
90			}
91
92			event(new UptimeCheckSucceeded($this));
93			}
94
95			public function uptimeCheckFailed(string $reason)
96			{
97			$this->uptime_status = UptimeStatus::DOWN;
98			$this->uptime_check_times_failed_in_a_row++;
99			$this->uptime_last_check_date = Carbon::now();
100			$this->uptime_check_failure_reason = $reason;
101			$this->save();
			0 ignored issues – show Bug introduced 2016-11-15 23:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `save()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
102
103			if ($this->shouldFireUptimeCheckFailedEvent()) {
104			$this->uptime_check_failed_event_fired_on_date = Carbon::now();
105			$this->save();
			0 ignored issues – show Bug introduced 2016-11-15 23:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `save()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
106
107			$updatedMonitor = $this->fresh();
			0 ignored issues – show Bug introduced 2016-11-22 08:46 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `fresh()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
108
109			$downtimePeriod = new Period($updatedMonitor->uptime_status_last_change_date, $this->uptime_last_check_date);
110
111			event(new UptimeCheckFailed($this, $downtimePeriod));
112			}
113			}
114
115			protected function shouldFireUptimeCheckFailedEvent(): bool
116			{
117			if ($this->uptime_check_times_failed_in_a_row === config('laravel-uptime-monitor.uptime_check.fire_monitor_failed_event_after_consecutive_failures')) {
118			return true;
119			}
120
121			if (is_null($this->uptime_check_failed_event_fired_on_date)) {
122			return false;
123			}
124
125			if (config('laravel-uptime-monitor.notifications.resend_uptime_check_failed_notification_every_minutes') === 0) {
126			return false;
127			}
128
129			if ($this->uptime_check_failed_event_fired_on_date->diffInMinutes() >= config('laravel-uptime-monitor.notifications.resend_uptime_check_failed_notification_every_minutes')) {
130			return true;
131			}
132
133			return false;
134			}
135			}
136

GitHub Access Token became invalid

Push — master ( 2fe938...e8e1b6 )

src/Models/Traits/SupportsUptimeCheck.php (13 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

spatie / laravel-uptime-monitor

GitHub Access Token became invalid

Push — master ( 2fe938...e8e1b6 )

src/Models/Traits/SupportsUptimeCheck.php (13 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like