Issues in MonitorPresenter.php - All Issues - Inspection of "set fallback text for slack attachments" - spatie/laravel-uptime-monitor - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 2fe938...e8e1b6 )

by Freek

created 2017-01-06 15:16 UTC

src/Models/Presenters/MonitorPresenter.php (4 issues)

Labels

Bug 4

Severity

Major 4

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Spatie\UptimeMonitor\Models\Presenters;

use Spatie\UptimeMonitor\Helpers\Emoji;
use Spatie\UptimeMonitor\Models\Enums\UptimeStatus;
use Spatie\UptimeMonitor\Models\Enums\CertificateStatus;

trait MonitorPresenter
{
    public function getUptimeStatusAsEmojiAttribute(): string
    {
        if ($this->uptime_status === UptimeStatus::UP) {
class MyClass { }

$x = new MyClass();
$x->foo = true;
            return Emoji::ok();
        }

        if ($this->uptime_status === UptimeStatus::DOWN) {
            return Emoji::notOk();
        }

        return '';
    }

    public function getCertificateStatusAsEmojiAttribute(): string
    {
        if ($this->certificate_status === CertificateStatus::VALID) {
class MyClass { }

$x = new MyClass();
$x->foo = true;
            return Emoji::ok();
        }

        if ($this->certificate_status === CertificateStatus::INVALID) {
            return Emoji::notOk();
        }

        return '';
    }

    public function formattedLastUpdatedStatusChangeDate(string $format = ''): string
    {
        return $this->formatDate('uptime_status_last_change_date', $format);
    }

    public function formattedCertificateExpirationDate(string $format = ''): string
    {
        return $this->formatDate('certificate_expiration_date', $format);
    }

    public function getChunkedLastFailureReasonAttribute(): string
    {
        if ($this->uptime_check_failure_reason == '') {
class MyClass { }

$x = new MyClass();
$x->foo = true;
            return '';
        }

        return chunk_split($this->uptime_check_failure_reason, 30, "\n");
    }

    public function getChunkedLastCertificateCheckFailureReasonAttribute(): string
    {
        if ($this->certificate_check_failure_reason == '') {
class MyClass { }

$x = new MyClass();
$x->foo = true;
            return '';
        }

        return chunk_split($this->certificate_check_failure_reason, 60, "\n");
    }

    protected function formatDate(string $attributeName, string $format = ''): string
    {
        if (! $this->$attributeName) {
            return '';
        }

        if ($format === 'forHumans') {
            return $this->$attributeName->diffForHumans();
        }

        if ($format === '') {
            $format = config('laravel-uptime-monitor.notifications.date_format');
        }

        return $this->$attributeName->format($format);
    }
}


1			<?php
2
3			namespace Spatie\UptimeMonitor\Models\Presenters;
4
5			use Spatie\UptimeMonitor\Helpers\Emoji;
6			use Spatie\UptimeMonitor\Models\Enums\UptimeStatus;
7			use Spatie\UptimeMonitor\Models\Enums\CertificateStatus;
8
9			trait MonitorPresenter
10			{
11			public function getUptimeStatusAsEmojiAttribute(): string
12			{
13			if ($this->uptime_status === UptimeStatus::UP) {
			0 ignored issues – show Bug introduced 2016-11-17 03:36 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `uptime_status` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
14			return Emoji::ok();
15			}
16
17			if ($this->uptime_status === UptimeStatus::DOWN) {
18			return Emoji::notOk();
19			}
20
21			return '';
22			}
23
24			public function getCertificateStatusAsEmojiAttribute(): string
25			{
26			if ($this->certificate_status === CertificateStatus::VALID) {
			0 ignored issues – show Bug introduced 2016-11-17 22:49 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `certificate_status` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
27			return Emoji::ok();
28			}
29
30			if ($this->certificate_status === CertificateStatus::INVALID) {
31			return Emoji::notOk();
32			}
33
34			return '';
35			}
36
37			public function formattedLastUpdatedStatusChangeDate(string $format = ''): string
38			{
39			return $this->formatDate('uptime_status_last_change_date', $format);
40			}
41
42			public function formattedCertificateExpirationDate(string $format = ''): string
43			{
44			return $this->formatDate('certificate_expiration_date', $format);
45			}
46
47			public function getChunkedLastFailureReasonAttribute(): string
48			{
49			if ($this->uptime_check_failure_reason == '') {
			0 ignored issues – show Bug introduced 2016-11-18 04:03 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `uptime_check_failure_reason` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
50			return '';
51			}
52
53			return chunk_split($this->uptime_check_failure_reason, 30, "\n");
54			}
55
56			public function getChunkedLastCertificateCheckFailureReasonAttribute(): string
57			{
58			if ($this->certificate_check_failure_reason == '') {
			0 ignored issues – show Bug introduced 2016-11-18 04:03 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `certificate_check_failure_reason` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
59			return '';
60			}
61
62			return chunk_split($this->certificate_check_failure_reason, 60, "\n");
63			}
64
65			protected function formatDate(string $attributeName, string $format = ''): string
66			{
67			if (! $this->$attributeName) {
68			return '';
69			}
70
71			if ($format === 'forHumans') {
72			return $this->$attributeName->diffForHumans();
73			}
74
75			if ($format === '') {
76			$format = config('laravel-uptime-monitor.notifications.date_format');
77			}
78
79			return $this->$attributeName->format($format);
80			}
81			}
82

GitHub Access Token became invalid

Push — master ( 2fe938...e8e1b6 )

src/Models/Presenters/MonitorPresenter.php (4 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

spatie / laravel-uptime-monitor

GitHub Access Token became invalid

Push — master ( 2fe938...e8e1b6 )

src/Models/Presenters/MonitorPresenter.php (4 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like