MonitorPresenter - Code Metrics - Inspection of "nitpicks" - spatie/laravel-uptime-monitor - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 98138f...e27c7f )

by Freek

created 2016-11-17 03:34 UTC

MonitorPresenter A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	65
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes

Metric	Value
wmc	14
lcom	1
cbo	1
dl	0
loc	65
rs	10
c	0
b	0
f	0

7 Methods

Rating	Name	Size	Complexity
A	getReachableAsEmojiAttribute()	12	3
A	getSslCertificateStatusAsEmojiAttribute()	12	3
A	getFormattedLastUpdatedStatusChangeDateAttribute()	4	1
A	getFormattedSslCertificateExpirationDateAttribute()	4	1
A	getChunkedLastFailureReasonAttribute()	8	2
A	getChunkedLastSslFailureReasonAttribute()	8	2
A	formatDate()	8	2

<?php

namespace Spatie\UptimeMonitor\Models\Presenters;

use Spatie\UptimeMonitor\Helpers\Emoji;
use Spatie\UptimeMonitor\Models\Enums\SslCertificateStatus;
use Spatie\UptimeMonitor\Models\Enums\UptimeStatus;

trait MonitorPresenter
{
    public function getReachableAsEmojiAttribute(): string
    {
        if ($this->uptime_status === UptimeStatus::UP) {
class MyClass { }

$x = new MyClass();
$x->foo = true;
            return Emoji::ok();
        }

        if ($this->uptime_status === UptimeStatus::DOWN) {
            return Emoji::notOk();
        }

        return '';
    }

    public function getSslCertificateStatusAsEmojiAttribute(): string
    {
        if ($this->ssl_certificate_status === SslCertificateStatus::VALID) {
class MyClass { }

$x = new MyClass();
$x->foo = true;
            return Emoji::ok();
        }

        if ($this->ssl_certificate_status === SslCertificateStatus::INVALID) {
            return Emoji::notOk();
        }

        return '';
    }

    public function getFormattedLastUpdatedStatusChangeDateAttribute(): string
    {
        return $this->formatDate('uptime_status_last_change_date');
    }

    public function getFormattedSslCertificateExpirationDateAttribute(): string
    {
        return $this->formatDate('ssl_certificate_expiration_date');
    }

    public function getChunkedLastFailureReasonAttribute(): string
    {
        if ($this->uptime_failure_reason == '') {
class MyClass { }

$x = new MyClass();
$x->foo = true;
            return '';
        }

        return chunk_split($this->uptime_failure_reason, 30, "\n");
    }

    public function getChunkedLastSslFailureReasonAttribute(): string
    {
        if ($this->ssl_certificate_failure_reason == '') {
class MyClass { }

$x = new MyClass();
$x->foo = true;
            return '';
        }

        return chunk_split($this->ssl_certificate_failure_reason, 60, "\n");
    }

    protected function formatDate(string $attributeName): string
    {
        if (! $this->$attributeName) {
            return '';
        }

        return $this->$attributeName->diffForHumans();
    }
}


1			<?php
2
3			namespace Spatie\UptimeMonitor\Models\Presenters;
4
5			use Spatie\UptimeMonitor\Helpers\Emoji;
6			use Spatie\UptimeMonitor\Models\Enums\SslCertificateStatus;
7			use Spatie\UptimeMonitor\Models\Enums\UptimeStatus;
8
9			trait MonitorPresenter
10			{
11			public function getReachableAsEmojiAttribute(): string
12			{
13			if ($this->uptime_status === UptimeStatus::UP) {
			0 ignored issues – show Bug introduced 2016-11-17 03:36 UTC by Report Bug Copy Issue Report The property `uptime_status` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
14			return Emoji::ok();
15			}
16
17			if ($this->uptime_status === UptimeStatus::DOWN) {
18			return Emoji::notOk();
19			}
20
21			return '';
22			}
23
24			public function getSslCertificateStatusAsEmojiAttribute(): string
25			{
26			if ($this->ssl_certificate_status === SslCertificateStatus::VALID) {
			0 ignored issues – show Bug introduced 2016-11-17 03:36 UTC by Report Bug Copy Issue Report The property `ssl_certificate_status` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
27			return Emoji::ok();
28			}
29
30			if ($this->ssl_certificate_status === SslCertificateStatus::INVALID) {
31			return Emoji::notOk();
32			}
33
34			return '';
35			}
36
37			public function getFormattedLastUpdatedStatusChangeDateAttribute(): string
38			{
39			return $this->formatDate('uptime_status_last_change_date');
40			}
41
42			public function getFormattedSslCertificateExpirationDateAttribute(): string
43			{
44			return $this->formatDate('ssl_certificate_expiration_date');
45			}
46
47			public function getChunkedLastFailureReasonAttribute(): string
48			{
49			if ($this->uptime_failure_reason == '') {
			0 ignored issues – show Bug introduced 2016-11-12 00:18 UTC by Report Bug Copy Issue Report The property `uptime_failure_reason` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
50			return '';
51			}
52
53			return chunk_split($this->uptime_failure_reason, 30, "\n");
54			}
55
56			public function getChunkedLastSslFailureReasonAttribute(): string
57			{
58			if ($this->ssl_certificate_failure_reason == '') {
			0 ignored issues – show Bug introduced 2016-11-12 20:52 UTC by Report Bug Copy Issue Report The property `ssl_certificate_failure_reason` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
59			return '';
60			}
61
62			return chunk_split($this->ssl_certificate_failure_reason, 60, "\n");
63			}
64
65			protected function formatDate(string $attributeName): string
66			{
67			if (! $this->$attributeName) {
68			return '';
69			}
70
71			return $this->$attributeName->diffForHumans();
72			}
73			}
74

spatie / laravel-uptime-monitor

GitHub Access Token became invalid

Push — master ( 98138f...e27c7f )

MonitorPresenter A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

7 Methods

Duplication Side-by-Side

Filter issues like