Spatie\UptimeMonitor\Notifications\Notifications\UptimeCheckRecovered

Complexity

Total Complexity

7

Size/Duplication

Total Lines	65
Duplicated Lines	40 %

Coupling/Cohesion

Components	1
Dependencies	7

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	toSlack()	12	12	1
A	getMonitorProperties()	0	8	1
A	isStillRelevant()	0	4	1
A	setEvent()	0	6	1
A	getMessageText()	0	4	1
A	toMail()	14	14	2

<?php

namespace Spatie\UptimeMonitor\Notifications\Notifications;

use Carbon\Carbon;
use Illuminate\Notifications\Messages\MailMessage;
use Illuminate\Notifications\Messages\SlackMessage;
use Spatie\UptimeMonitor\Models\Enums\UptimeStatus;
use Illuminate\Notifications\Messages\SlackAttachment;
use Spatie\UptimeMonitor\Notifications\BaseNotification;
use Spatie\UptimeMonitor\Events\UptimeCheckRecovered as MonitorRecoveredEvent;

class UptimeCheckRecovered extends BaseNotification
{
    /** @var \Spatie\UptimeMonitor\Events\UptimeCheckRecovered */
    public $event;

    /**
     * Get the mail representation of the notification.
     *
     * @param  mixed $notifiable
     * @return \Illuminate\Notifications\Messages\MailMessage
     */
    public function toMail($notifiable)

The parameter $notifiable is not used and could be removed.

This method seems to be duplicated in your project.

    {
        $mailMessage = (new MailMessage)
            ->success()
            ->subject($this->getMessageText())
            ->line($this->getMessageText())
            ->line($this->getLocationDescription());

        foreach ($this->getMonitorProperties() as $name => $value) {
            $mailMessage->line($name.': '.$value);
        }

        return $mailMessage;
    }

    public function toSlack($notifiable)

The parameter $notifiable is not used and could be removed.

This method seems to be duplicated in your project.

    {
        return (new SlackMessage)
            ->success()
            ->attachment(function (SlackAttachment $attachment) {
                $attachment
                    ->title($this->getMessageText())
                    ->fallback($this->getMessageText())
                    ->footer($this->getLocationDescription())
                    ->timestamp(Carbon::now());

It seems like \Carbon\Carbon::now() targeting Carbon\Traits\Creator::now() can also be of type object<Carbon\Traits\Creator>; however, Illuminate\Notifications\Messages\SlackAttachment::timestamp() does only seem to accept object<DateTimeInterface>|object<DateInterval>|integer, maybe add an additional type check?

            });
    }

    public function getMonitorProperties($extraProperties = []): array
    {
        $extraProperties = [
            "Downtime: {$this->event->downtimePeriod->duration()}" => $this->event->downtimePeriod->toText(),
        ];

        return parent::getMonitorProperties($extraProperties);
    }

    public function isStillRelevant(): bool
    {
        return $this->getMonitor()->uptime_status == UptimeStatus::UP;
    }

    public function setEvent(MonitorRecoveredEvent $event)
    {
        $this->event = $event;

        return $this;
    }

    public function getMessageText(): string
    {
        return "{$this->getMonitor()->url} has recovered after {$this->event->downtimePeriod->duration()}";
    }
}