SupportsCertificateCheck - Code Metrics - Inspection of "improve notifications" - spatie/laravel-uptime-monitor - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 150d64...174ec2 )

by Freek

created 2016-11-21 19:50 UTC

SupportsCertificateCheck A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	64
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	5

Importance

Changes

Metric	Value
wmc	11
lcom	1
cbo	5
dl	0
loc	64
c	0
b	0
f	0
rs	10

4 Methods

Rating	Name	Size	Complexity
A	checkCertificate()	10	2
B	fireEventsForUpdatedMonitorWithCertificate()	26	6
A	setCertificate()	12	2
A	setCertificateException()	10	1

<?php

namespace Spatie\UptimeMonitor\Models\Traits;

use Exception;
use Spatie\SslCertificate\Exceptions\CouldNotDownloadCertificate;
use Spatie\SslCertificate\SslCertificate;
use Spatie\UptimeMonitor\Events\CertificateCheckFailed;
use Spatie\UptimeMonitor\Events\CertificateExpiresSoon;
use Spatie\UptimeMonitor\Events\CertificateCheckSucceeded;
use Spatie\UptimeMonitor\Models\Enums\CertificateStatus;
use Spatie\UptimeMonitor\Models\Monitor;

trait SupportsCertificateCheck
{
    public function checkCertificate()
    {
        try {
            $certificate = SslCertificate::createForHostName($this->url->getHost());
class MyClass { }

$x = new MyClass();
$x->foo = true;

            $this->setCertificate($certificate);
        } catch (CouldNotDownloadCertificate $exception) {
            $this->setCertificateException($exception);
        }
    }

    public function setCertificate(SslCertificate $certificate)
    {
        $this->certificate_status = $certificate->isValid($this->url)
class MyClass { }

$x = new MyClass();
$x->foo = true;
            ? CertificateStatus::VALID
            : CertificateStatus::INVALID;

        $this->certificate_expiration_date = $certificate->expirationDate();
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->certificate_issuer = $certificate->getIssuer();
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->save();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

        $this->fireEventsForUpdatedMonitorWithCertificate($this, $certificate);
    }

    public function setCertificateException(Exception $exception)
    {
        $this->certificate_status = CertificateStatus::INVALID;
        $this->certificate_expiration_date = null;
        $this->certificate_issuer = '';
        $this->certificate_check_failure_reason = $exception->getMessage();
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->save();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

        event(new CertificateCheckFailed($this, $exception->getMessage()));
    }

    protected function fireEventsForUpdatedMonitorWithCertificate(Monitor $monitor, SslCertificate $certificate)
    {
        if ($this->certificate_status === CertificateStatus::VALID) {
            event(new CertificateCheckSucceeded($this, $certificate));

            if ($certificate->expirationDate()->diffInDays() <= config('laravel-uptime-monitor.certificate_check.fire_expiring_soon_event_if_certificate_expires_within_days')) {
                event(new CertificateExpiresSoon($monitor, $certificate));
            }

            return;
        }

        if ($this->certificate_status === CertificateStatus::INVALID) {
            $reason = 'Unknown';

            if ($certificate->appliesToUrl($this->url)) {
                $reason = "Certificate does not apply to {$this->url} but only to these domains: ".implode(',', $certificate->getAdditionalDomains());
            }

            if ($certificate->isExpired()) {
                $reason = 'The certificate is expired';
            }

            event(new CertificateCheckFailed($this, $reason, $certificate));
        }
    }
}


1			<?php
2
3			namespace Spatie\UptimeMonitor\Models\Traits;
4
5			use Exception;
6			use Spatie\SslCertificate\Exceptions\CouldNotDownloadCertificate;
7			use Spatie\SslCertificate\SslCertificate;
8			use Spatie\UptimeMonitor\Events\CertificateCheckFailed;
9			use Spatie\UptimeMonitor\Events\CertificateExpiresSoon;
10			use Spatie\UptimeMonitor\Events\CertificateCheckSucceeded;
11			use Spatie\UptimeMonitor\Models\Enums\CertificateStatus;
12			use Spatie\UptimeMonitor\Models\Monitor;
13
14			trait SupportsCertificateCheck
15			{
16			public function checkCertificate()
17			{
18			try {
19			$certificate = SslCertificate::createForHostName($this->url->getHost());
			0 ignored issues – show Bug introduced 2016-11-15 23:15 UTC by Report Bug Copy Issue Report The property `url` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
20
21			$this->setCertificate($certificate);
22			} catch (CouldNotDownloadCertificate $exception) {
23			$this->setCertificateException($exception);
24			}
25			}
26
27			public function setCertificate(SslCertificate $certificate)
28			{
29			$this->certificate_status = $certificate->isValid($this->url)
			0 ignored issues – show Bug introduced 2016-11-17 22:49 UTC by Report Bug Copy Issue Report The property `certificate_status` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
30			? CertificateStatus::VALID
31			: CertificateStatus::INVALID;
32
33			$this->certificate_expiration_date = $certificate->expirationDate();
			0 ignored issues – show Bug introduced 2016-11-17 22:49 UTC by Report Bug Copy Issue Report The property `certificate_expiration_date` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
34			$this->certificate_issuer = $certificate->getIssuer();
			0 ignored issues – show Bug introduced 2016-11-17 22:49 UTC by Report Bug Copy Issue Report The property `certificate_issuer` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
35			$this->save();
			0 ignored issues – show Bug introduced 2016-11-15 23:15 UTC by Report Bug Copy Issue Report It seems like `save()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
36
37			$this->fireEventsForUpdatedMonitorWithCertificate($this, $certificate);
38			}
39
40			public function setCertificateException(Exception $exception)
41			{
42			$this->certificate_status = CertificateStatus::INVALID;
43			$this->certificate_expiration_date = null;
44			$this->certificate_issuer = '';
45			$this->certificate_check_failure_reason = $exception->getMessage();
			0 ignored issues – show Bug introduced 2016-11-18 04:03 UTC by Report Bug Copy Issue Report The property `certificate_check_failure_reason` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
46			$this->save();
			0 ignored issues – show Bug introduced 2016-11-15 23:15 UTC by Report Bug Copy Issue Report It seems like `save()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
47
48			event(new CertificateCheckFailed($this, $exception->getMessage()));
49			}
50
51			protected function fireEventsForUpdatedMonitorWithCertificate(Monitor $monitor, SslCertificate $certificate)
52			{
53			if ($this->certificate_status === CertificateStatus::VALID) {
54			event(new CertificateCheckSucceeded($this, $certificate));
55
56			if ($certificate->expirationDate()->diffInDays() <= config('laravel-uptime-monitor.certificate_check.fire_expiring_soon_event_if_certificate_expires_within_days')) {
57			event(new CertificateExpiresSoon($monitor, $certificate));
58			}
59
60			return;
61			}
62
63			if ($this->certificate_status === CertificateStatus::INVALID) {
64			$reason = 'Unknown';
65
66			if ($certificate->appliesToUrl($this->url)) {
67			$reason = "Certificate does not apply to {$this->url} but only to these domains: ".implode(',', $certificate->getAdditionalDomains());
68			}
69
70			if ($certificate->isExpired()) {
71			$reason = 'The certificate is expired';
72			}
73
74			event(new CertificateCheckFailed($this, $reason, $certificate));
75			}
76			}
77			}
78

spatie / laravel-uptime-monitor

GitHub Access Token became invalid

Push — master ( 150d64...174ec2 )

SupportsCertificateCheck A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

4 Methods

Duplication Side-by-Side

Filter issues like