TailCommand::handle() - Code Metrics - Inspection of "Add support for Laravel 5.5" - spatie/laravel-tail - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#33)

by Freek

created 2017-08-30 11:33 UTC

TailCommand::handle() A

↳ Parent: TailCommand

Complexity

Conditions	2
Paths	2

Size

Total Lines	22
Code Lines	12

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	22
rs	9.2
cc	2
eloc	12
nc	2
nop	0

<?php

namespace Spatie\Tail;

use SplFileInfo;
use Illuminate\Console\Command;
use Illuminate\Support\Facades\File;
use Symfony\Component\Process\Process;

class TailCommand extends Command
{
    protected $signature = 'tail {--lines=100}';

    protected $description = 'Tail the latest logfile';

    public function handle()
    {
        $logDirectory = storage_path('logs');

        if (!$path = $this->findLatestLogFile($logDirectory)) {
            $this->warn("Could not find a log file in `{$logDirectory}`.");

            return;
        }

        $lines = $this->option('lines');

        $this->info("start tailing {$path}");

        $tailCommand = "tail -f -n {$lines} " . escapeshellarg($path);

        (new Process($tailCommand))
            ->setTimeout(null)
            ->run(function ($type, $line) {
                $this->output->write($line);
            });
    }

    protected function findLatestLogFile(string $directory)
    {
        $logFile = collect(File::allFiles($directory))
            ->sortByDesc(function (SplFileInfo $file) {
                return $file->getMTime();
            })
            ->first();

        return $logFile
            ? $logFile->getPathname()
            : false;
    }

    protected function executeCommand($command)

    {
        $output = $this->output;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}


    }
}


1			<?php
2
3			namespace Spatie\Tail;
4
5			use SplFileInfo;
6			use Illuminate\Console\Command;
7			use Illuminate\Support\Facades\File;
8			use Symfony\Component\Process\Process;
9
10			class TailCommand extends Command
11			{
12			protected $signature = 'tail {--lines=100}';
13
14			protected $description = 'Tail the latest logfile';
15
16			public function handle()
17			{
18			$logDirectory = storage_path('logs');
19
20			if (!$path = $this->findLatestLogFile($logDirectory)) {
21			$this->warn("Could not find a log file in `{$logDirectory}`.");
22
23			return;
24			}
25
26			$lines = $this->option('lines');
27
28			$this->info("start tailing {$path}");
29
30			$tailCommand = "tail -f -n {$lines} " . escapeshellarg($path);
31
32			(new Process($tailCommand))
33			->setTimeout(null)
34			->run(function ($type, $line) {
35			$this->output->write($line);
36			});
37			}
38
39			protected function findLatestLogFile(string $directory)
40			{
41			$logFile = collect(File::allFiles($directory))
42			->sortByDesc(function (SplFileInfo $file) {
43			return $file->getMTime();
44			})
45			->first();
46
47			return $logFile
48			? $logFile->getPathname()
49			: false;
50			}
51
52			protected function executeCommand($command)
			0 ignored issues – show Unused Code introduced 2017-08-30 11:35 UTC by Report Bug Copy Issue Report The parameter `$command` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
53			{
54			$output = $this->output;
			0 ignored issues – show Unused Code introduced 2017-08-30 11:35 UTC by Report Bug Copy Issue Report `$output` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
55
56
57			}
58			}
59

spatie / laravel-tail

GitHub Access Token became invalid

Pull Request — master (#33)

TailCommand::handle() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like