TailCommand::getFilters() - Code Metrics - Inspection of "Add '--hide-stack-traces' option" - spatie/laravel-tail - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#43)

unknown

created 2018-08-20 06:31 UTC

TailCommand::getFilters() A

↳ Parent: TailCommand

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	6
rs	10
c	0
b	0
f	0
cc	2
nc	2
nop	0

<?php

namespace Spatie\Tail;

use SplFileInfo;
use Illuminate\Console\Command;
use Illuminate\Support\Facades\File;
use Symfony\Component\Process\Process;

class TailCommand extends Command
{
    protected $signature = 'tail
                            {--lines=0 : Output the last number of lines}
                            {--H|hide-stack-traces : Filter out the stack traces}
                            {--clear : Clear the terminal screen}';

    protected $description = 'Tail the latest logfile';

    public function handle()
    {
        $logDirectory = storage_path('logs');

        if (! $path = $this->findLatestLogFile($logDirectory)) {
            $this->warn("Could not find a log file in `{$logDirectory}`.");

            return;
        }

        $lines = $this->option('lines');

        $filters = $this->getFilters();

        $tailCommand = "tail -f -n {$lines} {$filters} ".escapeshellarg($path);

        $this->handleClearOption();

        (new Process($tailCommand))
            ->setTimeout(null)
            ->run(function ($type, $line) {
                $this->handleClearOption();

                $this->output->write($line);
            });
    }

    protected function findLatestLogFile(string $directory)
    {
        $logFile = collect(File::allFiles($directory))
            ->sortByDesc(function (SplFileInfo $file) {
                return $file->getMTime();
            })
            ->first();

        return $logFile
            ? $logFile->getPathname()
            : false;
    }

    protected function handleClearOption()
    {
        if (! $this->option('clear')) {
            return;
        }

        $this->output->write(sprintf("\033\143\e[3J"));
    }

    protected function getFilters()
    {
        if ($this->option('hide-stack-traces')) {
            return '| grep -i -E "^\[\d{4}\-\d{2}\-\d{2} \d{2}:\d{2}:\d{2}\]|Next [\w\W]+?\:" --color';
        }
    }

    protected function executeCommand($command)

    {
        $output = $this->output;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
    }
}


1			<?php
2
3			namespace Spatie\Tail;
4
5			use SplFileInfo;
6			use Illuminate\Console\Command;
7			use Illuminate\Support\Facades\File;
8			use Symfony\Component\Process\Process;
9
10			class TailCommand extends Command
11			{
12			protected $signature = 'tail
13			{--lines=0 : Output the last number of lines}
14			{--H\|hide-stack-traces : Filter out the stack traces}
15			{--clear : Clear the terminal screen}';
16
17			protected $description = 'Tail the latest logfile';
18
19			public function handle()
20			{
21			$logDirectory = storage_path('logs');
22
23			if (! $path = $this->findLatestLogFile($logDirectory)) {
24			$this->warn("Could not find a log file in `{$logDirectory}`.");
25
26			return;
27			}
28
29			$lines = $this->option('lines');
30
31			$filters = $this->getFilters();
32
33			$tailCommand = "tail -f -n {$lines} {$filters} ".escapeshellarg($path);
34
35			$this->handleClearOption();
36
37			(new Process($tailCommand))
38			->setTimeout(null)
39			->run(function ($type, $line) {
40			$this->handleClearOption();
41
42			$this->output->write($line);
43			});
44			}
45
46			protected function findLatestLogFile(string $directory)
47			{
48			$logFile = collect(File::allFiles($directory))
49			->sortByDesc(function (SplFileInfo $file) {
50			return $file->getMTime();
51			})
52			->first();
53
54			return $logFile
55			? $logFile->getPathname()
56			: false;
57			}
58
59			protected function handleClearOption()
60			{
61			if (! $this->option('clear')) {
62			return;
63			}
64
65			$this->output->write(sprintf("\033\143\e[3J"));
66			}
67
68			protected function getFilters()
69			{
70			if ($this->option('hide-stack-traces')) {
71			return '\| grep -i -E "^\[\d{4}\-\d{2}\-\d{2} \d{2}:\d{2}:\d{2}\]\|Next [\w\W]+?\:" --color';
72			}
73			}
74
75			protected function executeCommand($command)
			0 ignored issues – show Unused Code introduced 2018-08-19 20:06 UTC by Report Bug Copy Issue Report The parameter `$command` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
76			{
77			$output = $this->output;
			0 ignored issues – show Unused Code introduced 2017-08-30 11:35 UTC by Report Bug Copy Issue Report `$output` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
78			}
79			}
80

spatie / laravel-tail

GitHub Access Token became invalid

Pull Request — master (#43)

TailCommand::getFilters() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like