Issues in HasSlug.php - New Issues - Inspection of "add support for slugs" - spatie/laravel-tags - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( d34e7e...89cfdb )

by Freek

created 2016-10-22 13:08 UTC

src/HasSlug.php (2 issues)

Labels

Bug 2

Severity

Minor 2

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Spatie\Tags;

use Illuminate\Database\Eloquent\Model;

trait HasSlug
{
    public static function bootHasSlug()
    {
        static::saving(function (Model $model) {
            $model->attributes['slug'] = $model->generateSlug();
        });
    }

    protected function generateSlug(): string
    {
        $slugs = [];

        foreach ($this->getTranslatedLocales('name') as $locale) {
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            $slugs[$locale] = str_slug($this->getTranslation('name', $locale));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        }

        return json_encode($slugs);
    }
}

1			<?php
2
3			namespace Spatie\Tags;
4
5			use Illuminate\Database\Eloquent\Model;
6
7			trait HasSlug
8			{
9			public static function bootHasSlug()
10			{
11			static::saving(function (Model $model) {
12			$model->attributes['slug'] = $model->generateSlug();
13			});
14			}
15
16			protected function generateSlug(): string
17			{
18			$slugs = [];
19
20			foreach ($this->getTranslatedLocales('name') as $locale) {
			0 ignored issues – show Bug introduced 2016-10-22 13:18 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `getTranslatedLocales()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
21			$slugs[$locale] = str_slug($this->getTranslation('name', $locale));
			0 ignored issues – show Bug introduced 2016-10-22 13:18 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `getTranslation()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
22			}
23
24			return json_encode($slugs);
25			}
26			}

spatie / laravel-tags

Push — master ( d34e7e...89cfdb )

src/HasSlug.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like