1 | <?php |
||
16 | class Controller extends IlluminateController |
||
17 | { |
||
18 | /** @var \Spatie\SlashCommand\Request */ |
||
19 | protected $request; |
||
20 | |||
21 | /** @var \Illuminate\Support\Collection */ |
||
22 | protected $config; |
||
23 | |||
24 | public function __construct(IlluminateRequest $request, Repository $config) |
||
25 | { |
||
26 | $this->request = Request::createFromIlluminateRequest($request); |
||
27 | |||
28 | $this->config = collect($config->get('laravel-slack-slash-command')); |
||
29 | } |
||
30 | |||
31 | public function getResponse(): IlluminateResponse |
||
32 | { |
||
33 | $this->guardAgainstInvalidRequest(); |
||
34 | |||
35 | $handler = $this->determineHandler(); |
||
36 | |||
37 | try { |
||
38 | $response = $handler->handle($this->request); |
||
39 | } catch (SlackSlashCommandException $exception) { |
||
40 | $response = $exception->getResponse($this->request); |
||
41 | } catch (Exception $exception) { |
||
42 | $response = $this->convertToResponse($exception); |
||
43 | } |
||
44 | |||
45 | return $response->getIlluminateResponse(); |
||
46 | } |
||
47 | |||
48 | protected function guardAgainstInvalidRequest() |
||
58 | |||
59 | /** |
||
60 | * @return \Spatie\SlashCommand\Handlers\BaseHandler |
||
61 | * |
||
62 | * @throws \Spatie\SlashCommand\Exceptions\RequestCouldNotBeHandled |
||
63 | */ |
||
64 | protected function determineHandler() |
||
85 | |||
86 | protected function convertToResponse(Exception $exception) : Response |
||
87 | { |
||
100 | } |
||
101 |
Let’s take a look at an example:
In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break.
Available Fixes
Change the type-hint for the parameter:
Add an additional type-check:
Add the method to the interface: