CanParseSignature - Code Metrics - Inspection of "add signature handler" - spatie/laravel-slack-slash-command - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 0e5848...31dbe9 )

by Freek

created 2016-07-13 21:17 UTC

CanParseSignature A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	24
Duplicated Lines	75 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
wmc	3
c	1
b	0
f	1
lcom	1
cbo	1
dl	18
loc	24
rs	10

1 Method

Rating	Name	Duplication	Size	Complexity
A	parseSignature()	18	18	3

How to fix Duplicated Code

<?php

namespace Spatie\SlashCommand;

use Symfony\Component\Console\Input\StringInput;

trait CanParseSignature
{
    /** @var StringInput */
    protected $input;

    protected function parseSignature()

    {
        list($name, $arguments, $options) = Parser::parse($this->signature);
class MyClass { }

$x = new MyClass();
$x->foo = true;

        $this->name = $name;
class MyClass { }

$x = new MyClass();
$x->foo = true;

        $inputDefinition = new InputDefinition();

        foreach($arguments as $argument) {
            $inputDefinition->addArgument($argument);
        }

        foreach($options as $option) {
            $inputDefinition->addOption($option);
        }

        $this->input = new StringInput($this->slashCommandData->text);
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }
}

1		<?php
2
3		namespace Spatie\SlashCommand;
4
5		use Symfony\Component\Console\Input\StringInput;
6
7		trait CanParseSignature
8		{
9		/** @var StringInput */
10		protected $input;
11
12	View Code Duplication	protected function parseSignature()
		0 ignored issues – show Duplication introduced 2016-07-13 21:19 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
13		{
14		list($name, $arguments, $options) = Parser::parse($this->signature);
		0 ignored issues – show Bug introduced 2016-07-13 21:19 UTC by Report Bug Copy Issue Report The property `signature` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
15
16		$this->name = $name;
		0 ignored issues – show Bug introduced 2016-07-13 21:19 UTC by Report Bug Copy Issue Report The property `name` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
17
18		$inputDefinition = new InputDefinition();
19
20		foreach($arguments as $argument) {
21		$inputDefinition->addArgument($argument);
22		}
23
24		foreach($options as $option) {
25		$inputDefinition->addOption($option);
26		}
27
28		$this->input = new StringInput($this->slashCommandData->text);
		0 ignored issues – show Bug introduced 2016-07-13 21:19 UTC by Report Bug Copy Issue Report The property `slashCommandData` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
29		}
30		}

spatie / laravel-slack-slash-command

GitHub Access Token became invalid

Push — master ( 0e5848...31dbe9 )

CanParseSignature A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

1 Method

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like