SlashCommandResponseJob::getSlashCommandResponse() - Code Metrics - Inspection of "wip" - spatie/laravel-slack-slash-command - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( c4effd...5428db )

by Freek

created 2016-07-12 19:30 UTC

SlashCommandResponseJob::getSlashCommandResponse() A

↳ Parent: SlashCommandResponseJob

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	4
c	0
b	0
f	0
rs	10
cc	1
eloc	2
nc	1
nop	0

<?php

namespace Spatie\SlashCommand\Jobs;

use Illuminate\Contracts\Queue\ShouldQueue;

abstract class SlashCommandResponseJob implements ShouldQueue, HandlesSlashCommand
{
    /** @var \Spatie\SlashCommand\SlashCommandData */
    public $slashCommandData;

    public function __construct(SlashCommandData $slashCommandData)
    {
        $this->slashCommandData = $slashCommandData;

    }
    
    public function getSlashCommandResponse(): SlashCommandResponse
    {
        return SlashCommandResponse::create($this->slashCommandData);
    }

    public function respondToSlack(string $text): SlashCommandResponse
    {
        return $this->getSlashCommandResponse()->setText($text);
    }

    abstract function handle();


}


1			<?php
2
3			namespace Spatie\SlashCommand\Jobs;
4
5			use Illuminate\Contracts\Queue\ShouldQueue;
6
7			abstract class SlashCommandResponseJob implements ShouldQueue, HandlesSlashCommand
8			{
9			/** @var \Spatie\SlashCommand\SlashCommandData */
10			public $slashCommandData;
11
12			public function __construct(SlashCommandData $slashCommandData)
13			{
14			$this->slashCommandData = $slashCommandData;
			0 ignored issues – show Documentation Bug introduced 2016-07-12 19:33 UTC by Report Bug Copy Issue Report It seems like `$slashCommandData` of type `object<Spatie\SlashCommand\Jobs\SlashCommandData>` is incompatible with the declared type `object<Spatie\SlashCommand\SlashCommandData>` of property `$slashCommandData`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
15			}
16
17			public function getSlashCommandResponse(): SlashCommandResponse
18			{
19			return SlashCommandResponse::create($this->slashCommandData);
20			}
21
22			public function respondToSlack(string $text): SlashCommandResponse
23			{
24			return $this->getSlashCommandResponse()->setText($text);
25			}
26
27			abstract function handle();
			0 ignored issues – show Best Practice introduced 2016-07-12 19:33 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
28
29			}
30

spatie / laravel-slack-slash-command

GitHub Access Token became invalid

Push — master ( c4effd...5428db )

SlashCommandResponseJob::getSlashCommandResponse() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like