Spatie\SlashCommand\SlashCommandHandler\BaseHandler

Complexity

Total Complexity

4

Size/Duplication

Total Lines	38
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	6	1
A	respondToSlack()	0	4	1
A	dispatch()	0	6	1
A	getSlashCommandData()	0	4	1
	handleCurrentRequest()	0	1	?
	canHandleCurrentRequest()	0	1	?

<?php

namespace Spatie\SlashCommand\SlashCommandHandler;

use Illuminate\Foundation\Bus\DispatchesJobs;
use Illuminate\Http\Request;
use Spatie\SlashCommand\HandlesSlashCommand;
use Spatie\SlashCommand\SlashCommandData;
use Spatie\SlashCommand\SlashCommandResponse;
use Spatie\SlashCommand\SlashCommandResponseJob;

abstract class BaseHandler implements HandlesSlashCommand
{
    use DispatchesJobs;

    /** @var \Spatie\SlashCommand\SlashCommandRequest */
    protected $request;

    /** @var \Spatie\SlashCommand\SlashCommandData */
    protected $slashCommandData;

    public function __construct(Request $request)

You have injected the Request via parameter $request. This is generally not recommended as there might be multiple instances during a request cycle (f.e. when using sub-requests). Instead, it is recommended to inject the RequestStack and retrieve the current request each time you need it via getCurrentRequest().

    {
        $this->request = $request;

It seems like $request of type object<Illuminate\Http\Request> is incompatible with the declared type object<Spatie\SlashCommand\SlashCommandRequest> of property $request.

        $this->slashCommandData = SlashCommandData::createForRequest($request);
    }

    public function respondToSlack(string $text): SlashCommandResponse
    {
        return SlashCommandResponse::create($this->slashCommandData)->setText($text);
    }

    protected function dispatch(SlashCommandResponseJob $job)
    {
        $job->slashCommandData = $this->slashCommandData;

        return app(Dispatcher::class)->dispatch($job);
    }

    public function getSlashCommandData(): SlashCommandData
    {
        return $this->getSlashCommandData();
    }

    abstract public function handleCurrentRequest(): SlashCommandResponse;

    abstract public function canHandleCurrentRequest(): bool;
}